Add crypto_stream_xchacha20_* to ext/sodium #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are applications that need direct access to XChaCha20 and not just the AEAD XChaCha20-Poly1305 API. These often resort to using the sodium_compat internal class instead of libsodium directly. This change (if adopted into ext/sodium and shipped with PHP 8.1+) will mitigate this misuse of an internal sodium_compat API.
Owner
|
Sure! Thank you so much for this, Scott! |
paragonie-security
added a commit
to paragonie/sodium_compat
that referenced
this pull request
Apr 13, 2021
See jedisct1/libsodium-php#211 for the upstream change
paragonie-security
added a commit
to paragonie/php-src
that referenced
this pull request
Apr 15, 2021
Paragon Initiative Enterprises is aware of PHP applications that use sodium_compat's ParagonIE\Sodium\Core\XChaCha20 class directly for stream encryption. Greater performance and security assurance is offered by exposing libsodium's crypto_stream_xchacha20 API to PHP users. It's acceptable to only include this change in PHP 8.1+; the offending applications are more than welcome to either install ext/sodium from PECL or upgrade to 8.1 when it comes out later this year. Ref: jedisct1/libsodium-php#211
paragonie-security
added a commit
to paragonie/php-src
that referenced
this pull request
Apr 15, 2021
Paragon Initiative Enterprises is aware of PHP applications that use sodium_compat's ParagonIE\Sodium\Core\XChaCha20 class directly for stream encryption. Greater performance and security assurance is offered by exposing libsodium's crypto_stream_xchacha20 API to PHP users. It's acceptable to only include this change in PHP 8.1+; the offending applications are more than welcome to either install ext/sodium from PECL or upgrade to 8.1 when it comes out later this year. Ref: jedisct1/libsodium-php#211
nikic
pushed a commit
to php/php-src
that referenced
this pull request
Apr 19, 2021
Paragon Initiative Enterprises is aware of PHP applications that use sodium_compat's ParagonIE\Sodium\Core\XChaCha20 class directly for stream encryption. Greater performance and security assurance is offered by exposing libsodium's crypto_stream_xchacha20 API to PHP users. It's acceptable to only include this change in PHP 8.1+; the offending applications are more than welcome to either install ext/sodium from PECL or upgrade to 8.1 when it comes out later this year. Ref: jedisct1/libsodium-php#211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are applications that need direct access to XChaCha20 and not just the AEAD XChaCha20-Poly1305 API. These often resort to using the sodium_compat internal class instead of libsodium directly.
This change (if adopted into ext/sodium and shipped with PHP 8.1+) will mitigate this misuse of an internal sodium_compat API.