Conversation
The banner used var(--vp-c-brand-1) as its background, but VitePress inverts the brand color between themes: in light mode it resolves to #3451b2 (dark indigo) — white text reads fine — but in dark mode it flips to #a8b1ff (light lavender), which makes the white banner text nearly invisible. Hardcode #3451b2 so the banner stays dark-indigo on white text in both themes. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Greptile SummaryFixes banner readability in dark mode by replacing the VitePress theme CSS variable Confidence Score: 5/5This is a safe, minimal CSS-only docs fix with no logic or data concerns. Single-line change in a docs CSS file that correctly addresses the described dark-mode contrast issue. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[VitePress Theme Mode] --> B{Light or Dark?}
B -->|Light mode| C["--vp-c-brand-1 = #3451b2 (dark indigo)"]
B -->|Dark mode| D["--vp-c-brand-1 = #a8b1ff (light lavender)"]
C --> E["Banner bg: #3451b2 ✅ white text readable"]
D --> F["Banner bg: #a8b1ff ❌ white text invisible (before fix)"]
D --> G["Banner bg: #3451b2 ✅ white text readable (after fix)"]
style F fill:#ff9999
style E fill:#99ff99
style G fill:#99ff99
Reviews (1): Last reviewed commit: "docs: use solid bg for banner so dark-mo..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage 79.03% 79.03%
=======================================
Files 48 48
Lines 7235 7235
Branches 7235 7235
=======================================
Hits 5718 5718
Misses 1140 1140
Partials 377 377 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
jdx
pushed a commit
that referenced
this pull request
May 3, 2026
### 🚀 Features - **(complete)** auto-completion for usage shebang scripts by [@jdx](https://github.com/jdx) in [#620](#620) ### 🐛 Bug Fixes - **(docs)** stack banner and pin close button on mobile by [@jdx](https://github.com/jdx) in [#603](#603) ### 📚 Documentation - **(site)** show release version and github stars by [@jdx](https://github.com/jdx) in [#604](#604) - add cross-site announcement banner by [@jdx](https://github.com/jdx) in [#600](#600) - fix banner dark-mode contrast by [@jdx](https://github.com/jdx) in [#601](#601) - respect banner expires field by [@jdx](https://github.com/jdx) in [#602](#602) - prefix star count with ★ glyph and populate it on deploy by [@jdx](https://github.com/jdx) in [#606](#606) - integrate Commander.js, oclif and yargs by [@gaojunran](https://github.com/gaojunran) in [#616](#616) - integrate Typer and Click by [@gaojunran](https://github.com/gaojunran) in [#619](#619) ### 🔍 Other Changes - **(docs)** remove shrill.en.dev analytics script by [@jdx](https://github.com/jdx) in [#614](#614) - **(release)** append en.dev sponsor blurb to release notes by [@jdx](https://github.com/jdx) in [#598](#598) - switch analytics from gtm to plausible by [@jdx](https://github.com/jdx) in [#609](#609) - pin taiki-e/install-action to commit SHA by [@jdx](https://github.com/jdx) in [#610](#610) - rename CLAUDE.md to AGENTS.md and symlink by [@jdx](https://github.com/jdx) in [#618](#618) ### 📦️ Dependency Updates - bump communique to 1.1.2 by [@jdx](https://github.com/jdx) in [#605](#605) - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#607](#607) - update autofix-ci/action action to v1.3.4 by [@renovate[bot]](https://github.com/renovate[bot]) in [#611](#611) - update apple-actions/import-codesign-certs action to v7 by [@renovate[bot]](https://github.com/renovate[bot]) in [#612](#612) - update taiki-e/install-action digest to fc9eae0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#613](#613) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
White banner text was unreadable in dark mode because VitePress inverts `--vp-c-brand-1` per theme:
Hardcode the banner bg to `#3451b2` so it stays dark with white text in both themes.
\U0001F916 Generated with Claude Code
Note
Low Risk
Low risk: a single CSS tweak hardcodes the banner background color to avoid theme-variable inversion; no logic or data flow changes.
Overview
For the docs site announcement banner, the background color is now hardcoded to
#3451b2instead of usingvar(--vp-c-brand-1), keeping white banner text readable in dark mode as well as light mode.Reviewed by Cursor Bugbot for commit 9fa2bc1. Bugbot is set up for automated code reviews on this repo. Configure here.