Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine release for version Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request handles the release of version v2.18.3, which primarily involves updating version numbers across various project files and refreshing dependency locks. The changes appear to be standard for a release. I've noted one minor issue in the CHANGELOG.md regarding an incorrect release date.
| @@ -1,5 +1,15 @@ | |||
| # Changelog | |||
|
|
|||
| ## [2.18.3](https://github.com/jdx/usage/compare/v2.18.2..v2.18.3) - 2026-03-06 | |||
Greptile SummaryThis is a fully automated Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["push to main\n(after PR merge)"] --> B["release-plz workflow"]
B --> C{"Is v3.0.0\nalready tagged?"}
C -- "No (first run)" --> D["cargo publish -p usage-lib\ncargo publish -p usage-cli"]
D --> E["git tag v3.0.0\ngit push --tags"]
E --> F["publish-cli.yml\ntriggered on v* tag"]
F --> G["create-release job\n(draft GitHub Release)"]
G --> H["build-and-publish job\n(cross-compile binaries\nfor 7 targets)"]
H --> I["release job\n(undraft GitHub Release)"]
I --> J["enhance-release job\n(communique AI summary)"]
C -- "Yes (subsequent runs)" --> K["git cliff --bumped-version\n→ calculate next version"]
K --> L["Update CHANGELOG.md\nbump versions\nregen docs"]
L --> M["Open/update\n'release' branch PR"]
Last reviewed commit: b44d9bb |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
=======================================
Coverage 77.94% 77.94%
=======================================
Files 48 48
Lines 6682 6682
Branches 6682 6682
=======================================
Hits 5208 5208
Misses 1114 1114
Partials 360 360 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dc95d1d to
8385025
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
b10aaa3 to
4e58fbb
Compare
) ## Summary - Adds `[bump]` section to `cliff.toml` with `breaking_always_bump_major = true` - Without this, `git cliff --bumped-version` ignored the `!` breaking change indicator in conventional commits (e.g. `feat!(spec):`) and only bumped the minor version instead of major - This caused the release PR #527 to incorrectly version as v2.18.3 instead of v3.0.0 ## Test plan - [ ] Verify `git cliff --bumped-version` returns a major bump when breaking commits exist 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: a config-only change that affects release/changelog version bumping, with no runtime code paths impacted. > > **Overview** > Updates `cliff.toml` to add a `[bump]` configuration enabling `breaking_always_bump_major = true`, so `git cliff --bumped-version` treats conventional-commit breaking changes (e.g., `!`/footer) as a **major** version bump during release automation. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bc3395c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.6 <[email protected]>
…545) ## Summary - `breaking_always_bump_major` from #544 didn't work — `git cliff --bumped-version` still returned `v2.18.3` instead of `v3.0.0` - Adds `custom_major_increment_regex` to explicitly match the `!` breaking change indicator in conventional commits (`feat!:`, `feat(scope)!:`, etc.) - This is a belt-and-suspenders fix alongside `breaking_always_bump_major` Follow-up to #544 ## Test plan - [ ] After merge, verify release automation updates PR #527 to v3.0.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk config-only change that affects version bumping; main risk is unintended major bumps if the regex matches more commit messages than expected. > > **Overview** > **Adjusts git-cliff bumping behavior** to more reliably detect breaking changes from conventional commits. > > Adds `custom_major_increment_regex` in `cliff.toml` to explicitly treat `feat!:` / `type(scope)!:` style messages as major-version increments, complementing `breaking_always_bump_major`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e77f510. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.6 <[email protected]>
473a578 to
4ed168a
Compare
🚀 Features
🐛 Bug Fixes
📚 Documentation
//by @muzimuzhi in #536🛡️ Security
🔍 Other Changes
📦️ Dependency Updates
New Contributors