Greptile Summary

This PR fixes a race condition in Docker-based e2e tests where root-owned files created inside the container could not be removed by the host runner after the container exited, causing cleanup errors to mask a passing test status under set -euo pipefail.

• Changes remove_isolated_env to perform a synchronous rm -rf (dropping the trailing &) when running inside Docker, so all test-created files are removed by the container's root process before Docker exits — leaving the host-side bind-mount directories empty and reliably removable.
• The non-Docker path retains the background cleanup (&) for performance, preserving existing behavior on local and non-namespaced runners.

Confidence Score: 5/5

Safe to merge — the change is a one-function, two-branch fix to a shell cleanup helper with no risk to test logic or production code.

The change is minimal and targeted: a single conditional added to remove_isolated_env that switches between synchronous and background cleanup based on a well-scoped environment variable. The fix correctly addresses the root cause — files created inside Docker as root need to be cleaned up from within the container before it exits, otherwise the host runner cannot remove them under set -e. All other code paths are unaffected.

No files require special attention.

_{Reviews (2): Last reviewed commit: "test(e2e): wait for docker env cleanup" | Re-trigger Greptile}

CI note: windows-e2e failed in zig.executes zig 2024.11.0-mach because both attempts timed out fetching https://pkg.hexops.org/zig/zig-windows-x86_64-0.14.0-dev.2577+271452d22.zip on the Windows runner. This is unrelated to the Docker e2e cleanup change in e2e/run_test; the Linux Docker e2e shards all passed, and the local Docker smoke output had no rm: cannot remove lines.

The aggregate test-ci check is red only because windows-e2e is red. I attempted to rerun the failed job, but GitHub rejected it because this account does not have repository admin rights.

This comment was generated by an AI coding assistant.