chore: prefer registry shorthands over cargo/npm backends in mise.toml#9595
chore: prefer registry shorthands over cargo/npm backends in mise.toml#9595
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new lockfile for the vfox crate, transitions tool definitions to use shorthands in mise.toml and mise.lock files, and updates several tool versions, including cargo-binstall and cargo-insta. The review feedback highlights a missing lock entry for prettier in the root lockfile following its transition to a shorthand, identifies an unintended version downgrade for git-cliff, and recommends adopting the cargo-release shorthand for better consistency.
I am having trouble creating individual review comments. Click here to see my feedback.
mise.lock (641-643)
prettier was removed from the lockfile here but was not added back as a shorthand entry [[tools.prettier]], even though it is still present in mise.toml (line 27). This will result in prettier not being locked to a specific version in the main project. Please ensure mise lock is run to include the locked version and checksums for the new prettier shorthand.
mise.lock (463)
The version of git-cliff has been downgraded from 2.12.0 to 2.10.0 in the lockfile. Since mise.toml specifies latest, this might be an unintended side effect of switching to the shorthand if the registry metadata is not up to date. It is recommended to verify if 2.12.0 can be maintained with the new shorthand.
mise.toml (16)
To be consistent with the other changes in this PR (preferring registry shorthands), you can use the cargo-release shorthand instead of the explicit github: backend. This also allows the key to be unquoted as it is a valid bare key in TOML.
cargo-release = "latest"
Greptile SummaryThis PR migrates several tools in Confidence Score: 4/5Safe to merge with awareness that cargo-insta is now missing arm64 Linux prebuilts under the aqua backend. A pre-existing P1 (arm64 Linux support regression for cargo-insta) was already surfaced in prior review threads and remains unresolved in this revision; per scoring guidelines a P1 caps confidence at 4/5. mise.lock — cargo-insta entry has no linux-arm64 platform variants; crates/vfox/mise.lock — git-cliff version (v2.10.0) lags behind root lock (v2.13.1). Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise.toml tool entry] --> B{Backend type}
B -->|cargo:cargo-insta| C1[Old: compile from source
Requires Rust toolchain on PATH
Supports all platforms incl. arm64]
B -->|cargo-insta shorthand| C2[New: aqua:mitsuhiko/insta
Prebuilt binary
Linux x64 only]
B -->|cargo:git-cliff| D1[Old: compile from source
Requires Rust toolchain]
B -->|git-cliff shorthand| D2[New: aqua:orhun/git-cliff
Prebuilt binary
All platforms incl. arm64]
B -->|cargo:cargo-release| E1[Old: compile from source]
B -->|github:crate-ci/cargo-release| E2[New: GitHub releases
Prebuilt binary
All platforms]
B -->|cargo:usage-cli + os constraint| F1[Old: Linux/macOS only
Requires Rust toolchain]
B -->|usage shorthand| F2[New: aqua:jdx/usage
Prebuilt binary
All platforms incl. Windows]
B -->|npm:prettier| G1[Old: Requires Node on PATH]
B -->|prettier shorthand| G2[New: npm:prettier via registry
Same backend, different resolution]
Reviews (4): Last reviewed commit: "chore: use registry prettier in hk.pkl" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
### 🚀 Features - **(backend)** support top-level aqua cosign verification by @risu729 in [#9111](#9111) ### 🐛 Bug Fixes - **(schema)** validate all schema files with draft2020 and strict mode by @risu729 in [#9594](#9594) - **(shim)** skip network resolution for installed tool dirs by @jdx in [#9599](#9599) ### 📚 Documentation - **(dev-tools)** clarify vfox metadata depends for install hooks by @risu729 in [#9573](#9573) - **(plugins)** remove registry submission guidance by @risu729 in [#9577](#9577) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9586](#9586) ### 📦 Registry - remove bashly asdf fallback by @risu729 in [#9578](#9578) - use github backend for rebar by @risu729 in [#9576](#9576) - add wasm-tools ([aqua:bytecodealliance/wasm-tools](https://github.com/bytecodealliance/wasm-tools)) by @2xdevv in [#9596](#9596) - enable symlink_bins for elixir-ls by @AlternateRT in [#9592](#9592) ### Chore - **(release)** always append sponsor block to release notes by @jdx in [#9580](#9580) - warn on vendored vfox embedded plugins by @risu729 in [#9588](#9588) - prefer registry shorthands over cargo/npm backends in mise.toml by @risu729 in [#9595](#9595) ## 📦 Aqua Registry Updates ### New Packages (2) - [`salesforce/reactive-grpc/protoc-gen-reactor-grpc`](https://github.com/salesforce/reactive-grpc) - [`spinframework/spin`](https://github.com/spinframework/spin) ### Updated Packages (1) - [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
2 participants
Switch several tools in
mise.tomlandcrates/vfox/mise.tomlfrom explicitcargo:/npm:backends to registry shorthands where available:cargo:git-cliff→git-cliffcargo:cargo-insta→cargo-instacargo:usage-cli→usage(also removes the os restriction)cargo:cargo-release→github:crate-ci/cargo-releasenpm:prettier→prettier"actionlint"→actionlint, etc.)crates/vfox/mise.lockand updatemise.lockThis avoids relying on the
cargo/npmbackends (which require a separately-installed toolchain on PATH) for tools that have registry entries backed by aqua/github.