Skip to content

registry: enable symlink_bins for elixir-ls#9592

Merged
jdx merged 1 commit intojdx:mainfrom
AlternateRT:elixir-ls-symlink
May 5, 2026
Merged

registry: enable symlink_bins for elixir-ls#9592
jdx merged 1 commit intojdx:mainfrom
AlternateRT:elixir-ls-symlink

Conversation

@AlternateRT
Copy link
Copy Markdown
Contributor

In the switch to the aqua backend, elixir-ls accidentally began to expose internal binaries that are not meant to be called directly; this fixes that problem

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 4, 2026

Greptile Summary

This PR enables symlink_bins for the aqua:elixir-lsp/elixir-ls backend in registry/elixir-ls.toml to fix an issue introduced when elixir-ls was migrated to the aqua backend, which unintentionally exposed internal binaries that should not be on PATH. The fix follows the exact same pattern already used by aws-cli.toml and aws-sam.toml.

Confidence Score: 5/5

Safe to merge — minimal, targeted fix consistent with established registry patterns.

Single-line config change using the same symlink_bins = "true" pattern already proven by aws-cli.toml and aws-sam.toml. The backend's string-comparison logic (v == "true" || v == "1") correctly handles this value. No logic changes, no new code paths.

No files require special attention.

Important Files Changed

Filename Overview
registry/elixir-ls.toml Adds symlink_bins = "true" to the aqua backend entry, preventing internal elixir-ls binaries from being exposed on PATH; consistent with how aws-cli.toml and aws-sam.toml handle the same pattern.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[mise install elixir-ls] --> B{Backend?}
    B -->|aqua:elixir-lsp/elixir-ls| C[Download release archive]
    B -->|asdf:mise-plugins/mise-elixir-ls| D[asdf install flow]
    C --> E{symlink_bins = true?}
    E -->|Yes - after this PR| F[Symlink only declared bins\ne.g. elixir-ls, elixir-ls-debugger]
    E -->|No - before this PR| G[Expose ALL binaries\nincl. internal ones on PATH]
    F --> H[Clean PATH - only public binaries visible]
    G --> I[Polluted PATH - internal binaries exposed]
Loading

Reviews (1): Last reviewed commit: "registry: enable symlink_bins for elixir..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the elixir-ls.toml registry file to configure the aqua backend with the symlink_bins option. I have no feedback to provide.

@jdx jdx merged commit 2a6e391 into jdx:main May 5, 2026
36 checks passed
@AlternateRT AlternateRT deleted the elixir-ls-symlink branch May 5, 2026 05:04
mise-en-dev added a commit that referenced this pull request May 5, 2026
### 🚀 Features

- **(backend)** support top-level aqua cosign verification by @risu729
in [#9111](#9111)

### 🐛 Bug Fixes

- **(schema)** validate all schema files with draft2020 and strict mode
by @risu729 in [#9594](#9594)
- **(shim)** skip network resolution for installed tool dirs by @jdx in
[#9599](#9599)

### 📚 Documentation

- **(dev-tools)** clarify vfox metadata depends for install hooks by
@risu729 in [#9573](#9573)
- **(plugins)** remove registry submission guidance by @risu729 in
[#9577](#9577)

### 📦️ Dependency Updates

- lock file maintenance by @renovate[bot] in
[#9586](#9586)

### 📦 Registry

- remove bashly asdf fallback by @risu729 in
[#9578](#9578)
- use github backend for rebar by @risu729 in
[#9576](#9576)
- add wasm-tools
([aqua:bytecodealliance/wasm-tools](https://github.com/bytecodealliance/wasm-tools))
by @2xdevv in [#9596](#9596)
- enable symlink_bins for elixir-ls by @AlternateRT in
[#9592](#9592)

### Chore

- **(release)** always append sponsor block to release notes by @jdx in
[#9580](#9580)
- warn on vendored vfox embedded plugins by @risu729 in
[#9588](#9588)
- prefer registry shorthands over cargo/npm backends in mise.toml by
@risu729 in [#9595](#9595)

## 📦 Aqua Registry Updates

### New Packages (2)

-
[`salesforce/reactive-grpc/protoc-gen-reactor-grpc`](https://github.com/salesforce/reactive-grpc)
- [`spinframework/spin`](https://github.com/spinframework/spin)

### Updated Packages (1)

- [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants