chore: warn on vendored vfox embedded plugins#9588
Conversation
Adds a warning for modifications to vendored vfox embedded plugins under crates/vfox/embedded-plugins/ in PRs, similarly to how we warn for aqua-registry.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Greptile SummaryThis PR extends the existing vendored-file warning workflow to also fire when Confidence Score: 4/5Safe to merge; only two P2 style suggestions with no functional impact. All findings are P2 — no upstream links in the new warning message, and both messages are shown regardless of which path triggered the job. Neither issue causes incorrect behavior; the workflow will still correctly fail on vendored file changes. .github/workflows/vendored-file-warning.yml — the single-step combined message could confuse contributors who only touched one of the two vendored paths. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR opened / updated] --> B{paths filter}
B -- "crates/aqua-registry/aqua-registry/**\nOR crates/vfox/embedded-plugins/**" --> C{author is jdx\nor mise-en-dev?}
B -- no matching paths --> Z[workflow skipped]
C -- yes --> Z
C -- no --> D[Fail on vendored file changes step]
D --> E[Print aqua-registry warning]
E --> F[Print vfox embedded-plugins warning]
F --> G[exit 1 — PR check fails]
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
### 🚀 Features - **(backend)** support top-level aqua cosign verification by @risu729 in [#9111](#9111) ### 🐛 Bug Fixes - **(schema)** validate all schema files with draft2020 and strict mode by @risu729 in [#9594](#9594) - **(shim)** skip network resolution for installed tool dirs by @jdx in [#9599](#9599) ### 📚 Documentation - **(dev-tools)** clarify vfox metadata depends for install hooks by @risu729 in [#9573](#9573) - **(plugins)** remove registry submission guidance by @risu729 in [#9577](#9577) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9586](#9586) ### 📦 Registry - remove bashly asdf fallback by @risu729 in [#9578](#9578) - use github backend for rebar by @risu729 in [#9576](#9576) - add wasm-tools ([aqua:bytecodealliance/wasm-tools](https://github.com/bytecodealliance/wasm-tools)) by @2xdevv in [#9596](#9596) - enable symlink_bins for elixir-ls by @AlternateRT in [#9592](#9592) ### Chore - **(release)** always append sponsor block to release notes by @jdx in [#9580](#9580) - warn on vendored vfox embedded plugins by @risu729 in [#9588](#9588) - prefer registry shorthands over cargo/npm backends in mise.toml by @risu729 in [#9595](#9595) ## 📦 Aqua Registry Updates ### New Packages (2) - [`salesforce/reactive-grpc/protoc-gen-reactor-grpc`](https://github.com/salesforce/reactive-grpc) - [`spinframework/spin`](https://github.com/spinframework/spin) ### Updated Packages (1) - [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
2 participants
Description
Adds a warning for modifications to vendored vfox embedded plugins under
crates/vfox/embedded-plugins/in PRs, similarly to how we warn foraqua-registry. This also marks them aslinguist-vendoredin.gitattributes.Popularity
N/A - CI/infrastructure change.