chore(release): always append sponsor block to release notes#9580
Merged
Conversation
The sponsor block was unintentionally limited to the communique-failure fallback branch in #9395, so successful releases (the normal case) lost the block starting with v2026.4.22. Move the cat >> heredoc back outside the if/else so it runs for both branches. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Greptile SummaryThis PR fixes a regression introduced in #9395 where the "💚 Sponsor mise" heredoc block was accidentally placed inside the Confidence Score: 5/5Safe to merge — minimal, targeted shell script fix with no logic issues. Single-line structural fix (moving No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Generate release notes step] --> B{communique generate succeeds?}
B -- Yes --> C[Write notes to /tmp/release-notes.txt\nSet RELEASE_TITLE with communique title]
B -- No --> D[Fallback: git-cliff or echo\nSet RELEASE_TITLE to VERSION only]
C --> E[fi — close if/else]
D --> E
E --> F[cat >> /tmp/release-notes.txt\nAppend 💚 Sponsor mise block]
F --> G[Create Draft GitHub Release]
Reviews (1): Last reviewed commit: "chore(release): always append sponsor bl..." | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.0 x -- echo |
18.1 ± 0.8 | 16.6 | 20.9 | 1.00 |
mise x -- echo |
18.4 ± 1.2 | 16.5 | 32.4 | 1.01 ± 0.08 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.0 env |
17.7 ± 0.7 | 16.2 | 20.4 | 1.00 |
mise env |
17.9 ± 0.8 | 16.4 | 22.5 | 1.01 ± 0.06 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.0 hook-env |
18.4 ± 0.7 | 16.7 | 21.2 | 1.00 |
mise hook-env |
18.7 ± 0.8 | 16.6 | 24.2 | 1.02 ± 0.06 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.0 ls |
15.3 ± 0.7 | 13.8 | 18.4 | 1.00 |
mise ls |
15.5 ± 0.7 | 14.0 | 19.6 | 1.01 ± 0.06 |
xtasks/test/perf
| Command | mise-2026.5.0 | mise | Variance |
|---|---|---|---|
| install (cached) | 121ms | 120ms | +0% |
| ls (cached) | 59ms | 59ms | +0% |
| bin-paths (cached) | 62ms | 64ms | -3% |
| task-ls (cached) | 526ms | 528ms | +0% |
mise-en-dev
added a commit
that referenced
this pull request
May 5, 2026
### 🚀 Features - **(backend)** support top-level aqua cosign verification by @risu729 in [#9111](#9111) ### 🐛 Bug Fixes - **(schema)** validate all schema files with draft2020 and strict mode by @risu729 in [#9594](#9594) - **(shim)** skip network resolution for installed tool dirs by @jdx in [#9599](#9599) ### 📚 Documentation - **(dev-tools)** clarify vfox metadata depends for install hooks by @risu729 in [#9573](#9573) - **(plugins)** remove registry submission guidance by @risu729 in [#9577](#9577) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9586](#9586) ### 📦 Registry - remove bashly asdf fallback by @risu729 in [#9578](#9578) - use github backend for rebar by @risu729 in [#9576](#9576) - add wasm-tools ([aqua:bytecodealliance/wasm-tools](https://github.com/bytecodealliance/wasm-tools)) by @2xdevv in [#9596](#9596) - enable symlink_bins for elixir-ls by @AlternateRT in [#9592](#9592) ### Chore - **(release)** always append sponsor block to release notes by @jdx in [#9580](#9580) - warn on vendored vfox embedded plugins by @risu729 in [#9588](#9588) - prefer registry shorthands over cargo/npm backends in mise.toml by @risu729 in [#9595](#9595) ## 📦 Aqua Registry Updates ### New Packages (2) - [`salesforce/reactive-grpc/protoc-gen-reactor-grpc`](https://github.com/salesforce/reactive-grpc) - [`spinframework/spin`](https://github.com/spinframework/spin) ### Updated Packages (1) - [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cat >> /tmp/release-notes.txt <<'EOF'heredoc back outside theif/elseso it runs in both branches, matching the behavior used for v2026.4.21.Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk workflow tweak that only changes the generated GitHub release notes content by ensuring the sponsor section is appended regardless of which release-notes generator succeeds.
Overview
Fixes the release workflow so the "💚 Sponsor mise" section is always appended to
/tmp/release-notes.txt, whether release notes are generated viacommuniqueor thegit-clifffallback.This restores consistent release-note output for normal (successful) releases by moving the sponsor heredoc outside the
if/elsein.github/workflows/release.yml.Reviewed by Cursor Bugbot for commit 115ac52. Bugbot is set up for automated code reviews on this repo. Configure here.