chore(ci): use !cancelled() instead of always() for test-ci aggregator by jdx · Pull Request #9569 · jdx/mise

jdx · 2026-05-03T15:21:03Z

Summary

Combined with the workflow's cancel-in-progress group (active on PRs), if: always() overrides cancellation and runs the test-ci aggregator even on superseded commits.
!cancelled() still runs on upstream success or failure but skips when the workflow is cancelled — saves a runner and avoids confusing error annotations on already-superseded shas.
Same pattern as the registry-ci fix in fix(ci): use !cancelled() instead of always() for registry-ci #7435; this one was missed.
Found while applying the same fix across sibling repos after Cursor Bugbot flagged it on chore(ci): add final aggregator job for branch protection endevco/pitchfork#413.

Test plan

CI passes on this PR

🤖 Generated with Claude Code

Note

Low Risk
Low risk: changes only a GitHub Actions job condition to avoid running the test-ci aggregator when a workflow is cancelled, without affecting build/test logic.

Overview
Updates the test-ci aggregator job in .github/workflows/test.yml to use if: ${{ !cancelled() }} instead of always(), so it still runs after upstream success/failure but is skipped when the workflow is cancelled (avoiding wasted runners and noisy failures on superseded runs).

^{Reviewed by Cursor Bugbot for commit c3f58b6. Bugbot is set up for automated code reviews on this repo. Configure here.}

Combined with the workflow's `cancel-in-progress` group (active on PRs), `if: always()` overrides cancellation and runs the aggregator even on superseded commits. `!cancelled()` still runs on upstream success or failure but skips when the workflow is cancelled. Same pattern as the registry-ci fix in #7435. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

gemini-code-assist · 2026-05-03T15:21:08Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

greptile-apps · 2026-05-03T15:22:00Z

Greptile Summary

Replaces always() with !cancelled() on the test-ci aggregator job so it is skipped when the workflow is cancelled by cancel-in-progress, while still running on upstream success or failure. The change correctly mirrors the existing pattern used in registry-ci and is consistent with the workflow's top-level cancel-in-progress: ${{ github.event_name != 'push' }} setting.

Confidence Score: 5/5

Safe to merge — single-line CI condition fix with no functional risk.

The change is a well-understood GitHub Actions pattern, consistent with the existing registry-ci fix in the same repo, and correctly scoped to the aggregator job only. No logic, security, or correctness concerns.

No files require special attention.

Important Files Changed

Filename	Overview
.github/workflows/test.yml	Replaces `always()` with `!cancelled()` on the `test-ci` aggregator job condition — straightforward and correct fix.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[New commit pushed to PR] --> B{cancel-in-progress\ncancels old run?}
    B -- No --> C[Upstream jobs run]
    C --> D{Upstream jobs\nresult}
    D -- success/failure --> E[test-ci runs\nvia !cancelled]
    D -- cancelled --> F[test-ci SKIPPED\nvia !cancelled]
    B -- Yes --> G[Workflow cancelled]
    G --> F

    subgraph OLD behaviour
        H[always] --> I[test-ci ALWAYS runs\neven after cancel]
    end
    subgraph NEW behaviour
        J[!cancelled] --> K[test-ci skips\non cancel]
    end

_{Reviews (1): Last reviewed commit: "chore(ci): use !cancelled() instead of a..." | Re-trigger Greptile}

github-actions · 2026-05-03T15:40:35Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 x -- echo`	22.1 ± 0.3	21.3	25.7	1.00
`mise x -- echo`	22.8 ± 0.4	21.9	27.0	1.03 ± 0.02

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 env`	22.1 ± 0.9	20.9	29.4	1.00
`mise env`	22.4 ± 0.7	21.3	30.5	1.01 ± 0.05

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 hook-env`	22.6 ± 0.5	21.6	24.6	1.00
`mise hook-env`	23.4 ± 0.6	22.1	25.2	1.03 ± 0.03

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 ls`	19.7 ± 0.3	18.9	22.3	1.00
`mise ls`	20.3 ± 0.5	19.3	22.3	1.03 ± 0.03

`xtasks/test/perf`

Command	mise-2026.4.28	mise	Variance
install (cached)	151ms	156ms	-3%
ls (cached)	76ms	78ms	-2%
bin-paths (cached)	81ms	83ms	-2%
task-ls (cached)	805ms	817ms	-1%

@jdx

### 🚀 Features - **(conda)** graduate conda backend out of experimental by @jdx in [#9544](#9544) - **(deps)** Add dart and flutter providers by @tjarvstrand in [#9505](#9505) - **(registry)** add neo4j by @mnm364 in [#9525](#9525) - **(registry)** add rustfs by @mnm364 in [#9530](#9530) - **(task)** support exclusion patterns in task sources by @jlarmstrongiv in [#9496](#9496) - **(vfox)** add stat function to lua file module by @esteve in [#9497](#9497) ### 🐛 Bug Fixes - **(backend)** flag regex prerelease versions by @jdx in [#9500](#9500) - **(backend)** mark -nightly/-canary/-experimental as prereleases by @jdx in [#9523](#9523) - **(backend)** suppress no-versions warning for unresolved-latest backends by @jdx in [#9548](#9548) - **(backend)** include dotnet prereleases from package flags by @jdx in [#9551](#9551) - **(backend)** scope PEP 440 prerelease detection to Python backends by @jdx in [#9558](#9558) - **(cargo)** Apply install_env during cargo install by @c22 in [#9502](#9502) - **(copr)** drop epel-9 chroots since rust >= 1.91 is unavailable by @jdx in [#9484](#9484) - **(github)** skip attestations on non-default api_url by @jdx in [#9486](#9486) - **(github)** retry ip allow list errors without auth by @risu729 in [#9506](#9506) - **(http)** update versions host tracking endpoint by @jdx in [#9527](#9527) - **(install)** don't warn for configured tools when version is passed via CLI by @jdx in [#9522](#9522) - **(install)** refresh latest before installing missing tools by @jdx in [#9545](#9545) - **(install)** don't cache nonexistent install paths by @jdx in [#9553](#9553) - **(lockfile)** don't propagate ad-hoc CLI overrides into the project lockfile by @jdx in [#9562](#9562) - **(plugin)** detect plugin types after cloning by @risu729 in [#9540](#9540) - **(release)** pass --no-git-checks to aube publish by @jdx in [#9483](#9483) - **(task)** convert PATH to MSYS Unix form when spawning POSIX shells on Windows by @JamBalaya56562 in [#9547](#9547) ### 📚 Documentation - **(contributing)** require popularity check for registry PRs by @jdx in [7bbeebe](7bbeebe) - **(watch)** update pitchfork domain to en.dev by @risu729 in [#9536](#9536) - document ghtkn GitHub token setup by @jdx in [#9546](#9546) - clarify registry backend acceptance policy by @jdx in [#9543](#9543) - Change exec command to use bash for variable echo by @kuboon in [#9567](#9567) ### 🧪 Testing - **(e2e)** run test-tool targets in parallel by @jdx in [#9564](#9564) - **(e2e)** run tests in parallel by @jdx in [#9563](#9563) - **(e2e)** bind-mount /tmp on disk and surface failed tests in CI summary by @jdx in [#9570](#9570) - **(tasks)** migrate test_task_help atask to usage field by @jdx in [#9549](#9549) ### 📦️ Dependency Updates - update fedora:45 docker digest to 8b838b3 by @renovate[bot] in [#9507](#9507) - update ghcr.io/jdx/mise:deb docker digest to f02194c by @renovate[bot] in [#9509](#9509) - update taiki-e/install-action digest to 7769b73 by @renovate[bot] in [#9512](#9512) - update ghcr.io/jdx/mise:alpine docker digest to 581f8a8 by @renovate[bot] in [#9508](#9508) - update rust crate ctor to v0.10.1 by @renovate[bot] in [#9515](#9515) - update ghcr.io/jdx/mise:rpm docker digest to a5c9655 by @renovate[bot] in [#9510](#9510) - update rust docker digest to a9cfb75 by @renovate[bot] in [#9511](#9511) - update rust crate age to v0.11.3 by @renovate[bot] in [#9514](#9514) - update rust crate jiff to v0.2.24 by @renovate[bot] in [#9516](#9516) - update dependency vitepress-plugin-tabs to ^0.9.0 by @renovate[bot] in [#9518](#9518) - update autofix-ci/action action to v1.3.4 by @renovate[bot] in [#9513](#9513) - update rust crate usage-lib to v3.2.1 by @renovate[bot] in [#9517](#9517) - update apple-actions/import-codesign-certs action to v7 by @renovate[bot] in [#9519](#9519) - update taiki-e/install-action digest to 51cd0b8 by @renovate[bot] in [#9531](#9531) - exclude taiki-e/install-action from renovate by @jdx in [#9532](#9532) - update rust crate blake3 to v1.8.5 by @renovate[bot] in [#9533](#9533) ### 📦 Registry - enable shellcheck on windows by @zeitlinger in [#9487](#9487) - add google-java-format by @zeitlinger in [#9488](#9488) - add expert ([aqua:expert-lsp/expert](https://github.com/expert-lsp/expert)) by @AlternateRT in [#9498](#9498) - update entry for checkmake by @eread in [#9504](#9504) - add systemctl-tui ([aqua:rgwood/systemctl-tui](https://github.com/rgwood/systemctl-tui)) by @2xdevv in [#9521](#9521) - add codon by @3w36zj6 in [#9538](#9538) - add tool yr (backend:github:VirusTotal/yara-x) by @adam-moss in [#9542](#9542) - add tool betterleaks (backend:aqua/betterleaks/betterleaks) by @adam-moss in [#9541](#9541) - add `git-filter-repo` by @garysassano in [#9550](#9550) - add umoci ([aqua:opencontainers/umoci](https://github.com/opencontainers/umoci)) by @2xdevv in [#9555](#9555) - add aqua backend for elixir-ls by @AlternateRT in [#9557](#9557) - deny inline backend options by @risu729 in [#9565](#9565) ### Chore - **(ci)** fail registry tests without summary by @jdx in [#9559](#9559) - **(ci)** use !cancelled() instead of always() for test-ci aggregator by @jdx in [#9569](#9569) - **(ci)** use namespace runners for ci jobs by @jdx in [#9561](#9561) - **(config)** deprecate shorthands_file setting by @risu729 in [#9534](#9534) - **(docs)** remove shrill.en.dev analytics script by @jdx in [#9539](#9539) - **(release)** replace bc with awk in release-plz star formatting by @jdx in [d7f177f](d7f177f) - bump hk to 1.44.3 by @jdx in [#9493](#9493) - invert CLAUDE.md/AGENTS.md so AGENTS.md is canonical by @jdx in [#9560](#9560) - set dev profile debug to 1 by @jdx in [#9572](#9572) ### New Contributors - @kuboon made their first contribution in [#9567](#9567) - @AlternateRT made their first contribution in [#9557](#9557) - @2xdevv made their first contribution in [#9555](#9555) - @adam-moss made their first contribution in [#9541](#9541) - @jlarmstrongiv made their first contribution in [#9496](#9496) - @tjarvstrand made their first contribution in [#9505](#9505)

jdx merged commit 7888309 into main May 3, 2026
27 checks passed

jdx deleted the ci/cancelled-fix branch May 3, 2026 15:26

mise-en-dev mentioned this pull request May 3, 2026

chore: release 2026.5.0 #9485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(ci): use !cancelled() instead of always() for test-ci aggregator#9569

chore(ci): use !cancelled() instead of always() for test-ci aggregator#9569
jdx merged 1 commit intomainfrom
ci/cancelled-fix

jdx commented May 3, 2026 •

edited by cursor Bot

Loading

Uh oh!

gemini-code-assist Bot commented May 3, 2026

Uh oh!

greptile-apps Bot commented May 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jdx commented May 3, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist Bot commented May 3, 2026

Uh oh!

greptile-apps Bot commented May 3, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

github-actions Bot commented May 3, 2026

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented May 3, 2026 •

edited by cursor Bot

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`