fix(http): update versions host tracking endpoint by jdx · Pull Request #9527 · jdx/mise

jdx · 2026-05-01T19:04:25Z

Summary

route anonymous install tracking through the tool-scoped mise-versions endpoint
encode the tool path segment before POSTing
add a small unit test covering path encoding for non-simple tool IDs

Validation

cargo fmt --check
cargo test versions_host::tests::test_track_install_url_encodes_tool_path_segment
pre-commit hook suite during commit, including cargo check --all-features

This PR was generated by an AI coding assistant.

Note

Low Risk
Low risk: only changes the anonymous install-tracking POST URL (and removes the tool field from the payload), affecting telemetry rather than core install behavior.

Overview
Routes install tracking requests to a new tool-scoped mise-versions endpoint by generating https://mise-versions.jdx.dev/api/tools/{tool} and URL-encoding the tool path segment.

Adds unit tests to ensure track_install_url() properly encodes complex tool IDs (e.g. ubi:https://...) while leaving simple names unchanged.

^{Reviewed by Cursor Bugbot for commit c8d69e7. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-05-01T19:07:14Z

Greptile Summary

This PR routes anonymous install-tracking POSTs from a shared /api/track endpoint to a new tool-scoped endpoint (/api/tools/{tool}), URL-encodes the tool path segment using the existing urlencoding crate, removes the now-redundant tool field from the JSON body, and adds two unit tests covering simple and complex tool IDs.

Confidence Score: 5/5

Safe to merge — change is isolated to anonymous fire-and-forget tracking; failures are already silently traced and non-blocking.

No P0/P1 findings. The diff is small and focused: URL construction, body field removal, and two unit tests. The urlencoding crate is already a verified dependency, and the PLUGINS_TRACK_DOWNLOADS guard ensures only simple registered tool names reach this code in production.

No files require special attention.

Important Files Changed

Filename	Overview
src/versions_host.rs	Tracking URL generation refactored to a `track_install_url` helper with percent-encoding; `tool` field dropped from the POST body; two unit tests added. Logic is sound and the `urlencoding` crate was already a dependency.

Sequence Diagram

sequenceDiagram
    participant C as mise client
    participant TI as track_install()
    participant TA as track_install_async()
    participant TU as track_install_url()
    participant S as mise-versions.jdx.dev

    C->>TI: tool, full, version
    TI->>TI: check offline / use_versions_host / PLUGINS_TRACK_DOWNLOADS
    TI->>TA: spawn async (tool, full, version)
    TA->>TU: tool
    TU-->>TA: "https://mise-versions.jdx.dev/api/tools/{encoded_tool}"
    TA->>S: POST /api/tools/{encoded_tool} { full, version, os, arch }
    S-->>TA: HTTP response
    TA-->>TI: (fire-and-forget, errors traced)

_{Reviews (2): Last reviewed commit: "test(http): cover registered versions ho..." | Re-trigger Greptile}

gemini-code-assist

Code Review

This pull request refactors the installation tracking logic by moving the tool identifier from the request body to a URL path parameter. It introduces a track_install_url helper function to handle URL encoding of the tool name and includes a unit test for verification. I have no feedback to provide.

github-actions · 2026-05-01T19:32:04Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 x -- echo`	17.5 ± 0.4	16.5	19.1	1.00
`mise x -- echo`	18.2 ± 0.4	16.9	19.6	1.04 ± 0.03

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 env`	17.2 ± 0.4	16.2	18.9	1.00
`mise env`	17.8 ± 0.6	16.8	21.5	1.03 ± 0.04

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 hook-env`	17.6 ± 0.4	16.8	20.0	1.00
`mise hook-env`	18.3 ± 0.3	17.2	19.5	1.04 ± 0.03

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.4.28 ls`	16.1 ± 0.3	15.3	17.0	1.00
`mise ls`	16.8 ± 0.3	15.9	18.2	1.05 ± 0.03

`xtasks/test/perf`

Command	mise-2026.4.28	mise	Variance
install (cached)	114ms	119ms	-4%
ls (cached)	64ms	66ms	-3%
bin-paths (cached)	67ms	68ms	-1%
task-ls (cached)	700ms	698ms	+0%

@jdx

### 🚀 Features - **(conda)** graduate conda backend out of experimental by @jdx in [#9544](#9544) - **(deps)** Add dart and flutter providers by @tjarvstrand in [#9505](#9505) - **(registry)** add neo4j by @mnm364 in [#9525](#9525) - **(registry)** add rustfs by @mnm364 in [#9530](#9530) - **(task)** support exclusion patterns in task sources by @jlarmstrongiv in [#9496](#9496) - **(vfox)** add stat function to lua file module by @esteve in [#9497](#9497) ### 🐛 Bug Fixes - **(backend)** flag regex prerelease versions by @jdx in [#9500](#9500) - **(backend)** mark -nightly/-canary/-experimental as prereleases by @jdx in [#9523](#9523) - **(backend)** suppress no-versions warning for unresolved-latest backends by @jdx in [#9548](#9548) - **(backend)** include dotnet prereleases from package flags by @jdx in [#9551](#9551) - **(backend)** scope PEP 440 prerelease detection to Python backends by @jdx in [#9558](#9558) - **(cargo)** Apply install_env during cargo install by @c22 in [#9502](#9502) - **(copr)** drop epel-9 chroots since rust >= 1.91 is unavailable by @jdx in [#9484](#9484) - **(github)** skip attestations on non-default api_url by @jdx in [#9486](#9486) - **(github)** retry ip allow list errors without auth by @risu729 in [#9506](#9506) - **(http)** update versions host tracking endpoint by @jdx in [#9527](#9527) - **(install)** don't warn for configured tools when version is passed via CLI by @jdx in [#9522](#9522) - **(install)** refresh latest before installing missing tools by @jdx in [#9545](#9545) - **(install)** don't cache nonexistent install paths by @jdx in [#9553](#9553) - **(lockfile)** don't propagate ad-hoc CLI overrides into the project lockfile by @jdx in [#9562](#9562) - **(plugin)** detect plugin types after cloning by @risu729 in [#9540](#9540) - **(release)** pass --no-git-checks to aube publish by @jdx in [#9483](#9483) - **(task)** convert PATH to MSYS Unix form when spawning POSIX shells on Windows by @JamBalaya56562 in [#9547](#9547) ### 📚 Documentation - **(contributing)** require popularity check for registry PRs by @jdx in [7bbeebe](7bbeebe) - **(watch)** update pitchfork domain to en.dev by @risu729 in [#9536](#9536) - document ghtkn GitHub token setup by @jdx in [#9546](#9546) - clarify registry backend acceptance policy by @jdx in [#9543](#9543) - Change exec command to use bash for variable echo by @kuboon in [#9567](#9567) ### 🧪 Testing - **(e2e)** run test-tool targets in parallel by @jdx in [#9564](#9564) - **(e2e)** run tests in parallel by @jdx in [#9563](#9563) - **(e2e)** bind-mount /tmp on disk and surface failed tests in CI summary by @jdx in [#9570](#9570) - **(tasks)** migrate test_task_help atask to usage field by @jdx in [#9549](#9549) ### 📦️ Dependency Updates - update fedora:45 docker digest to 8b838b3 by @renovate[bot] in [#9507](#9507) - update ghcr.io/jdx/mise:deb docker digest to f02194c by @renovate[bot] in [#9509](#9509) - update taiki-e/install-action digest to 7769b73 by @renovate[bot] in [#9512](#9512) - update ghcr.io/jdx/mise:alpine docker digest to 581f8a8 by @renovate[bot] in [#9508](#9508) - update rust crate ctor to v0.10.1 by @renovate[bot] in [#9515](#9515) - update ghcr.io/jdx/mise:rpm docker digest to a5c9655 by @renovate[bot] in [#9510](#9510) - update rust docker digest to a9cfb75 by @renovate[bot] in [#9511](#9511) - update rust crate age to v0.11.3 by @renovate[bot] in [#9514](#9514) - update rust crate jiff to v0.2.24 by @renovate[bot] in [#9516](#9516) - update dependency vitepress-plugin-tabs to ^0.9.0 by @renovate[bot] in [#9518](#9518) - update autofix-ci/action action to v1.3.4 by @renovate[bot] in [#9513](#9513) - update rust crate usage-lib to v3.2.1 by @renovate[bot] in [#9517](#9517) - update apple-actions/import-codesign-certs action to v7 by @renovate[bot] in [#9519](#9519) - update taiki-e/install-action digest to 51cd0b8 by @renovate[bot] in [#9531](#9531) - exclude taiki-e/install-action from renovate by @jdx in [#9532](#9532) - update rust crate blake3 to v1.8.5 by @renovate[bot] in [#9533](#9533) ### 📦 Registry - enable shellcheck on windows by @zeitlinger in [#9487](#9487) - add google-java-format by @zeitlinger in [#9488](#9488) - add expert ([aqua:expert-lsp/expert](https://github.com/expert-lsp/expert)) by @AlternateRT in [#9498](#9498) - update entry for checkmake by @eread in [#9504](#9504) - add systemctl-tui ([aqua:rgwood/systemctl-tui](https://github.com/rgwood/systemctl-tui)) by @2xdevv in [#9521](#9521) - add codon by @3w36zj6 in [#9538](#9538) - add tool yr (backend:github:VirusTotal/yara-x) by @adam-moss in [#9542](#9542) - add tool betterleaks (backend:aqua/betterleaks/betterleaks) by @adam-moss in [#9541](#9541) - add `git-filter-repo` by @garysassano in [#9550](#9550) - add umoci ([aqua:opencontainers/umoci](https://github.com/opencontainers/umoci)) by @2xdevv in [#9555](#9555) - add aqua backend for elixir-ls by @AlternateRT in [#9557](#9557) - deny inline backend options by @risu729 in [#9565](#9565) ### Chore - **(ci)** fail registry tests without summary by @jdx in [#9559](#9559) - **(ci)** use !cancelled() instead of always() for test-ci aggregator by @jdx in [#9569](#9569) - **(ci)** use namespace runners for ci jobs by @jdx in [#9561](#9561) - **(config)** deprecate shorthands_file setting by @risu729 in [#9534](#9534) - **(docs)** remove shrill.en.dev analytics script by @jdx in [#9539](#9539) - **(release)** replace bc with awk in release-plz star formatting by @jdx in [d7f177f](d7f177f) - bump hk to 1.44.3 by @jdx in [#9493](#9493) - invert CLAUDE.md/AGENTS.md so AGENTS.md is canonical by @jdx in [#9560](#9560) - set dev profile debug to 1 by @jdx in [#9572](#9572) ### New Contributors - @kuboon made their first contribution in [#9567](#9567) - @AlternateRT made their first contribution in [#9557](#9557) - @2xdevv made their first contribution in [#9555](#9555) - @adam-moss made their first contribution in [#9541](#9541) - @jlarmstrongiv made their first contribution in [#9496](#9496) - @tjarvstrand made their first contribution in [#9505](#9505)

fix(http): update versions host tracking endpoint

c8924f5

greptile-apps Bot reviewed May 1, 2026

View reviewed changes

Comment thread src/versions_host.rs

gemini-code-assist Bot reviewed May 1, 2026

View reviewed changes

test(http): cover registered versions host tracking URL

c8d69e7

jdx merged commit 9306daa into main May 1, 2026
36 checks passed

jdx deleted the codex/update-versions-host-track-endpoint branch May 1, 2026 19:49

mise-en-dev mentioned this pull request May 1, 2026

chore: release 2026.5.0 #9485

Merged

BrewTestBot mentioned this pull request May 3, 2026

mise 2026.5.0 Homebrew/homebrew-core#280712

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(http): update versions host tracking endpoint#9527

fix(http): update versions host tracking endpoint#9527
jdx merged 2 commits intomainfrom
codex/update-versions-host-track-endpoint

jdx commented May 1, 2026 •

edited by cursor Bot

Loading

Uh oh!

greptile-apps Bot commented May 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jdx commented May 1, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

greptile-apps Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions Bot commented May 1, 2026

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented May 1, 2026 •

edited by cursor Bot

Loading

greptile-apps Bot commented May 1, 2026 •

edited

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`