Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the configuration for installing the Go SDK, including the backend definitions for conda and asdf, the description, and the version test command. I have no feedback to provide as no review comments were submitted.
Greptile SummaryThis PR removes Confidence Score: 5/5Safe to merge — single file deletion with no remaining references and a clean, complete removal. Only finding is a P2 style issue with the PR title format. The code change itself is correct and complete. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User: mise install go-sdk] --> B{Registry lookup}
B -->|Before PR| C[go-sdk.toml found]
C --> D[Try conda:go]
D -->|Needs experimental mode| E[❌ Fails on standard install]
D -->|Fallback| F[Try asdf:mise-plugins/mise-go-sdk]
F --> G[❌ Fails on clean mise install]
B -->|After PR| H[go-sdk.toml removed]
H --> I[❌ Tool not found — no misleading fallback]
|
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.20 x -- echo |
22.1 ± 0.5 | 20.9 | 23.8 | 1.00 |
mise x -- echo |
22.6 ± 0.5 | 21.7 | 27.8 | 1.03 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.20 env |
21.6 ± 0.6 | 20.7 | 28.7 | 1.00 |
mise env |
22.2 ± 0.8 | 21.1 | 35.6 | 1.02 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.20 hook-env |
22.5 ± 0.6 | 21.5 | 26.1 | 1.00 |
mise hook-env |
23.0 ± 0.5 | 21.9 | 24.5 | 1.02 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.20 ls |
20.2 ± 0.8 | 19.3 | 32.3 | 1.00 |
mise ls |
20.8 ± 0.4 | 19.9 | 22.8 | 1.03 ± 0.05 |
xtasks/test/perf
| Command | mise-2026.4.20 | mise | Variance |
|---|---|---|---|
| install (cached) | 162ms | 167ms | -2% |
| ls (cached) | 77ms | 79ms | -2% |
| bin-paths (cached) | 80ms | 82ms | -2% |
| task-ls (cached) | 820ms | 790ms | +3% |
### 🚀 Features - **(registry)** add --security flag to include security info in JSON output by @jdx in [#9364](#9364) ### 🐛 Bug Fixes - **(config)** limit resolved backend opts to aliases by @risu729 in [#9315](#9315) - **(docs)** stack banner message and link on mobile by @jdx in [#9362](#9362) - **(github)** prefer shortest asset name as tiebreaker in auto-detection by @jdx in [#9361](#9361) - **(java)** newer zulu versions use a different directory structure by @roele in [#9365](#9365) - **(prune)** respect tracked lockfiles by @jdx in [#9373](#9373) - **(task)** skip tool install for missing naked tasks by @jdx in [#9374](#9374) - **(trust)** add untrust command by @jdx in [#9370](#9370) - fix - flux-operator-mcp aqua path by @monotek in [#9357](#9357) ### 📚 Documentation - update ruby compile msg by @fladson in [#9338](#9338) ### 📦️ Dependency Updates - update ubuntu docker tag to v26 by @renovate[bot] in [#9347](#9347) - update ghcr.io/jdx/mise:deb docker digest to 1af5a69 by @renovate[bot] in [#9352](#9352) - update taiki-e/install-action digest to 787505c by @renovate[bot] in [#9354](#9354) - update ghcr.io/jdx/mise:rpm docker digest to 7015ff3 by @renovate[bot] in [#9353](#9353) - update ghcr.io/jdx/mise:copr docker digest to da63a0f by @renovate[bot] in [#9351](#9351) - update ghcr.io/jdx/mise:alpine docker digest to 461700f by @renovate[bot] in [#9350](#9350) - bump communique 1.0.3 → 1.0.4 by @jdx in [#9378](#9378) ### 📦 Registry - remove openshift-install by @jdx in [#9372](#9372) - remove go-sdk by @jdx in [#9371](#9371) ### Chore - **(npm-publish)** use aube publish instead of npm publish by @jdx in [#9328](#9328) ### New Contributors - @fladson made their first contribution in [#9338](#9338)
Summary
Remove the
go-sdkshorthand from the registry. Its configured fallback behavior is misleading: the conda backend can install a Go toolchain only with experimental mode enabled, while the asdf fallback is a different SDK-management plugin and fails on a clean mise install.Validation
rg -n "go-sdk" registry docs src e2e settings.tomlgit diff --checkhklint suite during commit, includingcargo fmt --all -- --check,cargo check --all-features, taplo, schema, shellcheck, shfmt, actionlint, markdownlint, prettier, stylua, and lua-language-serverThis PR was generated by an AI coding assistant.
Note
Low Risk
Low risk: this only deletes a registry definition and does not change runtime logic, but it may affect users who relied on
go-sdkbeing available.Overview
Removes the
go-sdkshorthand from the registry by deleting its definition (registry/go-sdk.toml), eliminating the previous fallback backend configuration.Reviewed by Cursor Bugbot for commit bdeb5b6. Bugbot is set up for automated code reviews on this repo. Configure here.