Skip to content

chore: remove FUNDING.yml in favor of jdx/.github default#9331

Merged
jdx merged 1 commit intomainfrom
chore/remove-funding-yml
Apr 23, 2026
Merged

chore: remove FUNDING.yml in favor of jdx/.github default#9331
jdx merged 1 commit intomainfrom
chore/remove-funding-yml

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Apr 23, 2026

Summary

  • The jdx/.github repo now provides a default FUNDING.yml that applies to every jdx-owned repo without its own.
  • This repo's .github/FUNDING.yml is redundant with that default, so drop it.

Test plan

  • After merge, confirm the ♥ Sponsor button still appears on the repo (inherited from jdx/.github).

🤖 Generated with Claude Code


Note

Low Risk
Low risk: deletes a GitHub metadata file only, with no runtime/code-path impact; main risk is the Sponsor button/funding links relying on repository defaults being misconfigured.

Overview
Removes the repository-specific .github/FUNDING.yml, relying on the org-level default funding configuration instead.

Reviewed by Cursor Bugbot for commit 9ef82eb. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR removes the repo-level .github/FUNDING.yml (which contained only github: jdx) because the jdx/.github org-level repository now supplies that same default for all jdx-owned repos, making the local copy redundant.

Confidence Score: 5/5

Safe to merge — trivial housekeeping deletion with no code impact.

The only change is deleting a one-line YAML file that is now redundant with the org-level default. No logic, configuration, or runtime behaviour is affected.

No files require special attention.

Important Files Changed

Filename Overview
.github/FUNDING.yml Deleted single-line FUNDING.yml (github: jdx) — now inherited from the jdx/.github org-level default.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GitHub looks for FUNDING.yml] --> B{Repo has .github/FUNDING.yml?}
    B -- Yes (before PR) --> C[Use repo-level file\ngithub: jdx]
    B -- No (after PR) --> D{Org has .github/FUNDING.yml?}
    D -- Yes --> E[Use org-level default\njdx/.github → github: jdx]
    D -- No --> F[No Sponsor button]
    C --> G[♥ Sponsor button shown]
    E --> G
Loading

Reviews (1): Last reviewed commit: "chore: remove FUNDING.yml, covered by jd..." | Re-trigger Greptile

@jdx jdx merged commit 2d6190c into main Apr 23, 2026
20 of 22 checks passed
@jdx jdx deleted the chore/remove-funding-yml branch April 23, 2026 20:14
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'github: jdx' entry from the configuration file. There are no review comments to address, and I have no further feedback to provide.

@github-actions
Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.19 x -- echo 21.4 ± 1.1 20.7 37.0 1.00
mise x -- echo 21.9 ± 0.3 21.3 23.2 1.02 ± 0.05

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.19 env 20.9 ± 0.5 20.1 26.4 1.00
mise env 21.4 ± 0.3 20.8 23.3 1.03 ± 0.03

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.19 hook-env 21.5 ± 0.3 20.8 23.5 1.00
mise hook-env 22.0 ± 0.3 21.3 23.1 1.02 ± 0.02

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.19 ls 19.2 ± 0.4 18.6 23.3 1.00
mise ls 19.8 ± 0.2 19.3 20.7 1.03 ± 0.03

xtasks/test/perf

Command mise-2026.4.19 mise Variance
install (cached) 160ms 165ms -3%
ls (cached) 75ms 77ms -2%
bin-paths (cached) 79ms 81ms -2%
task-ls (cached) 799ms 799ms +0%

mise-en-dev added a commit that referenced this pull request Apr 24, 2026
### 🐛 Bug Fixes

- **(config)** resolve relative path: tool versions against config root
by @jdx in [#9320](#9320)
- **(lock)** resolve @latest and prune poisoned lockfile entries by @jdx
in [#9321](#9321)
- fix - be able to work with regex in attestation check by @monotek in
[#9327](#9327)

### 🚜 Refactor

- **(aqua)** bake aqua registry from merged yaml by @risu729 in
[#9043](#9043)

### 📚 Documentation

- add cross-site announcement banner by @jdx in
[#9326](#9326)
- keep banner height in sync via ResizeObserver by @jdx in
[#9330](#9330)
- respect banner expires field by @jdx in
[#9334](#9334)

### 📦️ Dependency Updates

- bump communique to 1.0.2 by @jdx in
[#9313](#9313)
- bump communique to 1.0.3 by @jdx in
[#9332](#9332)
- update actions/setup-node digest to 48b55a0 by @renovate[bot] in
[#9339](#9339)
- update ghcr.io/jdx/mise:alpine docker digest to a92efa5 by
@renovate[bot] in [#9340](#9340)
- update ghcr.io/jdx/mise:rpm docker digest to 5c24f69 by @renovate[bot]
in [#9343](#9343)
- update rust docker digest to e4f09e8 by @renovate[bot] in
[#9345](#9345)
- update rui314/setup-mold digest to 9c9c13b by @renovate[bot] in
[#9344](#9344)
- update ghcr.io/jdx/mise:deb docker digest to a3afe3e by @renovate[bot]
in [#9342](#9342)
- update ghcr.io/jdx/mise:copr docker digest to 4098d5a by
@renovate[bot] in [#9341](#9341)
- update taiki-e/install-action digest to 74e87cb by @renovate[bot] in
[#9346](#9346)

### Chore

- **(ci)** remove cargo-vendor install from ppa publish by @jdx in
[#9312](#9312)
- **(release)** publish snap to stable channel by @jdx in
[#9318](#9318)
- remove FUNDING.yml in favor of jdx/.github default by @jdx in
[#9331](#9331)

## 📦 Aqua Registry

Updated [aqua-registry](https://github.com/aquaproj/aqua-registry):
[v4.492.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.492.0)
->
[v4.498.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.498.0).

Included aqua-registry releases:

-
[v4.493.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.493.0)
-
[v4.494.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.494.0)
-
[v4.494.1](https://github.com/aquaproj/aqua-registry/releases/tag/v4.494.1)
-
[v4.495.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.495.0)
-
[v4.496.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.496.0)
-
[v4.497.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.497.0)
-
[v4.498.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.498.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant