chore(ci): remove cargo-vendor install from ppa publish#9312
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
Greptile SummaryThis PR removes the explicit Confidence Score: 5/5Safe to merge — removes a broken external dependency in favour of the built-in cargo vendor subcommand with no functional impact. The change is a three-line deletion that eliminates a broken install step. cargo vendor is a first-party Cargo subcommand available in every stable Rust release since 1.37, and the workflow already installs the stable toolchain. No logic, data, or security concerns are affected. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Set up Rust stable toolchain] --> B[Install mise]
B --> C[wait-for-gh-rate-limit]
C --> D["~~Install cargo-vendor~~\n(REMOVED)"]
D --> E["Vendor Rust dependencies\n(cargo vendor vendor/)"]
E --> F[Configure Git & GPG]
F --> G[Create source packages]
G --> H[Upload to PPA]
style D fill:#ffcccc,stroke:#ff0000,color:#000
Reviews (1): Last reviewed commit: "chore(ci): remove cargo-vendor install f..." | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.19 x -- echo |
21.5 ± 0.5 | 20.9 | 28.5 | 1.00 |
mise x -- echo |
22.1 ± 0.7 | 21.2 | 29.5 | 1.03 ± 0.04 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.19 env |
21.0 ± 0.4 | 20.2 | 24.8 | 1.00 |
mise env |
21.6 ± 0.7 | 20.8 | 30.0 | 1.03 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.19 hook-env |
21.8 ± 0.4 | 21.0 | 24.2 | 1.00 |
mise hook-env |
22.3 ± 0.4 | 21.5 | 27.9 | 1.03 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.19 ls |
19.2 ± 0.5 | 18.4 | 21.1 | 1.00 |
mise ls |
19.6 ± 0.3 | 19.0 | 20.9 | 1.02 ± 0.03 |
xtasks/test/perf
| Command | mise-2026.4.19 | mise | Variance |
|---|---|---|---|
| install (cached) | 162ms | 164ms | -1% |
| ls (cached) | 77ms | 79ms | -2% |
| bin-paths (cached) | 81ms | 82ms | -1% |
| task-ls (cached) | 808ms | 807ms | +0% |
mise-en-dev
added a commit
that referenced
this pull request
Apr 24, 2026
### 🐛 Bug Fixes - **(config)** resolve relative path: tool versions against config root by @jdx in [#9320](#9320) - **(lock)** resolve @latest and prune poisoned lockfile entries by @jdx in [#9321](#9321) - fix - be able to work with regex in attestation check by @monotek in [#9327](#9327) ### 🚜 Refactor - **(aqua)** bake aqua registry from merged yaml by @risu729 in [#9043](#9043) ### 📚 Documentation - add cross-site announcement banner by @jdx in [#9326](#9326) - keep banner height in sync via ResizeObserver by @jdx in [#9330](#9330) - respect banner expires field by @jdx in [#9334](#9334) ### 📦️ Dependency Updates - bump communique to 1.0.2 by @jdx in [#9313](#9313) - bump communique to 1.0.3 by @jdx in [#9332](#9332) - update actions/setup-node digest to 48b55a0 by @renovate[bot] in [#9339](#9339) - update ghcr.io/jdx/mise:alpine docker digest to a92efa5 by @renovate[bot] in [#9340](#9340) - update ghcr.io/jdx/mise:rpm docker digest to 5c24f69 by @renovate[bot] in [#9343](#9343) - update rust docker digest to e4f09e8 by @renovate[bot] in [#9345](#9345) - update rui314/setup-mold digest to 9c9c13b by @renovate[bot] in [#9344](#9344) - update ghcr.io/jdx/mise:deb docker digest to a3afe3e by @renovate[bot] in [#9342](#9342) - update ghcr.io/jdx/mise:copr docker digest to 4098d5a by @renovate[bot] in [#9341](#9341) - update taiki-e/install-action digest to 74e87cb by @renovate[bot] in [#9346](#9346) ### Chore - **(ci)** remove cargo-vendor install from ppa publish by @jdx in [#9312](#9312) - **(release)** publish snap to stable channel by @jdx in [#9318](#9318) - remove FUNDING.yml in favor of jdx/.github default by @jdx in [#9331](#9331) ## 📦 Aqua Registry Updated [aqua-registry](https://github.com/aquaproj/aqua-registry): [v4.492.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.492.0) -> [v4.498.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.498.0). Included aqua-registry releases: - [v4.493.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.493.0) - [v4.494.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.494.0) - [v4.494.1](https://github.com/aquaproj/aqua-registry/releases/tag/v4.494.1) - [v4.495.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.495.0) - [v4.496.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.496.0) - [v4.497.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.497.0) - [v4.498.0](https://github.com/aquaproj/aqua-registry/releases/tag/v4.498.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo:cargo-vendorinstall from the PPA publish workflowcargo vendorsubcommand already available from the Rust toolchaincargo-vendor v0.1.23no longer compiles on Rust 1.95Note
Low Risk
Low risk CI-only change that removes a third-party
cargo-vendorinstall; failure risk is limited to the PPA publish workflow ifcargo vendorbehavior differs from the removed tool.Overview
The PPA publish GitHub Actions workflow no longer installs
cargo-vendorviamiseand instead relies on the Rust toolchain’s built-incargo vendorwhen vendoring dependencies.This reduces external toolchain churn and avoids CI breakage from
cargo-vendorversion/Rust compatibility issues.Reviewed by Cursor Bugbot for commit c067a3e. Bugbot is set up for automated code reviews on this repo. Configure here.