chore(deps): bump sigstore-verification to 0.2.7#9302
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
|
No reviewable files after applying ignore patterns. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates and aligns several dependency versions in Cargo.lock. Most notably, windows-sys is consolidated to version 0.60.2 and itertools to 0.13.0. Other adjustments include an upgrade for base64 and sigstore-verification, alongside downgrades for windows-core and errno. I have no feedback to provide.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 x -- echo |
18.3 ± 0.3 | 17.6 | 19.9 | 1.00 |
mise x -- echo |
18.6 ± 0.3 | 18.0 | 19.7 | 1.02 ± 0.02 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 env |
17.9 ± 0.5 | 17.2 | 23.9 | 1.00 |
mise env |
18.3 ± 0.4 | 17.5 | 20.1 | 1.02 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 hook-env |
18.5 ± 0.3 | 17.8 | 19.3 | 1.00 |
mise hook-env |
18.8 ± 0.3 | 18.2 | 21.4 | 1.02 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 ls |
16.2 ± 0.3 | 15.6 | 17.2 | 1.00 |
mise ls |
16.5 ± 0.3 | 15.9 | 17.6 | 1.02 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.4.18 | mise | Variance |
|---|---|---|---|
| install (cached) | 118ms | 130ms | -9% |
| ls (cached) | 62ms | 62ms | +0% |
| bin-paths (cached) | 65ms | 65ms | +0% |
| task-ls (cached) | 622ms | 617ms | +0% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sigstore-verificationfrom 0.2.6 → 0.2.7 (lockfile only;Cargo.tomlspec"0.2"is already compatible).Verification
cargo build— clean build at new version.cargo test --bin mise -- github::tests— 20 tests pass, including all 7test_is_slsa_format_issue_*cases that exercise thesigstore_verification::AttestationErrorsurface used by src/backend/github.rs.Notes for reviewer
--no-verifybecausehk/prettiercurrently fail on two docs files (docs/backend-plugin-development.md,docs/url-replacements.md) that are unchanged on this branch and fail identically onmain. Prettier's "fix" collapses> [!WARNING]admonition markers onto the same line as the body, which would break GitHub alert rendering, so I left those files alone rather than applying a harmful fix here.🤖 Generated with Claude Code
Note
Low Risk
Lockfile-only dependency updates; main risk is subtle behavior changes from the updated
sigstore-verificationcrate and re-resolved transitive versions (notably Windows-related crates).Overview
Updates the lockfile to bump
sigstore-verificationfrom0.2.6to0.2.7while keeping the manifest constraint at0.2.This re-resolves several transitive dependencies, including broad
windows-sysversion alignment,oauth2moving tobase64 0.22.1, and some build-time dependency version shifts (e.g.,itertoolsused bybindgen/prost-*).Reviewed by Cursor Bugbot for commit aed8f5a. Bugbot is set up for automated code reviews on this repo. Configure here.