Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request introduces a new registry entry for the Kiro CLI tool. The feedback suggests correcting a likely typo in the backend identifier, improving the description's conciseness by removing redundant information and trailing punctuation, and adding a test field to ensure the installation is verified correctly.
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:kiro.dev/kiro-cli"] | |||
There was a problem hiding this comment.
The backend ID kiro.dev/kiro-cli appears to have a typo. If the tool is hosted on GitHub under the kiro-dev organization, the ID should be kiro-dev/kiro-cli. Using a dot instead of a hyphen will likely cause the aqua backend to fail to locate the package definition. Additionally, if the primary binary is named kiro, consider naming this file kiro.toml so users can install it via mise use kiro.
| backends = ["aqua:kiro.dev/kiro-cli"] | |
| backends = ["aqua:kiro-dev/kiro-cli"] |
There was a problem hiding this comment.
GitHub is https://github.com/kirodotdev/Kiro ,and is not opensource , so it is not typo.
the primary binary is named kiro-cli.
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:kiro.dev/kiro-cli"] | |||
| description = "Kiro CLI is an agentic coding tool that lives in your terminal" | |||
There was a problem hiding this comment.
Descriptions in the registry are typically more concise and omit the tool name if it matches the filename. Also, consider removing the trailing period for consistency with other entries.
| description = "Kiro CLI is an agentic coding tool that lives in your terminal" | |
| description = "Agentic coding tool that lives in your terminal" |
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:kiro.dev/kiro-cli"] | |||
| description = "Kiro CLI is an agentic coding tool that lives in your terminal" | |||
| os = ["linux", "macos"] | |||
There was a problem hiding this comment.
It is highly recommended to add a test field to verify the installation. Also, if the tool supports Windows, you should include it in the os list or remove the os field entirely if it is cross-platform.
| os = ["linux", "macos"] | |
| os = ["linux", "macos"] | |
| test = ["kiro-cli --version", "0.1"] |
Greptile SummaryAdds a new registry entry for Kiro CLI ( Confidence Score: 3/5Hold for P1 fix: the test command likely doesn't match the CLI's actual interface, which would cause installation verification to fail. The backend identifier and description are correct, but the registry/kiro-cli.toml — specifically the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise install kiro-cli] --> B[aqua backend\nkiro.dev/kiro-cli]
B --> C{OS check}
C -->|linux / macos| D[Download & install binary]
C -->|other OS| E[Blocked by os filter]
D --> F[Run test:\nkiro-cli --version]
F --> G{Output matches\n'kiro-cli VERSION'?}
G -->|Yes| H[Install verified ✓]
G -->|No / flag not found| I[Test fails ✗]
Reviews (2): Last reviewed commit: "fix test" | Re-trigger Greptile |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
| backends = ["aqua:kiro.dev/kiro-cli"] | ||
| description = "Kiro CLI is an agentic coding tool that lives in your terminal" | ||
| os = ["linux", "macos"] | ||
| test = { cmd = "kiro-cli --version", expected = "kiro-cli {{version}}" } |
There was a problem hiding this comment.
--version flag may not be supported
The official Kiro CLI docs only document kiro-cli version as a subcommand (e.g. kiro-cli version --changelog), with no mention of a --version global flag. If the CLI does not recognise --version, the test will fail for every installation. Consider aligning the test command with the documented invocation:
| test = { cmd = "kiro-cli --version", expected = "kiro-cli {{version}}" } | |
| test = { cmd = "kiro-cli version", expected = "kiro-cli {{version}}" } |
There was a problem hiding this comment.
--version is supported
### 🚀 Features - **(backend)** support aqua vars templates by @risu729 in [#9110](#9110) - add gsudo (Sudo for Windows) to registry by @matracey in [#9281](#9281) ### 🐛 Bug Fixes - **(cli)** retrieve token from github helper for `self-update` command by @sushichan044 in [#9259](#9259) - **(github)** scope auth headers to API URLs by @risu729 in [#9271](#9271) - **(vfox)** use github token for lua http requests by @jdx in [#9257](#9257) ### 📚 Documentation - add aube hero banner by @jdx in [#9265](#9265) - add en.dev footer by @jdx in [#9267](#9267) - implement landing page design by @jdx in [#9266](#9266) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9268](#9268) ### 📦 Registry - add llama.cpp ([github:ggml-org/llama.cpp](https://github.com/ggml-org/llama.cpp)) by @igor-makarov in [#9282](#9282) - add kiro-cli by @shalk in [#9274](#9274) - add flux-operator & flux-operator-mcp by @monotek in [#8852](#8852) ### Chore - **(release)** add en.dev sponsor blurb to release notes by @jdx in [#9272](#9272) - bump communique to 1.0.1 by @jdx in [#9264](#9264) ### New Contributors - @monotek made their first contribution in [#8852](#8852) - @igor-makarov made their first contribution in [#9282](#9282) ## 📦 Aqua Registry Updates #### New Packages (2) - [`controlplaneio-fluxcd/flux-operator/flux-operator-mcp`](https://github.com/controlplaneio-fluxcd/flux-operator/flux-operator-mcp) - [`endevco/aube`](https://github.com/endevco/aube) #### Updated Packages (1) - [`graelo/pumas`](https://github.com/graelo/pumas)
No description provided.