feat(backend): support top-level aqua cosign verification#9111
Conversation
Greptile SummaryThis PR adds support for top-level The implementation is clean: Confidence Score: 5/5Safe to merge — no correctness issues found; logic is consistent across lock and install paths. All changed paths are correct: No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[verify_provenance] --> B{locked_provenance?}
B -->|cosign| skip_others[skip attestations/slsa/minisign]
B -->|other/none| run_others[run attestations → slsa → minisign]
skip_others --> C{binary_cosign_config?}
run_others --> C
C -->|Some - key or bundle| D[cosign_artifact\nverify binary artifact\nrun_cosign_check target=artifact]
C -->|None| E{checksum enabled?}
D --> F[cosign_already_verified = true]
F --> E
E -->|yes| G{checksum_cosign_config\n AND NOT already_verified?}
G -->|yes| H[cosign_checksums\nverify checksum file\nrun_cosign_check target=checksum]
G -->|no| I[verify_checksum]
H --> I
E -->|no| I
D --> record_binary[record_cosign_provenance]
H --> record_checksum[record_cosign_provenance]
Reviews (8): Last reviewed commit: "refactor(backend): align aqua cosign det..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request introduces support for top-level binary cosign verification in the Aqua registry, allowing for direct artifact verification in addition to existing checksum-level checks. Key changes include updates to the AquaPackage structure, the implementation of cosign_artifact in the backend, and new E2E tests for lockfile provenance. A review comment suggests optimizing the cosign merging logic in apply_override to reduce redundant clones.
f2d2e26 to
c59ee6e
Compare
### 🚀 Features - **(backend)** support top-level aqua cosign verification by @risu729 in [#9111](#9111) ### 🐛 Bug Fixes - **(schema)** validate all schema files with draft2020 and strict mode by @risu729 in [#9594](#9594) - **(shim)** skip network resolution for installed tool dirs by @jdx in [#9599](#9599) ### 📚 Documentation - **(dev-tools)** clarify vfox metadata depends for install hooks by @risu729 in [#9573](#9573) - **(plugins)** remove registry submission guidance by @risu729 in [#9577](#9577) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9586](#9586) ### 📦 Registry - remove bashly asdf fallback by @risu729 in [#9578](#9578) - use github backend for rebar by @risu729 in [#9576](#9576) - add wasm-tools ([aqua:bytecodealliance/wasm-tools](https://github.com/bytecodealliance/wasm-tools)) by @2xdevv in [#9596](#9596) - enable symlink_bins for elixir-ls by @AlternateRT in [#9592](#9592) ### Chore - **(release)** always append sponsor block to release notes by @jdx in [#9580](#9580) - warn on vendored vfox embedded plugins by @risu729 in [#9588](#9588) - prefer registry shorthands over cargo/npm backends in mise.toml by @risu729 in [#9595](#9595) ## 📦 Aqua Registry Updates ### New Packages (2) - [`salesforce/reactive-grpc/protoc-gen-reactor-grpc`](https://github.com/salesforce/reactive-grpc) - [`spinframework/spin`](https://github.com/spinframework/spin) ### Updated Packages (1) - [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
Summary
Tests
This PR was generated by Copilot.