feat(backend): support aqua vars templates by risu729 · Pull Request #9110 · jdx/mise

risu729 · 2026-04-15T12:43:28Z

Summary

add support for aqua registry vars definitions in the aqua backend
render string vars as .Vars.<name> in aqua templates, including function arguments and chained property access
accept string vars from tool options as either vars = { name = "value" } or flat name = "value" keys
apply aqua-style required/default validation, while rejecting non-string var values with a focused error
include aqua string var options in lockfile artifact identity and bin-path cache keys so different var values do not reuse stale resolution data
document aqua vars options and required/default behavior

Background

Fixes Aqua backend doesn't handle `vars` in aqua registry #7160.
Aqua added registry vars in v2.31.0 via feat: add vars aquaproj/aqua#3052.
Aqua registry vars are exposed to templates as .Vars.<name> and can declare required and default fields; aqua applies defaults and errors when a required var has no value/default.
Current registry entries that need this include:
- aqua:flutter/flutter, which uses .Vars.channel with default stable
- aqua:scenarigo/scenarigo, which uses required .Vars.go_version

Difference From Aqua

Upstream aqua stores package vars as map[string]any and passes that map directly into Go templates, so arrays/objects/non-string scalar values can exist there.
mise's aqua registry renderer is string-oriented: template expansion ultimately resolves artifact names, URLs, and file paths as strings, and lockfile option identity is also string-valued.
This PR intentionally supports only string aqua var values/defaults. Non-string values such as arrays or objects now fail with an explicit error like aqua var \vars.fixture_version` must be a string, got array`.
This keeps the implementation narrow for the registry entries this PR targets, instead of reimplementing Go template value semantics.

Implementation Notes

crates/aqua-registry models vars, validates missing required vars, and accepts string defaults only.
The aqua backend maps mise tool options into string aqua var values before resolving assets, lockfile entries, installs, and bin paths.
Nested vars = { name = "value" } wins over flat name = "value", and both forms canonicalize to the same lockfile option identity.

Tests

cargo fmt --check
git diff --check -- . ':!mise.lock'
cargo test -p aqua-registry
cargo test backend::aqua::tests::
mise run test:e2e e2e/backend/test_aqua_vars

This PR was originally generated by Copilot and updated after manual review.

Co-authored-by: Copilot <[email protected]>

gemini-code-assist

Code Review

This pull request implements support for template variables (vars) within the aqua backend. Key changes include updating the template lexer and parser to handle chained property access, extending the AquaPackage model to support variable definitions with defaults and requirement checks, and integrating these variables into the tool installation process via tool options. Documentation and unit tests have been added to cover the new functionality. A review comment suggests refactoring duplicated identifier parsing logic in the template lexer to improve maintainability.

greptile-apps · 2026-04-15T12:49:07Z

Greptile Summary

This PR adds support for aqua registry vars template substitutions in the mise aqua backend, enabling tools like aqua:flutter/flutter ({{.Vars.channel}}) and aqua:scenarigo/scenarigo ({{.Vars.go_version}}) to work correctly. Users can provide var values as flat top-level keys or via a nested vars = {} table; both forms canonicalize to the same \"vars.key\" identity in the lockfile. The template engine is extended to resolve chained .Vars.name property access, and only string var values are accepted.

All remaining findings are P2: serde_yaml::Value::Null in a registry default is converted to an empty string instead of being treated as absent (diverging from Go aqua), and non-string scalars inside the nested vars = {} table fail type-checking while equivalent flat-key scalars are silently coerced by the TOML parser.

Confidence Score: 5/5

Safe to merge; no P0/P1 issues found, all remaining findings are P2 edge-case observations

The implementation is well-scoped and correctly handles the primary use cases. The two P2 findings are edge cases that don't affect real aqua registry entries. Test coverage (unit + e2e) is thorough.

crates/aqua-registry/src/types.rs (Null handling) and src/backend/aqua.rs (scalar coercion asymmetry)

Important Files Changed

Filename	Overview
crates/aqua-registry/src/types.rs	Adds vars support to AquaPackage with with_var_values/vars_ctx/validate_vars; Null default treated as empty string rather than absent
crates/aqua-registry/src/template.rs	Extends lexer to tokenise chained .Vars.name property access and adds eval_property shortcut for flat context keys
src/backend/aqua.rs	Adds apply_var_options, lockfile_options, aqua_var_option, toml_string_var; nested vars={} wins over flat keys; non-string scalars in nested table fail while flat scalars are coerced
e2e/backend/test_aqua_vars	E2e test covering flat-key vars, nested vars table, lockfile canonicalization, and array-value rejection
docs/dev-tools/backends/aqua.md	Adds vars option documentation with both flat-key and nested-table syntax examples
crates/aqua-registry/src/lib.rs	Re-exports AquaVar from types for use by the aqua backend
src/toolset/tool_version_options.rs	Unchanged in substance; existing scalar-to-string coercion in try_parse_as_toml is the source of the flat-key/nested-table asymmetry

Sequence Diagram

sequenceDiagram
    participant Config as mise.toml
    participant Backend as AquaBackend
    participant Registry as AquaRegistry
    participant Pkg as AquaPackage
    participant Template as template::render

    Config->>Backend: options with channel or vars={channel}
    Backend->>Registry: package_with_version(id, versions)
    Registry-->>Backend: AquaPackage with vars declared
    Backend->>Backend: apply_var_options(pkg, opts)
    note over Backend: nested vars{} wins over flat key
    Backend->>Pkg: with_var_values({channel:stable})
    Pkg->>Pkg: validate_vars()
    Pkg-->>Backend: AquaPackage with var_values set
    Backend->>Pkg: asset(v, os, arch)
    Pkg->>Pkg: vars_ctx() builds Vars.channel context
    Pkg->>Template: render template with ctx
    Template-->>Pkg: resolved asset string
    Backend->>Backend: lockfile_options(opts)
    note over Backend: all non-excluded keys prefixed vars.
    Backend-->>Config: lockfile entry vars.channel=stable

_{Reviews (9): Last reviewed commit: "test(backend): suppress aqua vars shellc..." | Re-trigger Greptile}

risu729 · 2026-04-19T05:01:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59c25a91c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T19:22:55Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector · 2026-04-21T04:42:17Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@risu729

### 🚀 Features - **(backend)** support aqua vars templates by @risu729 in [#9110](#9110) - add gsudo (Sudo for Windows) to registry by @matracey in [#9281](#9281) ### 🐛 Bug Fixes - **(cli)** retrieve token from github helper for `self-update` command by @sushichan044 in [#9259](#9259) - **(github)** scope auth headers to API URLs by @risu729 in [#9271](#9271) - **(vfox)** use github token for lua http requests by @jdx in [#9257](#9257) ### 📚 Documentation - add aube hero banner by @jdx in [#9265](#9265) - add en.dev footer by @jdx in [#9267](#9267) - implement landing page design by @jdx in [#9266](#9266) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9268](#9268) ### 📦 Registry - add llama.cpp ([github:ggml-org/llama.cpp](https://github.com/ggml-org/llama.cpp)) by @igor-makarov in [#9282](#9282) - add kiro-cli by @shalk in [#9274](#9274) - add flux-operator & flux-operator-mcp by @monotek in [#8852](#8852) ### Chore - **(release)** add en.dev sponsor blurb to release notes by @jdx in [#9272](#9272) - bump communique to 1.0.1 by @jdx in [#9264](#9264) ### New Contributors - @monotek made their first contribution in [#8852](#8852) - @igor-makarov made their first contribution in [#9282](#9282) ## 📦 Aqua Registry Updates #### New Packages (2) - [`controlplaneio-fluxcd/flux-operator/flux-operator-mcp`](https://github.com/controlplaneio-fluxcd/flux-operator/flux-operator-mcp) - [`endevco/aube`](https://github.com/endevco/aube) #### Updated Packages (1) - [`graelo/pumas`](https://github.com/graelo/pumas)

feat(backend): support aqua vars templates

a3a8619

Co-authored-by: Copilot <[email protected]>

gemini-code-assist Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread crates/aqua-registry/src/template.rs Outdated

greptile-apps Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread crates/aqua-registry/src/types.rs Outdated

risu729 marked this pull request as ready for review April 18, 2026 07:40

Merge branch 'main' into copilot/aqua-vars

e3a68e0

risu729 marked this pull request as draft April 18, 2026 07:42

risu729 added 3 commits April 19, 2026 03:50

fix(backend): validate aqua vars options

0bc97eb

Merge branch 'main' into copilot/aqua-vars

2ca0eff

fix(backend): repair aqua vars docs checks

59c25a9

chatgpt-codex-connector Bot reviewed Apr 19, 2026

View reviewed changes

Comment thread crates/aqua-registry/src/types.rs

Comment thread src/backend/aqua.rs

risu729 added 2 commits April 20, 2026 15:09

fix(backend): address aqua vars review feedback

dda6b12

test(backend): cover aqua vars install identity

5d9aff7

risu729 marked this pull request as ready for review April 20, 2026 19:22

risu729 marked this pull request as draft April 20, 2026 19:23

fix(backend): reject non-string aqua vars

d28759b

risu729 marked this pull request as ready for review April 21, 2026 04:42

test(backend): suppress aqua vars shellcheck warning

ca43738

jdx merged commit 60e2d5d into jdx:main Apr 21, 2026
35 checks passed

mise-en-dev mentioned this pull request Apr 21, 2026

chore: release 2026.4.19 #9258

Merged

risu729 deleted the copilot/aqua-vars branch April 21, 2026 18:18

BrewTestBot mentioned this pull request Apr 23, 2026

mise 2026.4.19 Homebrew/homebrew-core#279001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(backend): support aqua vars templates#9110

feat(backend): support aqua vars templates#9110
jdx merged 9 commits intojdx:mainfrom
risu729:copilot/aqua-vars

risu729 commented Apr 15, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

risu729 commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

risu729 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Difference From Aqua

Implementation Notes

Tests

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

risu729 commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

risu729 commented Apr 15, 2026 •

edited

Loading

greptile-apps Bot commented Apr 15, 2026 •

edited

Loading