registry: fix go-getter and mysql CI failures#8662
Conversation
- go-getter: remove test since v1.8.5 has no binary assets upstream - mysql: drop conda:mysql backend (metapackage with no binaries), keep asdf - mysql-client: add new entry using conda:mysql-client directly Co-Authored-By: Claude Opus 4.6 <[email protected]>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses CI failures related to go-getter and MySQL. It removes a failing test for go-getter and updates the MySQL configuration to use Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses CI failures for go-getter and mysql. For go-getter, the test is removed due to an upstream issue with missing binary assets in a recent release. For mysql, the change correctly removes a non-functional conda:mysql backend and introduces a new mysql-client tool using the proper conda:mysql-client backend. The changes are logical and well-justified. I have one suggestion to improve maintainability.
| @@ -1,3 +1,2 @@ | |||
| backends = ["aqua:hashicorp/go-getter", "asdf:mise-plugins/mise-go-getter"] | |||
| description = "Package for downloading things from a string URL using a variety of protocols" | |||
There was a problem hiding this comment.
To improve maintainability, it would be helpful to add a comment explaining why the test was removed. This provides context for future contributors and can prevent the test from being re-added without understanding the underlying upstream issue.
| description = "Package for downloading things from a string URL using a variety of protocols" | |
| description = "Package for downloading things from a string URL using a variety of protocols" | |
| # Test removed because upstream releases sometimes lack binary assets, causing CI to fail. |
Greptile SummaryThis PR fixes two recurring CI failures in the registry Key changes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise install mysql] --> B{backends}
B --> C[asdf:mise-plugins/mise-mysql]
C --> D[✅ MySQL server binary available]
E[mise install mysql-client] --> F{backends}
F --> G[conda:mysql-client]
G --> H[✅ mysql binary available]
I[mise install go-getter] --> J{backends}
J --> K[aqua:hashicorp/go-getter]
J --> L[asdf:mise-plugins/mise-go-getter]
K --> M[⚠️ v1.8.5 missing binary assets upstream]
K --> N[No test defined → skipped in CI]
style M fill:#ffcccc
style N fill:#ffffcc
style D fill:#ccffcc
style H fill:#ccffcc
Last reviewed commit: "registry: fix go-get..." |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| backends = ["conda:mysql-client"] | |||
There was a problem hiding this comment.
Every other conda-backed registry entry pairs conda: with an asdf: fallback (e.g. clang-format.toml, vim.toml, ghc.toml). With only conda:mysql-client, users who don't have conda available will get a hard failure on mise install mysql-client with no recovery path.
If there is no suitable asdf/aqua equivalent, this is acceptable, but it may be worth a comment or at least documenting it in the tool description (e.g. "MySQL Client (conda only)"). If an asdf plugin does exist in the future, adding it here would make the tool more broadly usable.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 x -- echo |
26.1 ± 0.3 | 25.7 | 31.4 | 1.00 |
mise x -- echo |
26.3 ± 0.5 | 25.6 | 31.6 | 1.01 ± 0.02 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 env |
25.6 ± 0.4 | 25.0 | 31.4 | 1.00 |
mise env |
25.8 ± 0.3 | 24.9 | 27.3 | 1.01 ± 0.02 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 hook-env |
26.3 ± 0.3 | 25.7 | 30.6 | 1.00 |
mise hook-env |
26.5 ± 0.3 | 25.7 | 27.8 | 1.01 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 ls |
25.2 ± 0.3 | 24.5 | 26.6 | 1.00 |
mise ls |
25.5 ± 0.3 | 24.8 | 27.5 | 1.01 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.3.9 | mise | Variance |
|---|---|---|---|
| install (cached) | 160ms | 160ms | +0% |
| ls (cached) | 89ms | 89ms | +0% |
| bin-paths (cached) | 91ms | 92ms | -1% |
| task-ls (cached) | 831ms | 828ms | +0% |
1 participant
Summary
test-toolto fail withno asset found: go-getter_1.8.5_linux_amd64.zipconda:mysqlbackend — it's a metapackage with no binaries; the actualmysqlbinary lives in themysql-clientdependency, so the conda install succeeds but.mise-binsis empty and the system mysql is found insteadconda:mysql-clientdirectlyTest plan
test-toolCI no longer fails for go-getter or mysqlmise install mysql-clientinstalls andmysql --versionreports the conda version🤖 Generated with Claude Code
Note
Low Risk
Registry-only metadata changes that adjust backends/tests; low risk beyond potentially changing which binaries are installed for MySQL-related tools.
Overview
Removes the
testcheck fromgo-getterto avoid failures when upstream releases lack binary assets.Updates
mysqlto drop theconda:mysqlbackend (leaving only themise-mysqlasdf backend) and adds a newmysql-clientregistry entry backed byconda:mysql-clientwith amysql --versiontest.Written by Cursor Bugbot for commit b04273d. This will update automatically on new commits. Configure here.