fix(installer): normalize current version before comparison#8649
fix(installer): normalize current version before comparison#8649
Conversation
Signed-off-by: tak848 <[email protected]>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the standalone installer where version comparisons were consistently failing due to a mismatch in how version strings were formatted. By normalizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Greptile SummaryThis PR fixes a long-standing bug in the standalone installer where the current-version fast-path (embedded checksums and CDN tarball URL) was never reached because Key changes:
The fix is minimal, correct, and well-scoped — the Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["install_mise() called"] --> B["version = MISE_VERSION or MISE_CURRENT_VERSION\nstrip leading v"]
A --> C["current_version = MISE_CURRENT_VERSION\nstrip leading v ← NEW"]
B --> D{"version == current_version\n(both v-stripped)?"}
C --> D
D -- "No (different version) OR\nMISE_INSTALL_FROM_GITHUB=1" --> E["tarball_url = GitHub releases URL\nhttps://github.com/.../mise-v{version}-..."]
D -- "Yes (current version) AND\nMISE_TARBALL_URL set" --> F["tarball_url = MISE_TARBALL_URL"]
D -- "Yes (current version) AND\nno override" --> G["tarball_url = CDN URL\nhttps://mise.jdx.dev/v{version}/..."]
E --> H["download_file(tarball_url)"]
F --> H
G --> H
H --> I["get_checksum(version, os, arch, ext)"]
I --> J["current_version = MISE_CURRENT_VERSION\nstrip leading v ← NEW"]
J --> K{"version == current_version?"}
K -- "Yes" --> L["Use embedded static checksums\n(MISE_CHECKSUM_* vars)"]
K -- "No" --> M["Fetch SHASUMS256.txt from GitHub releases"]
L --> N["Validate checksum → extract tarball"]
M --> N
Last reviewed commit: "fix(installer): norm..." |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug in the standalone installer script where version comparisons would fail due to inconsistent 'v' prefixes. The fix involves normalizing the MISE_CURRENT_VERSION variable before it's used in comparisons within the get_checksum and install_mise functions. My review includes suggestions to make the new code slightly more concise while maintaining correctness.
| current_version="$MISE_CURRENT_VERSION" | ||
| current_version="${current_version#v}" |
There was a problem hiding this comment.
This file is an envsubst template. $MISE_CURRENT_VERSION is substituted literally before the shell runs, so writing ${MISE_CURRENT_VERSION#v} would be expanded into ${v2026.3.9#v}, which breaks. The two-line form captures the substituted value into a local variable first, then strips the prefix.
| current_version="$MISE_CURRENT_VERSION" | ||
| current_version="${current_version#v}" |
There was a problem hiding this comment.
Same as above — envsubst constraint requires the two-line form.
|
coverage-7 failure is unrelated to this PR — caused by Java EA version bump (26 → 27). Fix is tracked in #8634 |
### 🐛 Bug Fixes - **(config)** resolve trust hash collision for same-name directories by @tdragon in [#8628](#8628) - **(docs)** fix width of tools table by @himkt in [#8625](#8625) - **(docs)** prevent homepage hero atmosphere overflow by @nygmaaa in [#8642](#8642) - **(doctor)** detect PATH ordering issues when mise is activated by @jdx in [#8585](#8585) - **(git)** use origin as remote name by @bentinata in [#8626](#8626) - **(installer)** normalize current version before comparison by @tak848 in [#8649](#8649) - **(lockfile)** Resolve symlink when updating lockfiles by @chancez in [#8589](#8589) - **(python)** verify checksums for precompiled binary downloads by @malept in [#8593](#8593) - **(rust)** resolve relative CARGO_HOME/RUSTUP_HOME to absolute paths by @simonepri in [#8604](#8604) - **(task)** correctly resolve task name for _default files with extensions by @youta1119 in [#8646](#8646) - **(tasks)** global file tasks not properly marked as such by @roele in [#8618](#8618) - **(tasks)** handle broken pipe in table print and task completion output by @vmaleze in [#8608](#8608) - use dark/light logo variants in README for GitHub dark mode by @jdx in [#8656](#8656) - failing rebuild of runtime symlinks for shared tools by @roele in [#8647](#8647) - add spaces around current element operator in flutter version_expr by @roele in [#8616](#8616) - complete task arguments correctly by @KevSlashNull in [#8601](#8601) ### 📚 Documentation - switch body font to DM Sans and darken dark mode background by @jdx in [6e3ad34](6e3ad34) - use Cormorant Garamond for headers and Roc Grotesk for body text by @jdx in [010812a](010812a) - resolve chaotic heading hierarchy in task-arguments.md by @muzimuzhi in [#8644](#8644) ### 🧪 Testing - fix test_java and mark as slow by @roele in [#8634](#8634) ### 📦️ Dependency Updates - update docker/dockerfile:1 docker digest to 4a43a54 by @renovate[bot] in [#8657](#8657) - update ghcr.io/jdx/mise:alpine docker digest to 2584470 by @renovate[bot] in [#8658](#8658) ### 📦 Registry - add viteplus (npm:vite-plus) by @risu729 in [#8594](#8594) - remove backend.options for podman by @roele in [#8633](#8633) - add pi.dev coding agent by @dector in [#8635](#8635) - add ormolu ([github:tweag/ormolu](https://github.com/tweag/ormolu)) by @3w36zj6 in [#8617](#8617) - use version_expr for dart and sort versions by @roele in [#8631](#8631) ### New Contributors - @bentinata made their first contribution in [#8626](#8626) - @tdragon made their first contribution in [#8628](#8628) - @nygmaaa made their first contribution in [#8642](#8642) - @youta1119 made their first contribution in [#8646](#8646) - @chancez made their first contribution in [#8589](#8589) - @dector made their first contribution in [#8635](#8635) - @tak848 made their first contribution in [#8649](#8649) ## 📦 Aqua Registry Updates #### New Packages (5) - [`acsandmann/rift`](https://github.com/acsandmann/rift) - [`alltuner/mise-completions-sync`](https://github.com/alltuner/mise-completions-sync) - [`berbicanes/apiark`](https://github.com/berbicanes/apiark) - [`gitlab.com/graphviz/graphviz`](https://github.com/gitlab.com/graphviz/graphviz) - [`jorgelbg/pinentry-touchid`](https://github.com/jorgelbg/pinentry-touchid) #### Updated Packages (7) - [`UpCloudLtd/upcloud-cli`](https://github.com/UpCloudLtd/upcloud-cli) - [`aquaproj/registry-tool`](https://github.com/aquaproj/registry-tool) - [`go-swagger/go-swagger`](https://github.com/go-swagger/go-swagger) - [`gopinath-langote/1build`](https://github.com/gopinath-langote/1build) - [`sassman/t-rec-rs`](https://github.com/sassman/t-rec-rs) - [`sharkdp/fd`](https://github.com/sharkdp/fd) - [`temporalio/cli`](https://github.com/temporalio/cli)
Summary
install.shformat unchangedProblem
The standalone installer strips the leading
vfrom the selected version before using it:version="${version#v}"But
MISE_CURRENT_VERSIONis rendered from the release tag form and still includes thevprefix.That means current-version checks never match, so the installer always falls back to the non-current-version path.
In practice, this bypasses:
Changes
MISE_CURRENT_VERSIONinto a localcurrent_versioninget_checksum()MISE_CURRENT_VERSIONinto a localcurrent_versionininstall_mise()install.shversion literal unchanged and only fix the comparisonsThis intentionally avoids changing the rendered
install.shformat. Bothversionandcurrent_versionundergo the same#vstrip; if you'd prefer, I can follow up by renaming both to make the normalized semantics more explicit.