Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where tasks defined in global configuration files were not being properly identified as global tasks. The changes introduce a new utility function to detect global task paths and integrate this logic into the task loading process, ensuring that all tasks sourced from global locations are correctly flagged. This fix improves the accuracy of task filtering and listing, particularly when using the --global option.

Highlights

• Bug Fix: Global Task Identification: Addressed an issue where tasks defined in global configuration files were not correctly marked as 'global', leading to them not appearing when filtered with --global.
• New Helper Function: Introduced is_global_task_include_path to determine if a given path points to a global task configuration directory.
• Task Loading Logic Update: Modified load_local_tasks_with_context, load_file_tasks, and load_tasks_in_dir to utilize the new helper function and explicitly set the global flag for tasks originating from global paths.
• E2E Test Enhancement: Updated the test_task_ls_global end-to-end test to include a global file-based task and verify that it is correctly listed under both general and global task listings.

Greptile Summary

This PR fixes a bug where file-based tasks located in the global task directory (~/.config/mise/tasks or the system config tasks dir) were not being tagged with global = true, causing them to be absent from mise tasks --global output.

The fix introduces two small helpers — is_global_task_include_path (path-component-aware check using Rust's starts_with) and mark_tasks_as_global — and applies them consistently across the three code paths that load file tasks: load_file_tasks, load_tasks_in_dir, and the no-config branch of the monorepo loader in load_local_tasks_with_context. An e2e test is added to cover the new behaviour.

Key points:

• is_global_task_include_path uses Path::starts_with, which compares by path component, so there are no false-positive matches for sibling directories (e.g. ~/.config/mise/tasks-custom is not matched).
• load_config_tasks (inline [tasks] entries) continues to use is_global_config to determine globalness; the new path-based approach applies only to file tasks. This is a pre-existing architectural split that isn't worsened by the PR.
• The e2e test correctly verifies the file task appears in mise tasks and mise tasks --global but not in mise tasks --local.

Confidence Score: 4/5

• Safe to merge; targeted fix with minimal blast radius and a covering e2e test.
• The change is small and surgical — two new helpers applied in three call sites. The path-component-level starts_with check is safe and correct. The only pre-existing asymmetry (path-based detection in load_file_tasks vs. config-file-based detection in load_config_tasks) is not introduced by this PR. The e2e test validates the primary scenario. Score of 4 rather than 5 to acknowledge the missing cleanup of test artifacts and the minor gap for the found_config=true monorepo branch (which is covered indirectly via load_file_tasks but not with an explicit guard at the call site).
• No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Load tasks] --> B{Source?}
    B --> C[load_file_tasks\nconfig includes]
    B --> D[load_tasks_in_dir\ntask_includes_for_dir]
    B --> E[load_local_tasks_with_context\nmonorepo, no config]

    C --> F{is_global_task_include_path?}
    D --> F
    E --> F

    F -- yes --> G[mark_tasks_as_global\ntask.global = true]
    F -- no --> H[task.global unchanged]

    G --> I[tasks returned]
    H --> I

    subgraph is_global_task_include_path
        J{path.starts_with\ndirs::CONFIG/tasks\nOR\ndirs::SYSTEM_CONFIG/tasks}
    end

    F --> J

_{Last reviewed commit: 5839c66}