fix: add spaces around current element operator in flutter version_expr by roele · Pull Request #8616 · jdx/mise

roele · 2026-03-16T18:30:11Z

The version_expr for flutter requires spaces around the current element operator otherwise it collides with the tera parser throwing a nasty error.

mise ERROR failed to parse template fromJSON(body).releases | filter({#.channel == "stable"}) | map({#.version}) | sortVersions() in ~/Downloads/mise/mise.toml
mise ERROR Failed to parse '__tera_one_off'
mise ERROR  --> 1:94
  |
1 | fromJSON(body).releases | filter({#.channel == "stable"}) | map({#.version}) | sortVersions()
  |                                                                                              ^---
  |
  = expected a comment end (`#}`)

gemini-code-assist · 2026-03-16T18:30:24Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical parsing error in the Flutter version_expr by introducing necessary spacing around the current element operator. This ensures that the version expression is correctly interpreted by the Tera parser, preventing runtime failures and allowing for accurate retrieval of Flutter versions.

Highlights

Fix Flutter version_expr parsing: Added spaces around the current element operator (#.) within the Flutter version_expr to resolve a parsing error caused by the Tera template engine.
Updated test case: Modified the corresponding test case in src/backend/version_list.rs to reflect the corrected version_expr format.

Changelog

registry/flutter.toml
- Modified the version_expr to include spaces around the current element operator (#.) to prevent parsing errors.
src/backend/version_list.rs
- Updated the test case for version_expr to match the new spacing requirements for the Flutter version expression.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request effectively addresses the Tera parser error by adding necessary spaces around the current element operator (#.) in the version_expr for Flutter. The change is consistently applied in both the registry/flutter.toml configuration and the corresponding test case in src/backend/version_list.rs, ensuring the fix is robust and tested. The solution is concise and directly resolves the reported issue without introducing new complexities or regressions.

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

greptile-apps · 2026-03-16T18:36:28Z

Greptile Summary

This PR fixes a tera template parser collision in version_expr configurations for Flutter and Julia. When a version_expr string contains {#, the contains_template_syntax check in mise_toml.rs flags it as a tera template, causing the tera parser to treat {# as the start of a comment block ({# ... #}) and throw a parse error. Adding spaces ({ # }) prevents the exact {# substring from appearing while keeping the expr-lang closure syntax valid.

Key changes:

registry/flutter.toml: {#.channel == "stable"} → { #.channel == "stable" } and {#.version} → { #.version }
registry/julia.toml: {# matches "..."} → { # matches "..." } (addresses the same bug raised in the previous review)
src/backend/version_list.rs: Both test cases updated to use the corrected spaced syntax, keeping tests in sync with the registry definitions

Confidence Score: 5/5

This PR is safe to merge — it applies a minimal, targeted fix with no functional regressions.
The change is a simple whitespace addition in three places (two registry TOML files and one test file). It directly fixes a documented parse error with no side effects: expr-lang accepts the spaced { # } closure syntax identically, the fix is verified by updated tests, and a grep of the registry directory confirms no other {# occurrences remain.
No files require special attention.

Important Files Changed

Filename	Overview
registry/flutter.toml	Fixed `{#` tera comment collision in `version_expr` by adding spaces around the current-element operator (`{ # }` instead of `{#}`), preventing the tera parser from treating the expression as a template comment.
registry/julia.toml	Same tera comment collision fixed in Julia's `version_expr` (`{ # matches ... }` instead of `{# matches ...}`), consistent with the Flutter fix and addressed from the previous review thread.
src/backend/version_list.rs	Test cases for both Flutter and Julia `version_expr` parsing updated to use the new spaced syntax, keeping tests in sync with the registry changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[mise.toml loads version_expr] --> B{contains_template_syntax check}
    B -->|"Old syntax: brace-hash triggers match"| C[Passed to Tera parser]
    B -->|"New syntax: space prevents match"| D[Skips Tera rendering]
    C --> E["ERROR: expected comment end"]
    D --> F[Passed directly to expr-lang eval]
    F --> G[filter / map closures evaluated]
    G --> H[Versions extracted successfully]

_{Last reviewed commit: 7466a76}

@tdragon

### 🐛 Bug Fixes - **(config)** resolve trust hash collision for same-name directories by @tdragon in [#8628](#8628) - **(docs)** fix width of tools table by @himkt in [#8625](#8625) - **(docs)** prevent homepage hero atmosphere overflow by @nygmaaa in [#8642](#8642) - **(doctor)** detect PATH ordering issues when mise is activated by @jdx in [#8585](#8585) - **(git)** use origin as remote name by @bentinata in [#8626](#8626) - **(installer)** normalize current version before comparison by @tak848 in [#8649](#8649) - **(lockfile)** Resolve symlink when updating lockfiles by @chancez in [#8589](#8589) - **(python)** verify checksums for precompiled binary downloads by @malept in [#8593](#8593) - **(rust)** resolve relative CARGO_HOME/RUSTUP_HOME to absolute paths by @simonepri in [#8604](#8604) - **(task)** correctly resolve task name for _default files with extensions by @youta1119 in [#8646](#8646) - **(tasks)** global file tasks not properly marked as such by @roele in [#8618](#8618) - **(tasks)** handle broken pipe in table print and task completion output by @vmaleze in [#8608](#8608) - use dark/light logo variants in README for GitHub dark mode by @jdx in [#8656](#8656) - failing rebuild of runtime symlinks for shared tools by @roele in [#8647](#8647) - add spaces around current element operator in flutter version_expr by @roele in [#8616](#8616) - complete task arguments correctly by @KevSlashNull in [#8601](#8601) ### 📚 Documentation - switch body font to DM Sans and darken dark mode background by @jdx in [6e3ad34](6e3ad34) - use Cormorant Garamond for headers and Roc Grotesk for body text by @jdx in [010812a](010812a) - resolve chaotic heading hierarchy in task-arguments.md by @muzimuzhi in [#8644](#8644) ### 🧪 Testing - fix test_java and mark as slow by @roele in [#8634](#8634) ### 📦️ Dependency Updates - update docker/dockerfile:1 docker digest to 4a43a54 by @renovate[bot] in [#8657](#8657) - update ghcr.io/jdx/mise:alpine docker digest to 2584470 by @renovate[bot] in [#8658](#8658) ### 📦 Registry - add viteplus (npm:vite-plus) by @risu729 in [#8594](#8594) - remove backend.options for podman by @roele in [#8633](#8633) - add pi.dev coding agent by @dector in [#8635](#8635) - add ormolu ([github:tweag/ormolu](https://github.com/tweag/ormolu)) by @3w36zj6 in [#8617](#8617) - use version_expr for dart and sort versions by @roele in [#8631](#8631) ### New Contributors - @bentinata made their first contribution in [#8626](#8626) - @tdragon made their first contribution in [#8628](#8628) - @nygmaaa made their first contribution in [#8642](#8642) - @youta1119 made their first contribution in [#8646](#8646) - @chancez made their first contribution in [#8589](#8589) - @dector made their first contribution in [#8635](#8635) - @tak848 made their first contribution in [#8649](#8649) ## 📦 Aqua Registry Updates #### New Packages (5) - [`acsandmann/rift`](https://github.com/acsandmann/rift) - [`alltuner/mise-completions-sync`](https://github.com/alltuner/mise-completions-sync) - [`berbicanes/apiark`](https://github.com/berbicanes/apiark) - [`gitlab.com/graphviz/graphviz`](https://github.com/gitlab.com/graphviz/graphviz) - [`jorgelbg/pinentry-touchid`](https://github.com/jorgelbg/pinentry-touchid) #### Updated Packages (7) - [`UpCloudLtd/upcloud-cli`](https://github.com/UpCloudLtd/upcloud-cli) - [`aquaproj/registry-tool`](https://github.com/aquaproj/registry-tool) - [`go-swagger/go-swagger`](https://github.com/go-swagger/go-swagger) - [`gopinath-langote/1build`](https://github.com/gopinath-langote/1build) - [`sassman/t-rec-rs`](https://github.com/sassman/t-rec-rs) - [`sharkdp/fd`](https://github.com/sharkdp/fd) - [`temporalio/cli`](https://github.com/temporalio/cli)

Copilot AI review requested due to automatic review settings March 16, 2026 18:30

Copilot started reviewing on behalf of roele March 16, 2026 18:30 View session

gemini-code-assist Bot reviewed Mar 16, 2026

View reviewed changes

Copilot AI reviewed Mar 16, 2026

View reviewed changes

greptile-apps Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread registry/flutter.toml

fix: add spaces around current element operator in flutter version_expr

7466a76

roele force-pushed the issues/8613 branch from 7aebea4 to 7466a76 Compare March 16, 2026 18:39

jdx merged commit 1212283 into jdx:main Mar 19, 2026
34 checks passed

mise-en-dev mentioned this pull request Mar 19, 2026

chore: release 2026.3.10 #8592

Merged

roele deleted the issues/8613 branch March 20, 2026 17:02

mise-en-dev mentioned this pull request Mar 21, 2026

chore: release 2026.3.11 #8676

Merged

BrewTestBot mentioned this pull request Mar 21, 2026

mise 2026.3.10 Homebrew/homebrew-core#273539

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add spaces around current element operator in flutter version_expr#8616

fix: add spaces around current element operator in flutter version_expr#8616
jdx merged 1 commit intojdx:mainfrom
roele:issues/8613

roele commented Mar 16, 2026

Uh oh!

gemini-code-assist Bot commented Mar 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

greptile-apps Bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

roele commented Mar 16, 2026

Uh oh!

gemini-code-assist Bot commented Mar 16, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

greptile-apps Bot commented Mar 16, 2026 •

edited

Loading