Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version update to "2026.3.10" for the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis is the automated release PR for mise Key observations:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Release PR: 2026.3.10] --> B[Version Bumps]
A --> C[Aqua Registry Updates]
A --> D[Completion Scripts Updated]
B --> B1[Cargo.toml: 2026.3.9 → 2026.3.10]
B --> B2[aqua-registry crate: 2026.3.6 → 2026.3.7]
B --> B3[default.nix / snapcraft.yaml / rpm.spec]
B --> B4[README.md version string]
C --> C1[New Packages x8]
C --> C2[Updated Packages x8]
C --> C3[Deleted: kaytu-io/kaytu]
C1 --> C1a[statebridge ⚠️ no windows_arm_emulation]
C1 --> C1b[mise-completions-sync ⚠️ no checksum]
C1 --> C1c[rift / berbicanes/apiark ⚠️ no checksum]
C1 --> C1d[atlassian.com/acli / graphviz / pinentry-touchid / agent-browser]
C2 --> C2a[aquaproj/registry-tool: binary renamed aqua-registry → argd]
C2 --> C2b[go-swagger: ARM support gaps in version ranges]
C2 --> C2c[gopinath-langote/1build: asset template + no_asset guard changes]
C2 --> C2d[sharkdp/fd / killport / t-rec-rs / upcloud-cli / sassman]
D --> D1[_mise / mise.bash / mise.fish / mise.ps1]
Last reviewed commit: "chore: release 2026...." |
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 2026.3.9 to 2026.3.10 across various files, including Cargo.toml, Cargo.lock, default.nix, README.md, packaging/rpm/mise.spec, snapcraft.yaml, and CHANGELOG.md, along with an update to the star count in docs/.vitepress/stars.data.ts. The review comments highlight an improvement opportunity in the completion scripts (_mise, mise.bash, mise.fish, mise.ps1), where the version is hardcoded into the spec_file path. This approach is considered brittle and requires manual updates for every release; a more robust solution is suggested to use a stable filename and regenerate the spec file only when the mise binary is newer than the cached spec.
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_3_10.spec" | ||
| if [[ ! -f "$spec_file" ]]; then | ||
| mise usage >| "$spec_file" | ||
| fi |
There was a problem hiding this comment.
Hardcoding the version in the spec_file path makes the completion script brittle, as it requires manual updates for every release.
A more robust approach would be to use a stable filename and regenerate the spec file only when the mise binary is newer than the cached spec. This would remove the need to update this file in every release PR.
local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise.spec"
if [[ ! -f "$spec_file" || "$(whence -p mise)" -nt "$spec_file" ]]; then
mise usage >| "$spec_file"
fi
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_3_10.spec" | ||
| if [[ ! -f "$spec_file" ]]; then | ||
| mise usage >| "$spec_file" | ||
| fi |
There was a problem hiding this comment.
Hardcoding the version in the spec_file path makes the completion script brittle, as it requires manual updates for every release.
A more robust approach would be to use a stable filename and regenerate the spec file only when the mise binary is newer than the cached spec. This would remove the need to update this file in every release PR.
local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise.spec"
if [[ ! -f "$spec_file" || "$(type -P mise)" -nt "$spec_file" ]]; then
mise usage >| "$spec_file"
fi
| set -l spec_file "$tmpdir/usage__usage_spec_mise_2026_3_10.spec" | ||
| if not test -f "$spec_file" | ||
| mise usage | string collect > "$spec_file" | ||
| end |
There was a problem hiding this comment.
Hardcoding the version in the spec_file path makes the completion script brittle, as it requires manual updates for every release.
A more robust approach would be to use a stable filename and regenerate the spec file only when the mise binary is newer than the cached spec. This would remove the need to update this file in every release PR.
set -l spec_file "$tmpdir/usage__usage_spec_mise.spec"
if not test -f "$spec_file" -o (test (command -v mise) -nt "$spec_file")
mise usage | string collect > "$spec_file"
end
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 x -- echo |
24.8 ± 0.6 | 23.7 | 29.8 | 1.02 ± 0.04 |
mise x -- echo |
24.3 ± 0.7 | 23.4 | 32.8 | 1.00 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 env |
23.8 ± 1.0 | 22.9 | 30.8 | 1.00 |
mise env |
24.4 ± 1.3 | 23.0 | 40.2 | 1.02 ± 0.07 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 hook-env |
24.5 ± 1.0 | 23.5 | 37.9 | 1.00 |
mise hook-env |
24.6 ± 0.6 | 23.4 | 29.0 | 1.00 ± 0.05 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 ls |
23.7 ± 0.7 | 22.5 | 26.3 | 1.00 |
mise ls |
23.8 ± 0.3 | 23.0 | 25.5 | 1.01 ± 0.03 |
xtasks/test/perf
| Command | mise-2026.3.9 | mise | Variance |
|---|---|---|---|
| install (cached) | 154ms | 152ms | +1% |
| ls (cached) | 84ms | 84ms | +0% |
| bin-paths (cached) | 87ms | 87ms | +0% |
| task-ls (cached) | 830ms | 822ms | +0% |
4a9e12a to
450e891
Compare
057dd36 to
f7c9cb5
Compare
2bc2ec5 to
29c5f4a
Compare
c314281 to
63ffd97
Compare
| - version_constraint: "true" | ||
| asset: statebridge_{{trimV .Version}}_{{.OS}}_{{.Arch}}.{{.Format}} | ||
| format: tar.gz | ||
| checksum: | ||
| type: github_release | ||
| asset: checksums.txt | ||
| algorithm: sha256 | ||
| cosign: | ||
| opts: | ||
| - --certificate-identity-regexp | ||
| - "^https://github\\.com/terraprovider/statebridge/\\.github/workflows/.+\\.ya?ml@refs/tags/\\Q{{.Version}}\\E$" | ||
| - --certificate-oidc-issuer | ||
| - https://token.actions.githubusercontent.com | ||
| bundle: | ||
| type: github_release | ||
| asset: checksums.txt.sigstore.json | ||
| slsa_provenance: | ||
| type: github_release | ||
| asset: multiple.intoto.jsonl | ||
| overrides: | ||
| - goos: windows | ||
| format: zip |
There was a problem hiding this comment.
Missing Windows ARM64 guard and OS/arch replacements
The "true" catch-all block has no replacements and no windows_arm_emulation: true. Two concerns:
-
Windows ARM64: With no
windows_arm_emulation: trueand nosupported_envsrestriction, aqua will attempt to resolvestatebridge_{{trimV .Version}}_windows_arm64.zipon Windows ARM64. If statebridge doesn't publish native Windows ARM64 binaries, this will silently 404 rather than falling back to x86_64 emulation. -
OS/arch naming: The asset template uses raw Go names (
darwin,linux,amd64,arm64) with no replacements. This is only correct if the upstream release assets literally match those names (e.g.statebridge_0.15.0_darwin_amd64.tar.gz). Many Go projects capitalize OS names (Darwin,Linux) — please confirm the actual release asset naming before merging.
If windows_arm_emulation is needed:
| - version_constraint: "true" | |
| asset: statebridge_{{trimV .Version}}_{{.OS}}_{{.Arch}}.{{.Format}} | |
| format: tar.gz | |
| checksum: | |
| type: github_release | |
| asset: checksums.txt | |
| algorithm: sha256 | |
| cosign: | |
| opts: | |
| - --certificate-identity-regexp | |
| - "^https://github\\.com/terraprovider/statebridge/\\.github/workflows/.+\\.ya?ml@refs/tags/\\Q{{.Version}}\\E$" | |
| - --certificate-oidc-issuer | |
| - https://token.actions.githubusercontent.com | |
| bundle: | |
| type: github_release | |
| asset: checksums.txt.sigstore.json | |
| slsa_provenance: | |
| type: github_release | |
| asset: multiple.intoto.jsonl | |
| overrides: | |
| - goos: windows | |
| format: zip | |
| - version_constraint: "true" | |
| asset: statebridge_{{trimV .Version}}_{{.OS}}_{{.Arch}}.{{.Format}} | |
| format: tar.gz | |
| windows_arm_emulation: true | |
| checksum: |
🐛 Bug Fixes
--prefix,--interleavefrommise runby @nkakouros in #8669📚 Documentation
v-predirective to Tera{{ }}expressions by @eitamal in #8659🧪 Testing
📦️ Dependency Updates
📦 Registry
New Contributors
📦 Aqua Registry Updates
New Packages (8)
acsandmann/riftalltuner/mise-completions-syncatlassian.com/acliberbicanes/apiarkgitlab.com/graphviz/graphvizjorgelbg/pinentry-touchidterraprovider/statebridgevercel-labs/agent-browserUpdated Packages (8)
UpCloudLtd/upcloud-cliaquaproj/registry-toolgo-swagger/go-swaggergopinath-langote/1buildjkfran/killportsassman/t-rec-rssharkdp/fdtemporalio/cli