Conversation
…otes On Windows, the path will contain backslashes. Both `busybox.exe bash` and Git Bash on Windows can understand backslash paths. But bash syntax requires wrapping in single-quotes to avoid interpreting backslashes as escapes.
Contributor
Author
|
Related: #6993 |
jdx
pushed a commit
that referenced
this pull request
Nov 18, 2025
### 📦 Registry - add tbls by @artemklevtsov in [#6987](#6987) ### 🐛 Bug Fixes - **(nushell)** add missing `| parse env | update-env` for deactivation operations by @jokeyrhyme in [#6994](#6994) - **(pwsh)** wrap the executable path with double quotes by @leosuncin in [#6993](#6993) - in `activate bash` output, wrap mise executable path in single-quotes by @cspotcode in [#7002](#7002) ### 📚 Documentation - simplify apt instructions by @scop in [#6986](#6986) - update idiomatic version files enablement info by @scop in [#6985](#6985) ### 🧪 Testing - **(aqua)** remove biome test due to version incompatibility by @jdx in [#7000](#7000) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#6997](#6997) ### New Contributors - @jokeyrhyme made their first contribution in [#6994](#6994) - @cspotcode made their first contribution in [#7002](#7002) - @artemklevtsov made their first contribution in [#6987](#6987) - @leosuncin made their first contribution in [#6993](#6993) ## 📦 Aqua Registry Updates #### New Packages (1) - [`houseabsolute/omegasort`](https://github.com/houseabsolute/omegasort) #### Updated Packages (5) - [`apache/maven`](https://github.com/apache/maven) - [`chaqchase/lla`](https://github.com/chaqchase/lla) - [`leoafarias/fvm`](https://github.com/leoafarias/fvm) - [`rustic-rs/rustic`](https://github.com/rustic-rs/rustic) - [`sigstore/rekor`](https://github.com/sigstore/rekor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the path to
mise.exewill contain backslashes.Both
busybox.exe bashand Git-for-Windows' "Git Bash" can understand these backslash paths.But bash syntax rules dictate that unquoted backslashes are interpreted as escapes. We must wrap the path in single-quotes to avoid this.
Quoting is technically more correct on Linux, too, even though the issues it avoids -- splitting on spaces -- are largely hypothetical.1
I can't think of any way that this code change would break someone's legitimate setup on Linux or Mac.
Footnotes
To be pedantic, if the path to
miseincludes a single-quote -- if the name of a parent directory has a single-quote in it -- then this will be broken on Linux, but it would already be broken before this code change, so we are not making it worse. ↩