feat(shim): prevent mise-specific flags from interfering with shim execution #5616

jdx · 2025-07-13T22:56:42Z

Summary

This PR implements a solution for the GitHub discussion about shim behavior. When mise runs as a shim (e.g., mise-node, mise-python), it should not process mise-specific flags and instead pass them through to the underlying tool.

Changes

Core Implementation

Shim Detection: Added is_direct_mise_invocation() function to detect when running as shim vs direct mise invocation
Flag Processing: Modified add_cli_matches() to skip mise-specific flags when running as shim
Environment Handling: Updated environment processing to ignore command line args when running as shim
Version Display: Simplified version detection logic using the new shim detection

Testing

E2E Test: Added comprehensive test (e2e/plugins/test_tiny) that verifies shim behavior with various mise-specific flags
Test Coverage: Ensures flags like --no-config, --env, --jobs, --raw, --yes are properly passed through

Documentation & Style

Markdown Linting: Fixed linting issues in CLI documentation files
Development Rules: Updated development guidelines for better workflow

Technical Details

The implementation:

Detects shim execution by checking if the binary name is not "mise" or doesn't start with "mise-"
When running as shim, only processes non-mise-specific flags (currently just --raw)
Prevents --no-config from being processed when running as shim
Uses environment variables only for environment selection when running as shim

This ensures that tools like mise-node --version work correctly without mise interfering with the underlying tool's argument parsing.

Copilot

Pull Request Overview

This PR was intended to implement a solution for a GitHub discussion but inadvertently introduces stray text that breaks compilation.

Removes the existing import and re-adds it with an unintended prefix.
Introduces invalid text before the use statement causing a linter/compile error.

Comments suppressed due to low confidence (1)

src/config/settings.rs:1

Remove the stray text THIS SHOULD BE A LINTER ERROR so the import reads use crate::cli::Cli;, restoring valid syntax.

THIS SHOULD BE A LINTER ERRORuse crate::cli::Cli;

github-actions · 2025-07-13T23:12:04Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.8 x -- echo`	17.7 ± 0.2	17.3	19.7	1.00
`mise x -- echo`	17.9 ± 0.3	17.4	19.7	1.02 ± 0.02

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.8 env`	17.3 ± 0.4	16.8	22.3	1.00
`mise env`	17.4 ± 0.3	16.9	18.8	1.01 ± 0.03

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.8 hook-env`	16.9 ± 0.3	16.4	20.2	1.00
`mise hook-env`	17.4 ± 0.4	16.7	20.4	1.03 ± 0.03

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.8 ls`	15.2 ± 0.4	14.7	17.0	1.00
`mise ls`	15.2 ± 0.8	14.7	27.4	1.01 ± 0.06

`xtasks/test/perf`

Command	mise-2025.7.8	mise	Variance
install (uncached)	765ms	⚠️ 1064ms	-28%
install (cached)	126ms	126ms	+0%
ls (uncached)	704ms	699ms	+0%
ls (cached)	79ms	79ms	+0%
bin-paths (uncached)	698ms	⚠️ 1068ms	-34%
bin-paths (cached)	64ms	64ms	+0%
task-ls (uncached)	3203ms	3429ms	-6%
task-ls (cached)	267ms	261ms	+2%

⚠️ Warning: install uncached performance variance is -28%
⚠️ Warning: bin-paths uncached performance variance is -34%

jdx · 2025-07-14T00:11:30Z

Implementation Details

The fix leverages the existing `MISE_BIN_NAME` environment variable that is set by the shim scripts. When a shim is executed, the binary name is set to the tool name (e.g., "node", "python") rather than "mise".

Code Changes

The `no_config()` function in `src/config/settings.rs` now includes this logic:

pub fn no_config() -> bool {
    *env::MISE_NO_CONFIG
        || {
            // Don't process --no-config when running as a shim
            // If MISE_BIN_NAME doesn't start with "mise", we're running as a shim
            // and --no-config is meant for the shimmed tool, not for mise
            let bin_name = *env::MISE_BIN_NAME;
            if !bin_name.starts_with("mise") {
                return false;
            }
            
            env::ARGS
                .read()
                .unwrap()
                .iter()
                .any(|arg| arg == "--no-config")
        }
}

Testing Verification

The fix has been verified with:

✅ `~/.local/share/mise/shims/node --no-config --version` - flag passed through to node
✅ `mise --no-config settings` - flag processed by mise when running directly
✅ `~/.local/share/mise/shims/shfmt --no-config --help` - flag passed through to shfmt

This ensures that tools that accept `--no-config` as a valid option will receive it correctly when run through shims.

…s shims This fixes the issue where --no-config was being processed by mise when running through shims instead of being passed through to the underlying tool. The no_config() function now checks if MISE_BIN_NAME starts with 'mise' and only processes the --no-config flag when running as mise directly. When running as a shim (e.g., node, python), the flag is ignored by mise and passed through to the underlying tool. This enables tools that accept --no-config as a valid option to work correctly when run through mise shims. Fixes #5594

… failures by ensuring that when running under test\nconditions (cfg(test)), the is_direct_mise_invocation() function always\nreturns true, so tests don't get the shim flag passthrough behavior.\n\nThis allows tests to continue working as expected while preserving the\nshim flag passthrough functionality for normal usage.

…ct flag processing logic into process_raw_flag() function\n- Add is_running_as_shim() helper for consistent shim detection\n- Improve documentation for new functions\n- Reduce code duplication in add_cli_matches and no_config\n- Remove unused SHIM_IGNORED_FLAGS constant\n\nThis makes the code more maintainable and easier to understand.

… is more idiomatic Rust and cleaner than using conditional compilation\nattributes for this simple case. The functionality remains the same.

…tion-for-github-discussion-bb77

@jdx

### 🚀 Features - **(shim)** prevent mise-specific flags from interfering with shim execution by [@jdx](https://github.com/jdx) in [#5616](#5616) - github asset auto-detection by [@jdx](https://github.com/jdx) in [#5622](#5622) ### 🐛 Bug Fixes - resolve GitHub alias tool name parsing and add platform-specific asset support by [@jdx](https://github.com/jdx) in [#5621](#5621)

@yjoer

Changes from background composer bc-d0e7ef69-7cef-4153-bbe1-f714d461b54b

a99742b

Copilot AI review requested due to automatic review settings July 13, 2025 22:56

Copilot AI reviewed Jul 13, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

Changes from background composer bc-d0e7ef69-7cef-4153-bbe1-f714d461b54b

abe0218

jdx changed the title ~~Implement solution for GitHub discussion~~ fix: pass --no-config flag through to underlying tools when running as shims Jul 14, 2025

jdx force-pushed the cursor/implement-solution-for-github-discussion-bb77 branch from 8f4d634 to dcba71c Compare July 14, 2025 00:22

jdx added 3 commits July 13, 2025 19:32

wip

b55671a

jdx linked an issue Jul 14, 2025 that may be closed by this pull request

Shims break when --no-config is passed #5601

Closed

refactor: use if cfg!(test) instead of #[cfg(test)] attribute\n\nThis…

21f890e

… is more idiomatic Rust and cleaner than using conditional compilation\nattributes for this simple case. The functionality remains the same.

jdx changed the title ~~fix: pass --no-config flag through to underlying tools when running as shims~~ feat(shim): prevent mise-specific flags from interfering with shim execution Jul 14, 2025

test(e2e): improve shim test to verify argument order

1a48e4b

jdx force-pushed the cursor/implement-solution-for-github-discussion-bb77 branch from cb28603 to 1a48e4b Compare July 14, 2025 00:50

wip

abd955f

This comment was marked as outdated.

Sign in to view

jdx added 2 commits July 13, 2025 20:00

wip

a366225

Merge remote-tracking branch 'origin/main' into cursor/implement-solu…

ac1d213

…tion-for-github-discussion-bb77

jdx force-pushed the cursor/implement-solution-for-github-discussion-bb77 branch from b1f01b4 to ac1d213 Compare July 14, 2025 01:01

jdx added 4 commits July 13, 2025 20:04

wip

06a805a

wip

c5ed8a2

wip

bf5e56d

wip

36b6e05

jdx force-pushed the cursor/implement-solution-for-github-discussion-bb77 branch from bb94601 to 36b6e05 Compare July 14, 2025 01:15

jdx merged commit c472a52 into main Jul 14, 2025
18 checks passed

jdx deleted the cursor/implement-solution-for-github-discussion-bb77 branch July 14, 2025 01:47

mise-en-dev mentioned this pull request Jul 14, 2025

chore: release 2025.7.9 #5618

Merged

BrewTestBot mentioned this pull request Jul 14, 2025

mise 2025.7.9 Homebrew/homebrew-core#229948

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(shim): prevent mise-specific flags from interfering with shim execution #5616

feat(shim): prevent mise-specific flags from interfering with shim execution #5616

Uh oh!

jdx commented Jul 13, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 13, 2025 •

edited

Loading

Uh oh!

jdx commented Jul 14, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(shim): prevent mise-specific flags from interfering with shim execution #5616

feat(shim): prevent mise-specific flags from interfering with shim execution #5616

Uh oh!

Conversation

jdx commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Core Implementation

Testing

Documentation & Style

Technical Details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

jdx commented Jul 14, 2025

Implementation Details

Code Changes

Testing Verification

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jdx commented Jul 13, 2025 •

edited

Loading

github-actions bot commented Jul 13, 2025 •

edited

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`