fix(erlang): use precompiled binaries for linux ubuntu #5402

paradox460 · 2025-06-23T00:13:16Z

This PR attempts to enable installation of precompiled erlang binaries on Ubuntu systems, supplementing the current fast installs for MacOS and Windows (#2721).

Details

Erlang builds are made available, precompiled, for a variety of Ubuntu systems via bob.

These are generally available at https://builds.hex.pm/builds/otp/${ARCH}/${OS_VER}/${REF}.tar.gz

ARCH and OS_VER are typically a bit different than the other constants Mise uses in the erlang.rs core plugin.

The REF appears to be the same as the ones used for the other functions in the file, so it does not need to be changed.

From bob's documentation, the two arches available for precompiled builds are:

amd64
arm64

Additionally, the OS version encodes what build of Ubuntu is used as well:

ubuntu-20.04
ubuntu-22.04
ubuntu-24.04

The architecture names are a fairly simple mapping, more or less just different names for concepts that already exist in the mise source code. However OS_VER is more complicated.

On Github Actions, this is exposed as the envar ImageOS. Determining the runtime from that would technically satisfy my ask, as this is primarily about CI.

In this PR, I check the value of the ImageOS var, and if its absent use the os_release crate, which is already loaded for use elsewhere, to fetch the version. Since, as mentioned earlier, bob only has builds for a few ubuntu versions, I check against those, and if either ImageOS or the os_release data don't match, return early so that we can still build manually

paradox460 · 2025-06-23T00:14:06Z

I'm not actually sure if this does anything or works. My experience with rust is minimal, and so I just tried to follow conventions I saw in the file at hand.

src/plugins/core/erlang.rs

roele · 2025-06-24T18:17:13Z

It's a good start and the first part seems to work fine as per my quick test. What is missing is the proper handling of the archive.

Mise expects the binaries in the <tool>/<version>/bin folder so they get properly exposed to the PATH. The extracted archive contains a folder structure as follows.

OTP-<version>
  Install
  erts-16.0.1/
  lib/
  misc/
  releases/
  usr/

An installation via kerl looks like the following.

Install
activate
activate.csh
activate.fish
bin/
erts-16.0.1/
lib/
misc/
releases/
usr/

So what needs to be done is, extracting the tar in the download_path and moving the files to the install_path. After that the Install script needs to be executed (i assume with -minimal?) to create the bin/ directory with the necessary files.

src/plugins/core/erlang.rs

roele

With the suggested changes and some additional imports use std::fs; and use crate::cmd::CmdLineRunner; the installation works on an Ubuntu.

roele · 2025-06-24T18:26:33Z

To pass the semantic-pr-lint job the PR title needs to follow semantic commits e.g. fix(erlang): use precompiled binaries for linux ubuntu

roele

There are some warnings for OS specific builds about dead code, will have a look at those later. Besides that looks okay to me now.

Use the os_release crate, which is already loaded in (and used in Swift) to determine what OS we're on. BOB only supports ubuntu 20.04, 22.04, and 24.04, so we return an Ok(None) if we're not on one of these versions. The Ubuntu check is relatively modular, so should Bob add more support later, or other mirrors pop up (fedora, etc), we can add those easily

src/plugins/core/erlang.rs

roele · 2025-06-25T07:09:18Z

Awesome! Ran this on a docker container quickly and this seems to work now.

Thank you for your contribution @paradox460

@roele

My previous PR (#5402) works well on a local Ubuntu runner, but when it comes to the actual github runners, it doesn't work, because Github defines the `ImageOS` as `ubuntu24`, not `ubuntu-24.04` There are two approaches to solving this issue: 1. Remap `ubuntu24` style strings to `ubuntu-24.04`. That is what I'm doing now 2. Ignore the `ImageOS` envar entirely, and just rely on data from `os_releases`

This PR attempts to enable installation of precompiled erlang binaries on Ubuntu systems, supplementing the current fast installs for MacOS and Windows (#2721). # Details Erlang builds are made available, precompiled, for a variety of Ubuntu systems via [bob](https://github.com/hexpm/bob). These are generally available at `https://builds.hex.pm/builds/otp/${ARCH}/${OS_VER}/${REF}.tar.gz` `ARCH` and `OS_VER` are typically a bit different than the other constants Mise uses in the erlang.rs core plugin. The `REF` appears to be the same as the ones used for the other functions in the file, so it does not need to be changed. From bob's documentation, the two arches available for precompiled builds are: - `amd64` - `arm64` Additionally, the OS version encodes what build of Ubuntu is used as well: - `ubuntu-20.04` - `ubuntu-22.04` - `ubuntu-24.04` The architecture names are a fairly simple mapping, more or less just different names for concepts that already exist in the mise source code. However OS_VER is more complicated. On Github Actions, this is exposed as the envar `ImageOS`. Determining the runtime from that would technically satisfy my ask, as this is primarily about CI. In this PR, I check the value of the `ImageOS` var, and if its absent use the `os_release` crate, which is already loaded for use elsewhere, to fetch the version. Since, as mentioned earlier, bob only has builds for a few ubuntu versions, I check against those, and if either ImageOS or the os_release data don't match, return early so that we can still build manually --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

@roele

My previous PR (jdx#5402) works well on a local Ubuntu runner, but when it comes to the actual github runners, it doesn't work, because Github defines the `ImageOS` as `ubuntu24`, not `ubuntu-24.04` There are two approaches to solving this issue: 1. Remap `ubuntu24` style strings to `ubuntu-24.04`. That is what I'm doing now 2. Ignore the `ImageOS` envar entirely, and just rely on data from `os_releases`

@yjoer

roele reviewed Jun 23, 2025

View reviewed changes

src/plugins/core/erlang.rs Outdated Show resolved Hide resolved

roele reviewed Jun 23, 2025

View reviewed changes

src/plugins/core/erlang.rs Outdated Show resolved Hide resolved

roele reviewed Jun 23, 2025

View reviewed changes

src/plugins/core/erlang.rs Outdated Show resolved Hide resolved

paradox460 requested a review from roele June 24, 2025 16:17

roele reviewed Jun 24, 2025

View reviewed changes

src/plugins/core/erlang.rs Show resolved Hide resolved

roele reviewed Jun 24, 2025

View reviewed changes

src/plugins/core/erlang.rs Show resolved Hide resolved

roele suggested changes Jun 24, 2025

View reviewed changes

paradox460 changed the title ~~Faster Erlang installs for Linux and Github Actions Ubuntu Runners~~ fix(erlang): use precompiled binaries for linux ubuntu Jun 24, 2025

roele approved these changes Jun 24, 2025

View reviewed changes

roele approved these changes Jun 25, 2025

View reviewed changes

paradox460 and others added 9 commits June 24, 2025 22:55

Preliminary erlang install for GHA

ca6b637

Use strings for arch match

82ac923

Remove semicolon on implicit return

af6278a

Formatting

cb74b42

[autofix.ci] apply automated fixes

80a3867

Run install script that comes with BOB precompiles

592836d

[autofix.ci] apply automated fixes

3702472

Only use linux specific use conditionally

efc46c6

paradox460 force-pushed the main branch from ca64370 to efc46c6 Compare June 25, 2025 04:55

roele reviewed Jun 25, 2025

View reviewed changes

src/plugins/core/erlang.rs Outdated Show resolved Hide resolved

Fix path

25be620

jdx merged commit 3d518e7 into jdx:main Jun 25, 2025
17 checks passed

mise-en-dev mentioned this pull request Jun 25, 2025

chore: release 2025.6.8 #5415

Merged

BrewTestBot mentioned this pull request Jun 26, 2025

mise 2025.6.8 Homebrew/homebrew-core#228283

Merged

paradox460 mentioned this pull request Jun 26, 2025

fix(erlang): use precompiled ubuntu binaries on GHA #5439

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(erlang): use precompiled binaries for linux ubuntu #5402

fix(erlang): use precompiled binaries for linux ubuntu #5402

Uh oh!

paradox460 commented Jun 23, 2025 •

edited

Loading

Uh oh!

paradox460 commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roele commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

roele left a comment •

edited

Loading

Uh oh!

roele commented Jun 24, 2025

Uh oh!

roele left a comment

Uh oh!

Uh oh!

roele commented Jun 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(erlang): use precompiled binaries for linux ubuntu #5402

fix(erlang): use precompiled binaries for linux ubuntu #5402

Uh oh!

Conversation

paradox460 commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Uh oh!

paradox460 commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roele commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

roele left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roele commented Jun 24, 2025

Uh oh!

roele left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roele commented Jun 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paradox460 commented Jun 23, 2025 •

edited

Loading

roele left a comment •

edited

Loading