fix(node): compare resolved mirror_url to honor NODE_BUILD_MIRROR_URL

jdx · claude · jdx · commit dd687075ea88 · 2026-04-26T13:58:44.000-05:00
The previous check `node.mirror_url.is_none()` ignored the
`NODE_BUILD_MIRROR_URL` env var that `mirror_url()` itself reads as a
fallback, so a user with that env var set would still get rerouted to
unofficial-builds for musl filenames. Compare against the resolved Url
instead so any user-provided override (settings field or env var) is
preserved.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/plugins/core/node.rs b/src/plugins/core/node.rs
@@ -857,10 +857,11 @@ impl BuildOpts {
 const UNOFFICIAL_NODE_MIRROR_URL: &str = "https://unofficial-builds.nodejs.org/download/release/";
 
 fn mirror_url_for(node: &crate::config::settings::SettingsNode, filename: &str) -> Url {
-    if node.mirror_url.is_none() && filename.contains("-musl") {
+    let mirror = node.mirror_url();
+    if filename.contains("-musl") && mirror.as_str() == DEFAULT_NODE_MIRROR_URL {
         return Url::parse(UNOFFICIAL_NODE_MIRROR_URL).unwrap();
     }
-    node.mirror_url()
+    mirror
 }
 
 fn os() -> &'static str {

Original file line number	Diff line number	Diff line change
`@@ -857,10 +857,11 @@ impl BuildOpts {`
`857`	`857`	`const UNOFFICIAL_NODE_MIRROR_URL: &str = "https://unofficial-builds.nodejs.org/download/release/";`
`858`	`858`
`859`	`859`	`fn mirror_url_for(node: &crate::config::settings::SettingsNode, filename: &str) -> Url {`
`860`		`- if node.mirror_url.is_none() && filename.contains("-musl") {`
	`860`	`+ let mirror = node.mirror_url();`
	`861`	`+ if filename.contains("-musl") && mirror.as_str() == DEFAULT_NODE_MIRROR_URL {`
`861`	`862`	`return Url::parse(UNOFFICIAL_NODE_MIRROR_URL).unwrap();`
`862`	`863`	`}`
`863`		`- node.mirror_url()`
	`864`	`+ mirror`
`864`	`865`	`}`
`865`	`866`
`866`	`867`	`fn os() -> &'static str {`