fix(prune): over-protect for sub-N:latest in offline mode

jdx · claude · jdx · commit 5316331543dc · 2026-04-26T12:54:41.000-05:00
Per cursor review: applying version_sub to latest_installed_version
shifts the result one step too low, missing the actually-installed
sub-N target. resolve_sub now returns the raw `sub-N:latest` spec
in offline mode, and get_versions_needed_by_tracked_configs
detects this case and protects every installed version of the
backend. Over-protecting (some old versions stay) is the safe
failure mode vs. deleting the active version.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/toolset/mod.rs b/src/toolset/mod.rs
@@ -643,6 +643,20 @@ pub async fn get_versions_needed_by_tracked_configs(
         ts.resolve_with_opts(config, &opts).await?;
         for (_, tv) in ts.list_current_versions() {
             needed.insert((tv.ba().short.to_string(), tv.tv_pathname()));
+            // Offline can't resolve `sub-N:latest` to a concrete version
+            // (no remote latest available). Conservatively protect every
+            // installed version of this backend so we don't delete the
+            // active one.
+            if offline
+                && let crate::toolset::ToolRequest::Sub { orig_version, .. } = &tv.request
+                && orig_version == "latest"
+                && let Ok(backend) = tv.backend()
+            {
+                let short = tv.ba().short.to_string();
+                for v in backend.list_installed_versions() {
+                    needed.insert((short.clone(), v));
+                }
+            }
         }
     }
     Ok(needed)
diff --git a/src/toolset/tool_version.rs b/src/toolset/tool_version.rs
@@ -458,17 +458,11 @@ impl ToolVersion {
     ) -> Result<Self> {
         let backend = request.backend()?;
         if v == "latest" && opts.offline {
-            // Use the latest installed version as the basis for the sub
-            // computation so the resolved concrete version still matches an
-            // installed pathname (and gets protected from prune). Falling
-            // straight to the raw "sub-N:latest" string would never match
-            // anything in `to_delete`.
-            if !opts.latest_versions
-                && let Some(latest) = backend.latest_installed_version(None)?
-            {
-                let v = tool_request::version_sub(&latest, sub);
-                return Box::pin(Self::resolve_version(config, request, &v, opts)).await;
-            }
+            // Can't resolve sub-N:latest offline (no remote latest, and
+            // applying version_sub to latest_installed_version would shift
+            // one step too low). Return the raw spec; callers that care
+            // (`get_versions_needed_by_tracked_configs`) over-protect by
+            // keeping all installed versions of this backend.
             let version = request.version();
             return Ok(Self::new(request, version));
         }
