ci: remove rust-cache from release jobs by jdx · Pull Request #893 · jdx/hk

jdx · 2026-04-30T16:55:09Z

Summary

Drops namespacelabs/nscloud-cache-action (Linux/macOS) and Swatinem/rust-cache (Windows) from the build-binaries job in .github/workflows/release.yml
Drops nscloud-cache-action from the publish-crate job

Why

Release builds run once per tag against a clean checkout — incremental Rust caching doesn't save meaningful time and just adds restore/save overhead and storage.

Test plan

CI on the branch passes
Next tagged release builds all binary targets and publishes the crate without the cache steps

Note

Low Risk
Low risk CI-only change that removes Rust caching from release jobs; main impact is potentially longer build times, not runtime behavior.

Overview
Release workflow no longer restores/saves Rust build caches during build-binaries (dropping both nscloud-cache-action and Swatinem/rust-cache) and removes nscloud-cache-action from publish-crate.

This simplifies release CI by always building from a clean checkout without cache-related overhead.

^{Reviewed by Cursor Bugbot for commit a3e1b3f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Release builds run once per tag and don't benefit from incremental caching, so the cache restore/save overhead and storage usage isn't worth it. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

gemini-code-assist · 2026-04-30T16:55:16Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

greptile-apps · 2026-04-30T16:56:08Z

Greptile Summary

Removes Rust build caching (namespacelabs/nscloud-cache-action and Swatinem/rust-cache) from the build-binaries and publish-crate jobs in the release workflow. Since release builds are triggered once per tag on clean runners, the cache restore/save overhead outweighs any benefit, making this a sensible cleanup.

Confidence Score: 5/5

Safe to merge — purely removes cache steps from release jobs with no functional impact.

The change is a clean deletion of optional cache actions. All build steps, artifact uploads, and publish logic remain intact. No logic changes, no new dependencies introduced, and the stated rationale (one-shot tag builds don't benefit from Rust caching) is sound.

No files require special attention.

Important Files Changed

Filename	Overview
.github/workflows/release.yml	Removes nscloud-cache-action (Linux/macOS) and rust-cache (Windows) from build-binaries and publish-crate jobs; straightforward cleanup with no functional regressions

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Tag Push / workflow_dispatch] --> B[build-binaries\n matrix: 7 targets]
    A --> C[build-pkl]
    B -->|artifact: binary-*| D[create-release]
    C -->|artifact: pkl-packages| D
    D --> E[publish-crate\ncargo publish - no cache]
    D --> F[enhance-release]

    style B fill:#d4edda,stroke:#28a745
    style E fill:#d4edda,stroke:#28a745

_{Reviews (1): Last reviewed commit: "ci: remove rust-cache from release jobs" | Re-trigger Greptile}

@plx

### 🚀 Features - **(builtins)** add `buildifier` format and lint built-ins by [@plx](https://github.com/plx) in [#896](#896) ### 🐛 Bug Fixes - **(step)** only auto-batch when rendered command exceeds ARG_MAX by [@jdx](https://github.com/jdx) in [#901](#901) ### 📚 Documentation - thank Namespace for GitHub Actions runner support by [@jdx](https://github.com/jdx) in [#895](#895) ### 🔍 Other Changes - **(ci)** use !cancelled() instead of always() for final job by [@jdx](https://github.com/jdx) in [#906](#906) - **(docs)** remove shrill.en.dev analytics script by [@jdx](https://github.com/jdx) in [#903](#903) - remove rust-cache from release jobs by [@jdx](https://github.com/jdx) in [#893](#893) - invert CLAUDE.md/AGENTS.md so AGENTS.md is canonical by [@jdx](https://github.com/jdx) in [#905](#905) - set dev profile debug to 1 by [@jdx](https://github.com/jdx) in [#907](#907) ### 📦️ Dependency Updates - update anthropics/claude-code-action digest to fefa07e by [@renovate[bot]](https://github.com/renovate[bot]) in [#897](#897) - update jdx/mise-action digest to 1648a78 by [@renovate[bot]](https://github.com/renovate[bot]) in [#898](#898) - update apple-actions/import-codesign-certs action to v7 by [@renovate[bot]](https://github.com/renovate[bot]) in [#900](#900) - update autofix-ci/action action to v1.3.4 by [@renovate[bot]](https://github.com/renovate[bot]) in [#899](#899) - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#908](#908) ### New Contributors - @plx made their first contribution in [#896](#896)  --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: primarily version string updates across manifests and docs with no functional code changes in this diff. > > **Overview** > Updates the project for the `v1.45.0` release by bumping the crate/CLI version (`Cargo.toml`, `Cargo.lock`, `hk.usage.kdl`, generated CLI docs) and adding the `1.45.0` entry to `CHANGELOG.md`. > > Refreshes documentation and example configs to reference the new versioned Pkl package URLs (`docs/*.md`, `docs/public/*.pkl`, `hk-example.pkl`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit cfe2da5. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>  Co-authored-by: mise-en-dev <[email protected]>

ci: remove rust-cache from release jobs

a3e1b3f

Release builds run once per tag and don't benefit from incremental caching, so the cache restore/save overhead and storage usage isn't worth it. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

jdx enabled auto-merge (squash) April 30, 2026 16:56

jdx merged commit 0dbdb24 into main Apr 30, 2026
22 checks passed

jdx deleted the claude/trusting-lichterman-4f349d branch April 30, 2026 17:03

jdx mentioned this pull request Apr 30, 2026

chore: release v1.45.0 #894

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: remove rust-cache from release jobs#893

ci: remove rust-cache from release jobs#893
jdx merged 1 commit intomainfrom
claude/trusting-lichterman-4f349d

jdx commented Apr 30, 2026 •

edited by cursor Bot

Loading

Uh oh!

gemini-code-assist Bot commented Apr 30, 2026

Uh oh!

greptile-apps Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jdx commented Apr 30, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Uh oh!

gemini-code-assist Bot commented Apr 30, 2026

Uh oh!

greptile-apps Bot commented Apr 30, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented Apr 30, 2026 •

edited by cursor Bot

Loading