fix: use site domain for plausible data-domain#886
Merged
Conversation
Follow-up to #885 — the data-domain attribute must be the site domain (matches what Plausible has configured), not a Cloudflare Pages token. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Greptile SummaryChanges Confidence Score: 5/5Safe to merge — minimal, targeted fix with no logic or security implications. Single-line config change correcting an analytics attribute value. No logic, no security surface, no side effects beyond enabling correct Plausible event tracking. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser
participant Plausible
Browser->>Plausible: pageview event {domain: "hk.jdx.dev"}
Plausible-->>Browser: 202 Accepted
Note over Plausible: Event recorded under hk.jdx.dev dashboard
Reviews (1): Last reviewed commit: "fix: use site domain for plausible data-..." | Re-trigger Greptile |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Merged
jdx
added a commit
that referenced
this pull request
Apr 30, 2026
### 🐛 Bug Fixes - **(hook)** do not stage fixes when fail_on_fix=true by [@jdx](https://github.com/jdx) in [#892](#892) - use site domain for plausible data-domain by [@jdx](https://github.com/jdx) in [#886](#886) - make text-mode progress output usable in CI by [@jdx](https://github.com/jdx) in [#890](#890) ### 📚 Documentation - prefix GitHub star count with ★ glyph by [@jdx](https://github.com/jdx) in [#883](#883) ### 🔍 Other Changes - **(release)** dedupe sponsor section in release notes by [@jdx](https://github.com/jdx) in [#881](#881) - switch analytics from gtm/goatcounter to plausible by [@jdx](https://github.com/jdx) in [#885](#885) - migrate to namespace.so runners by [@jdx](https://github.com/jdx) in [#891](#891) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: version bumps, regenerated docs, and lockfile dependency updates with no functional code changes in this PR. > > **Overview** > Bumps `hk` to **v1.44.3** and adds the corresponding `CHANGELOG.md` release entry. > > Regenerates versioned docs/CLI artifacts to reference `1.44.3` (package URLs and generated `commands.json`/`index.md`) and updates `Cargo.lock` with dependency resolution changes (notably `jni`, `rustls*`, `reqwest`, `wasm-bindgen`, and `thiserror` unification). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ab7b72e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: mise-en-dev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #885. The Plausible
data-domainattribute was set to a Cloudflare Pages identifier (pa-9rbZ...) instead of the actual site domain. Plausible matches events by thedata-domainvalue, so analytics arent being recorded.Sets it to
hk.jdx.devto match how the merged mise PR (#9430) does it.🤖 Generated with Claude Code
Note
Low Risk
Low risk: a one-line docs-site config tweak that only affects analytics attribution and should not impact runtime behavior beyond tracking.
Overview
Updates the VitePress docs analytics script configuration to use the actual site domain (
hk.jdx.dev) for the Plausibledata-domainattribute instead of the Cloudflare Pages identifier, so pageview events are attributed correctly.Reviewed by Cursor Bugbot for commit 9e76643. Bugbot is set up for automated code reviews on this repo. Configure here.