Conversation
The banner.json endpoint now includes an optional ISO-8601 `expires` timestamp so announcements can auto-hide without a code change. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Greptile SummaryThis PR adds support for an optional Confidence Score: 5/5Safe to merge — change is minimal, correct, and purely additive. The No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[fetch banner.json] --> B{r.ok?}
B -- No --> Z[no-op]
B -- Yes --> C{b.enabled?}
C -- No --> Z
C -- Yes --> D{isExpired b.expires}
D -- Yes --> Z
D -- No --> E{dismissed in localStorage?}
E -- Yes --> Z
E -- No --> F[render banner]
subgraph isExpired
G{expires defined?} -- No --> H[return false]
G -- Yes --> I[Date.parse expires]
I --> J{NaN?}
J -- Yes --> H
J -- No --> K{Date.now >= t?}
K -- Yes --> L[return true]
K -- No --> H
end
Reviews (1): Last reviewed commit: "docs: respect banner expires field" | Re-trigger Greptile |
Merged
jdx
added a commit
that referenced
this pull request
Apr 24, 2026
### 🐛 Bug Fixes - **(git)** skip untracked scan when HK_STASH_UNTRACKED=false by [@jdx](https://github.com/jdx) in [#861](#861) - **(run)** add post-commit and pre-rebase subcommands by [@jdx](https://github.com/jdx) in [#858](#858) ### 📚 Documentation - **(install)** recommend global hooks as primary setup path by [@jdx](https://github.com/jdx) in [#855](#855) - add cross-site announcement banner by [@jdx](https://github.com/jdx) in [#857](#857) - respect banner expires field by [@jdx](https://github.com/jdx) in [#862](#862) ### 🔍 Other Changes - vendor bats test helpers instead of git submodules by [@jdx](https://github.com/jdx) in [#859](#859) ### 📦️ Dependency Updates - bump communique to 1.0.3 by [@jdx](https://github.com/jdx) in [#863](#863) - update anthropics/claude-code-action digest to e58dfa5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#864](#864) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping only: version numbers, generated CLI/docs, and lockfile dependency bumps with no runtime logic changes. > > **Overview** > **Release prep for `v1.44.1`.** Updates `Cargo.toml`/`Cargo.lock` (including `libc`) and all version references in generated CLI docs (`docs/cli/*`, `hk.usage.kdl`). > > Refreshes documentation examples to reference the new `v1.44.1` Pkl package URLs and adds the `1.44.1` entry to `CHANGELOG.md`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d7637d4. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: mise-en-dev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expires(ISO-8601) field in jdx.dev/banner.jsonDate.now() >= Date.parse(expires)expiresis absent (preserves existing behavior)Test plan
expiresin the past → banner hiddenexpiresin the future → banner shownexpiresfield → banner shown as before🤖 Generated with Claude Code
Note
Low Risk
Low risk: small, isolated change to docs banner rendering that only adds a time-based guard and falls back to existing behavior when
expiresis missing/invalid.Overview
The docs site banner now supports an optional
expiresfield frombanner.jsonand will skip rendering when the timestamp has passed.Adds a small
isExpiredhelper (treats missing or invalid dates as not expired) and wires it intoinitBannerbefore the local dismissal check.Reviewed by Cursor Bugbot for commit 326346c. Bugbot is set up for automated code reviews on this repo. Configure here.