Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Greptile SummaryAdds Confidence Score: 5/5Safe to merge — workflow-only change with no logic impact on existing targets. No P0 or P1 findings. The two new musl matrix entries mirror the existing GNU Linux entries exactly (same No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[release.yml triggered] --> B[build-binaries matrix]
B --> C[aarch64-apple-darwin\ncargo]
B --> D[x86_64-unknown-linux-musl\ncross NEW]
B --> E[aarch64-unknown-linux-musl\ncross NEW]
B --> F[x86_64-unknown-linux-gnu\ncross]
B --> G[aarch64-unknown-linux-gnu\ncross]
B --> H[x86_64-pc-windows-msvc\ncargo]
B --> I[aarch64-pc-windows-msvc\ncargo]
C & D & E & F & G & H & I --> J[Upload binary artifact]
K[build-pkl] --> L[Upload pkl artifact]
J & L --> M[create-release]
M --> N[enhance-release]
Reviews (1): Last reviewed commit: "Merge branch 'main' into fix/release-mus..." | Re-trigger Greptile |
### 🚀 Features - **(harper)** add harper-cli config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#714](#714) ### 🐛 Bug Fixes - **(release)** add linux musl targets by [@jdx](https://github.com/jdx) in [#829](#829) ### 🔍 Other Changes - drop sub-crate submodules and publish hk to crates.io by [@jdx](https://github.com/jdx) in [#830](#830) ### 📦️ Dependency Updates - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#826](#826) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Primarily a version/release bookkeeping change (docs, generated CLI metadata, and lockfiles) with no runtime logic modifications in this diff. > > **Overview** > Cuts release `v1.43.0` by bumping the crate version in `Cargo.toml`/`Cargo.lock` and updating `CHANGELOG.md` with the 1.43.0 notes. > > Regenerates versioned references across docs and CLI artifacts (e.g., `docs/*`, `docs/cli/*`, example `.pkl` files, and `hk.usage.kdl`) to point at `v1.43.0` Pkl package URLs. Updates `mise.lock` to include provenance metadata for the `communique` linux x64 artifact. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit f4e6c35. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: mise-en-dev <[email protected]>
1 participant
Summary
x86_64-unknown-linux-muslto the release workflowaarch64-unknown-linux-muslto the release workflowValidation
cross build --target x86_64-unknown-linux-musl --features git2/vendored-libgit2,git2/vendored-opensslactionlint .github/workflows/release.ymlCloses #828
Note
Low Risk
Workflow-only change that expands the CI build matrix; main risk is longer builds or target-specific build failures.
Overview
The release workflow now builds additional Linux musl binaries by adding
x86_64-unknown-linux-muslandaarch64-unknown-linux-muslto thebuild-binariesmatrix (usingcross).This expands the set of published artifacts to include Alpine-friendly builds alongside the existing GNU Linux, macOS, and Windows targets.
Reviewed by Cursor Bugbot for commit a3acff0. Bugbot is set up for automated code reviews on this repo. Configure here.