feat(builtins): add dclint to builtins by timothysparg · Pull Request #779 · jdx/hk

timothysparg · 2026-03-29T10:36:48Z

Add docker compose linter to the builtins registry

gemini-code-assist

Code Review

This pull request introduces a Docker Compose linter (dclint) configuration and its corresponding tool stub. The configuration includes glob patterns for identifying compose files and basic test cases. Feedback suggests simplifying the glob patterns using brace expansion and ensuring consistency between the 'bad' and 'good' test examples by including the version field in both.

gemini-code-assist · 2026-03-29T10:38:21Z

+      "**/compose*.yml",
+      "**/compose*.yaml",
+      "**/docker-compose*.yml",
+      "**/docker-compose*.yaml",
+    )


The glob patterns are quite repetitive. They can be simplified to improve readability and maintainability by combining similar extensions and prefixes.

List( "**/compose*.{yml,yaml}", "**/docker-compose*.{yml,yaml}" )

gemini-code-assist · 2026-03-29T10:38:21Z

+      filename = "docker-compose.yml"
+    }
+    local const bad = "version: '3'\nservices:\n  web:\n    image: nginx\n"
+    local const good = "services:\n  web:\n    image: nginx:latest\n"


The good example for the test case omits the version field, which is present in the bad example. For better clarity and consistency, especially if dclint has rules around the version field, it's recommended to include it in the good example to represent a fully valid and fixed version of the bad input.

local const good = "version: '3'\nservices:\n web:\n image: nginx:latest\n"

greptile-apps · 2026-03-29T10:39:42Z

Greptile Summary

This PR adds dclint (docker-compose linter) as a new builtin to the hk registry. It follows the established pattern for infrastructure builtins like hadolint, covering both check and fix workflows with comprehensive test coverage.

Both concerns raised in the previous review round have been addressed:

check_list_files is no longer present (correctly removed since dclint {{files}} outputs error messages rather than plain file paths).
Fix tests (fixPass) are now included, testing the auto-fix path for the deprecated version: key as well as a no-op fix on an already-clean file.

Key implementation details:

Glob patterns cover all common Docker Compose file naming conventions (compose*, docker-compose*, .yml/.yaml).
batch = true is set, consistent with other multi-file linters like prettier.
The tool stub pins dclint at 3.1.0 via npm:dclint, following the same stub format used by other npm-backed builtins.
Four tests exercise checkFail, checkPass, fixPass (bad → fixed), and fixPass (good → unchanged).

Confidence Score: 5/5

This PR is safe to merge — it is a self-contained new builtin with no risk of breaking existing functionality.

Both previous P1/P2 concerns (incorrect check_list_files usage and missing fix tests) have been fully addressed in this revision. The implementation follows the established builtin pattern correctly, the glob patterns are comprehensive, and all four test cases are structurally valid. No new issues were found.

No files require special attention.

Important Files Changed

Filename	Overview
pkl/builtins/dclint.pkl	New builtin for docker-compose linter with check/fix commands, comprehensive glob patterns, and four tests covering check pass/fail and fix pass/no-op scenarios.
test/builtin_tool_stubs/dclint	Tool stub pinning dclint at version 3.1.0 via npm, following the same mise tool-stub format used by other builtins.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Staged file matches glob
 compose*.yml / docker-compose*.yml] --> B{run type}
    B -->|check| C["dclint {{files}}"]
    B -->|fix| D{check_first?}
    D -->|yes, check passes| E[skip fix]
    D -->|check fails| F["dclint --fix {{files}}"]
    C -->|exit 0| G[✅ Pass]
    C -->|exit ≠ 0| H[❌ Fail]
    F -->|exit 0| I[✅ File auto-fixed]
    F -->|exit ≠ 0| J[❌ Fix failed]

_{Reviews (3): Last reviewed commit: "feat(builtins): add dclint builtin for D..." | Re-trigger Greptile}

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

@hituzi-no-sippo

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.39.0` → `1.40.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.40.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1400---2026-04-01) [Compare Source](jdx/hk@v1.39.0...v1.40.0) ##### 🚀 Features - **(betterleaks)** add betterleaks config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#750](jdx/hk#750) - **(builtins)** add google-java-format to builtins by [@timothysparg](https://github.com/timothysparg) in [#777](jdx/hk#777) - **(builtins)** add dclint to builtins by [@timothysparg](https://github.com/timothysparg) in [#779](jdx/hk#779) - **(config)** set default value for exclude to List() by [@timothysparg](https://github.com/timothysparg) in [#781](jdx/hk#781) - **(core)** add required field to prevent unconfigured steps from running by [@timothysparg](https://github.com/timothysparg) in [#785](jdx/hk#785) - **(gitleaks)** add gitleaks config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#749](jdx/hk#749) - **(mdschema)** add mdschema config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#748](jdx/hk#748) - **(pkl)** add pklr as opt-in pkl backend by [@jdx](https://github.com/jdx) in [#769](jdx/hk#769) - add pklr as opt-in pkl backend by [@jdx](https://github.com/jdx) in [#768](jdx/hk#768) ##### 🐛 Bug Fixes - **(docs)** replace invalid /latest/ pkl package URIs with versioned format by [@jdx](https://github.com/jdx) in [#770](jdx/hk#770) - **(stage)** do not stage pre-existing untracked files by [@jdx](https://github.com/jdx) in [#788](jdx/hk#788) ##### 📚 Documentation - add benchmarks page and reproducible benchmark suite by [@jdx](https://github.com/jdx) in [#766](jdx/hk#766) - add recommended setup section to mise integration by [@timothysparg](https://github.com/timothysparg) in [#780](jdx/hk#780) ##### 📦️ Dependency Updates - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#762](jdx/hk#762) - update rust crate pklr to 0.4 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#776](jdx/hk#776) - update apple-actions/import-codesign-certs digest to [`fe74d46`](jdx/hk@fe74d46) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#774](jdx/hk#774) - update anthropics/claude-code-action digest to [`094bd24`](jdx/hk@094bd24) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#773](jdx/hk#773) - update taiki-e/upload-rust-binary-action digest to [`0e34102`](jdx/hk@0e34102) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#775](jdx/hk#775) - bump usage to 3.2.0 and pkl to 0.31.1, add windows platforms by [@jdx](https://github.com/jdx) in [#787](jdx/hk#787) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#786](jdx/hk#786) ##### New Contributors - [@timothysparg](https://github.com/timothysparg) made their first contribution in [#781](jdx/hk#781) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

gemini-code-assist Bot reviewed Mar 29, 2026

View reviewed changes

greptile-apps Bot reviewed Mar 29, 2026

View reviewed changes

Comment thread pkl/builtins/dclint.pkl

Comment thread pkl/builtins/dclint.pkl

timothysparg force-pushed the feat/builtins/dclint branch from ebf4766 to bc865f6 Compare March 29, 2026 23:06

feat(builtins): add dclint builtin for Docker Compose linting

7c964d8

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

timothysparg force-pushed the feat/builtins/dclint branch from bc865f6 to 7c964d8 Compare March 31, 2026 20:24

jdx merged commit a80a481 into jdx:main Apr 1, 2026
18 checks passed

jdx mentioned this pull request Apr 1, 2026

chore: release v1.40.0 #763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(builtins): add dclint to builtins#779

feat(builtins): add dclint to builtins#779
jdx merged 1 commit intojdx:mainfrom
timothysparg:feat/builtins/dclint

timothysparg commented Mar 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 29, 2026

Uh oh!

gemini-code-assist Bot Mar 29, 2026

Uh oh!

greptile-apps Bot commented Mar 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

timothysparg commented Mar 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Mar 29, 2026 •

edited

Loading