feat(builtins): add google-java-format to builtins by timothysparg · Pull Request #777 · jdx/hk

timothysparg · 2026-03-28T22:45:41Z

Add google-java-formatter as a builtin linter to hk

gemini-code-assist

Code Review

This pull request introduces a new configuration for the Google Java Format tool, including metadata, check/fix commands, and associated tests. Feedback suggests removing the redundant glob property as the types property already handles file identification.

gemini-code-assist · 2026-03-28T22:47:10Z

+  }
+}
+google_java_format = new Config.Step {
+  glob = "**/*.java"


The glob property is redundant here because types = List("java") already correctly identifies all Java files by their extension. To keep the configuration concise and rely on the more semantic types property, you can remove the glob definition.

greptile-apps · 2026-03-28T23:35:13Z

Greptile Summary

This PR adds google-java-format as a new builtin linter/formatter for Java files in hk. The implementation follows established conventions and is functionally correct.

File filtering: Uses glob = \"**/*.java\" exclusively — the previous concern about a redundant types field has been resolved.
Command set: All three commands are correctly wired:
- check: --dry-run --set-exit-if-changed exits non-zero when files would change.
- check_list_files: --dry-run (without --set-exit-if-changed) exits 0 and prints filenames needing reformatting to stdout — the correct contract for this field.
- fix: --replace formats files in-place.
Tests: Four test cases cover check-fail, check-pass, fix-bad, and fix-good paths using the helpers.TestMaker pattern consistent with ktlint.pkl, rubocop.pkl, and others.
Tool stub: test/builtin_tool_stubs/google-java-format pins version 1.25.2 via mise's GitHub backend, matching the pattern of all other stubs in the directory.

Confidence Score: 5/5

PR is safe to merge — implementation is correct, complete, and consistent with existing builtins.

Both concerns raised in prior review threads (redundant glob+types and missing check_list_files) have been addressed. No P0 or P1 issues remain; commands, tests, and the tool stub all follow established patterns correctly.

No files require special attention.

Important Files Changed

Filename	Overview
pkl/builtins/google_java_format.pkl	New builtin step for google-java-format with check, check_list_files, and fix commands; uses glob-only file filtering; includes comprehensive test coverage for check/fix pass and fail scenarios.
test/builtin_tool_stubs/google-java-format	Test stub for google-java-format v1.25.2 using mise's GitHub backend; follows the established pattern of all other stubs in the directory.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Staged *.java files] --> B{glob match\n**/*.java}
    B -->|no match| Z[skip step]
    B -->|matched files| C[run check\ngoogle-java-format\n--dry-run --set-exit-if-changed]
    C -->|exit 0 all good| D[pass]
    C -->|exit 1 needs fix| E[run check_list_files\ngoogle-java-format\n--dry-run]
    E -->|stdout: list of\nfiles needing format| F[run fix only\non those files\ngoogle-java-format\n--replace]
    F --> G[re-stage fixed files]

_{Reviews (3): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}

… add check_list_files

@hituzi-no-sippo

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.39.0` → `1.40.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.40.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1400---2026-04-01) [Compare Source](jdx/hk@v1.39.0...v1.40.0) ##### 🚀 Features - **(betterleaks)** add betterleaks config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#750](jdx/hk#750) - **(builtins)** add google-java-format to builtins by [@timothysparg](https://github.com/timothysparg) in [#777](jdx/hk#777) - **(builtins)** add dclint to builtins by [@timothysparg](https://github.com/timothysparg) in [#779](jdx/hk#779) - **(config)** set default value for exclude to List() by [@timothysparg](https://github.com/timothysparg) in [#781](jdx/hk#781) - **(core)** add required field to prevent unconfigured steps from running by [@timothysparg](https://github.com/timothysparg) in [#785](jdx/hk#785) - **(gitleaks)** add gitleaks config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#749](jdx/hk#749) - **(mdschema)** add mdschema config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#748](jdx/hk#748) - **(pkl)** add pklr as opt-in pkl backend by [@jdx](https://github.com/jdx) in [#769](jdx/hk#769) - add pklr as opt-in pkl backend by [@jdx](https://github.com/jdx) in [#768](jdx/hk#768) ##### 🐛 Bug Fixes - **(docs)** replace invalid /latest/ pkl package URIs with versioned format by [@jdx](https://github.com/jdx) in [#770](jdx/hk#770) - **(stage)** do not stage pre-existing untracked files by [@jdx](https://github.com/jdx) in [#788](jdx/hk#788) ##### 📚 Documentation - add benchmarks page and reproducible benchmark suite by [@jdx](https://github.com/jdx) in [#766](jdx/hk#766) - add recommended setup section to mise integration by [@timothysparg](https://github.com/timothysparg) in [#780](jdx/hk#780) ##### 📦️ Dependency Updates - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#762](jdx/hk#762) - update rust crate pklr to 0.4 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#776](jdx/hk#776) - update apple-actions/import-codesign-certs digest to [`fe74d46`](jdx/hk@fe74d46) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#774](jdx/hk#774) - update anthropics/claude-code-action digest to [`094bd24`](jdx/hk@094bd24) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#773](jdx/hk#773) - update taiki-e/upload-rust-binary-action digest to [`0e34102`](jdx/hk@0e34102) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#775](jdx/hk#775) - bump usage to 3.2.0 and pkl to 0.31.1, add windows platforms by [@jdx](https://github.com/jdx) in [#787](jdx/hk#787) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#786](jdx/hk#786) ##### New Contributors - [@timothysparg](https://github.com/timothysparg) made their first contribution in [#781](jdx/hk#781) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

feat(builtins): add google-java-format

4d4bf04

gemini-code-assist Bot reviewed Mar 28, 2026

View reviewed changes

autofix-ci Bot and others added 2 commits March 28, 2026 22:50

[autofix.ci] apply automated fixes

dcc8f0d

test: add google-java-format stub

a9e3501

greptile-apps Bot reviewed Mar 28, 2026

View reviewed changes

Comment thread pkl/builtins/google_java_format.pkl Outdated

Comment thread pkl/builtins/google_java_format.pkl

refactor(builtins): use glob instead of types for google-java-format,…

a3e6426

… add check_list_files

timothysparg force-pushed the feat/builtins/google-java-format branch from 6f24e0d to a3e6426 Compare March 29, 2026 10:17

[autofix.ci] apply automated fixes

b3a0e23

timothysparg changed the title ~~feat(builtins): add google-java-format~~ feat(builtins): add google-java-format to builtins Mar 29, 2026

jdx merged commit 63bd8cf into jdx:main Mar 31, 2026
19 checks passed

jdx mentioned this pull request Mar 31, 2026

chore: release v1.40.0 #763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(builtins): add google-java-format to builtins#777

feat(builtins): add google-java-format to builtins#777
jdx merged 5 commits intojdx:mainfrom
timothysparg:feat/builtins/google-java-format

timothysparg commented Mar 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 28, 2026

Uh oh!

greptile-apps Bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

timothysparg commented Mar 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Mar 28, 2026 •

edited

Loading