Skip to content

Comments

feat: add fix-smart-quotes util#348

Merged
jdx merged 1 commit intojdx:mainfrom
joonas:feat/fix-smart-quotes
Oct 5, 2025
Merged

feat: add fix-smart-quotes util#348
jdx merged 1 commit intojdx:mainfrom
joonas:feat/fix-smart-quotes

Conversation

@joonas
Copy link
Contributor

@joonas joonas commented Oct 5, 2025

This implements fix-smart-quotes utility, similar to what sirosen/texthooks provides for pre-commit.

I am being intentionally conservative on the supported code points to start with as more could be added.

Signed-off-by: Joonas Bergius <[email protected]>
@jdx jdx merged commit 25a4b15 into jdx:main Oct 5, 2025
11 checks passed
@joonas joonas deleted the feat/fix-smart-quotes branch October 5, 2025 17:27
@jdx jdx mentioned this pull request Oct 5, 2025
jdx added a commit that referenced this pull request Oct 5, 2025
## [1.18.0](https://github.com/jdx/hk/compare/v1.17.0..v1.18.0) -
2025-10-05

### 🚀 Features

- add fix-smart-quotes util by [@joonas](https://github.com/joonas) in
[#348](#348)

### 🐛 Bug Fixes

- add Windows support by guarding Unix-specific file permission APIs by
[@jdx](https://github.com/jdx) in
[#349](#349)
- handle missing files in update-version script by
[@jdx](https://github.com/jdx) in
[#350](#350)
- rewrite update-version script to avoid pipefail issues by
[@jdx](https://github.com/jdx) in
[211b1ac](211b1ac)
- run render before update-version in release script by
[@jdx](https://github.com/jdx) in
[35d2df3](35d2df3)
- use [0-9] instead of \d in ripgrep pattern for better compatibility by
[@jdx](https://github.com/jdx) in
[cf8ebb0](cf8ebb0)
- explicitly specify search path for ripgrep in update-version script by
[@jdx](https://github.com/jdx) in
[5666f96](5666f96)

### 🔍 Other Changes

- add diagnostic output to update-version script by
[@jdx](https://github.com/jdx) in
[aaeea63](aaeea63)
- add more file existence checks by [@jdx](https://github.com/jdx) in
[cbace40](cbace40)
- test rg pattern matching in CI environment by
[@jdx](https://github.com/jdx) in
[a52ea46](a52ea46)

### New Contributors

- @joonas made their first contribution in
[#348](#348)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps hk to 1.18.0, updates docs/CLI/templates to new Pkl package
URLs, and refreshes a dependency.
> 
> - **Version bump**:
> - Set crate/app version to `1.18.0` in `Cargo.toml`, `Cargo.lock`
(package `hk`), `hk.usage.kdl`, `docs/cli/commands.json`, and
`docs/cli/index.md`.
> - **Docs/examples**:
> - Update `amends`/`import` URLs from `v1.2.0` to `v1.18.0` across
`docs/*`, `hk-example.pkl`, and example `.pkl` files.
>   - Add `CHANGELOG.md` entry for `1.18.0`.
> - **CLI/templates**:
>   - Update init template in `src/cli/init.rs` to use `v1.18.0` URLs.
>   - Refresh error hint URL in `src/config.rs` to `v1.18.0`.
> - **Dependencies**:
>   - Bump `flate2` to `1.1.4` in `Cargo.lock`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
fc59481. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: mise-en-dev <[email protected]>
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 10, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [hk](https://github.com/jdx/hk) | minor | `1.15.7` -> `1.18.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jdx/hk (hk)</summary>

### [`v1.18.3`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1183---2025-10-07)

[Compare Source](jdx/hk@v1.18.2...v1.18.3)

##### 🐛 Bug Fixes

- stash untracked files during partial stashes when HK\_STASH\_UNTRACKED=true by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;357](jdx/hk#357)

### [`v1.18.2`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1182---2025-10-06)

[Compare Source](jdx/hk@v1.18.1...v1.18.2)

##### 🐛 Bug Fixes

- stage directive to include untracked files matching globs by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;355](jdx/hk#355)

### [`v1.18.1`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1181---2025-10-05)

[Compare Source](jdx/hk@v1.18.0...v1.18.1)

##### 🐛 Bug Fixes

- prevent race condition when files are deleted between collection and execution by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;353](jdx/hk#353)

### [`v1.18.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1180---2025-10-05)

[Compare Source](jdx/hk@v1.16.0...v1.18.0)

##### 🚀 Features

- add fix-smart-quotes util by [@&#8203;joonas](https://github.com/joonas) in [#&#8203;348](jdx/hk#348)

##### 🐛 Bug Fixes

- add Windows support by guarding Unix-specific file permission APIs by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;349](jdx/hk#349)
- handle missing files in update-version script by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;350](jdx/hk#350)
- rewrite update-version script to avoid pipefail issues by [@&#8203;jdx](https://github.com/jdx) in [211b1ac](jdx/hk@211b1ac)
- run render before update-version in release script by [@&#8203;jdx](https://github.com/jdx) in [35d2df3](jdx/hk@35d2df3)
- use \[0-9] instead of \d in ripgrep pattern for better compatibility by [@&#8203;jdx](https://github.com/jdx) in [cf8ebb0](jdx/hk@cf8ebb0)
- explicitly specify search path for ripgrep in update-version script by [@&#8203;jdx](https://github.com/jdx) in [5666f96](jdx/hk@5666f96)

##### 🔍 Other Changes

- add diagnostic output to update-version script by [@&#8203;jdx](https://github.com/jdx) in [aaeea63](jdx/hk@aaeea63)
- add more file existence checks by [@&#8203;jdx](https://github.com/jdx) in [cbace40](jdx/hk@cbace40)
- test rg pattern matching in CI environment by [@&#8203;jdx](https://github.com/jdx) in [a52ea46](jdx/hk@a52ea46)

##### New Contributors

- [@&#8203;joonas](https://github.com/joonas) made their first contribution in [#&#8203;348](jdx/hk#348)

### [`v1.16.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1160---2025-10-02)

[Compare Source](jdx/hk@v1.15.7...v1.16.0)

##### 🚀 Features

- add HK\_STAGE setting to control automatic staging of fixed files by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;313](jdx/hk#313)
- suppress check output\_summary when fixer runs with check\_first by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;315](jdx/hk#315)

##### 🐛 Bug Fixes

- \--slow flag now properly enables slow profile by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;317](jdx/hk#317)

##### 📚 Documentation

- Update getting\_started.md by [@&#8203;jdx](https://github.com/jdx) in [a8c1a35](jdx/hk@a8c1a35)

##### 🔍 Other Changes

- Update getting\_started.md by [@&#8203;jdx](https://github.com/jdx) in [58c0564](jdx/hk@58c0564)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzIuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzOC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
jdx pushed a commit that referenced this pull request Nov 25, 2025
Adds a new `fix_smart_quotes` built-in using the `fix-smart-quotes` util
from #348

Signed-off-by: Joonas Bergius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants