fix(hook): preserve configured output_summary label on failure

jdx · claude · jdx · commit f0090e4bdda4 · 2026-04-10T00:18:07.000Z
PR #772 forced Combined output on failure to avoid losing diagnostics, but this changed the summary header label (e.g., "lint output:" instead of "lint stderr:"), breaking #784's tests. Use combined content on failure but keep the configured label. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/src/step/output.rs b/src/step/output.rs
@@ -46,12 +46,14 @@ impl Step {
             return;
         }
 
-        // On failure, show combined output so diagnostic messages are never
-        // lost regardless of which stream the tool writes to — unless the
-        // step explicitly opted out with `output_summary = "hide"`.
+        // On failure, use combined output so diagnostic messages are never
+        // lost regardless of which stream the tool writes to — but keep
+        // the configured label so tests/users see the expected header.
+        // If the step explicitly opted out with `output_summary = "hide"`,
+        // respect that even on failure.
         if is_failure && self.output_summary != OutputSummary::Hide {
             ctx.hook_ctx
-                .append_step_output(&self.name, OutputSummary::Combined, combined)
+                .append_step_output(&self.name, self.output_summary.clone(), combined)
         } else {
             match self.output_summary {
                 OutputSummary::Stderr => {
