fix: review问题修改

irisSong · irisSong · commit 07665aed9ac3 · 2024-11-04T15:56:59.000+08:00
diff --git a/src/packages/searchbar/demo.taro.tsx b/src/packages/searchbar/demo.taro.tsx
@@ -67,10 +67,8 @@ const SearchBarDemo = () => {
         <Demo4 />
         <View className="h2">{translated.title5}</View>
         <Demo5 />
-        {/* 组件引入Popover组件，带Popover组件适配harmony后验证 */}
-        {harmony() ? (
-          <></>
-        ) : (
+        {/* 组件引入Popover组件，待Popover组件适配harmony后验证 */}
+        {!harmony() && (
           <>
             <View className="h2">{translated.title7}</View>
             <Demo6 />
diff --git a/src/packages/searchbar/demos/taro/demo6.tsx b/src/packages/searchbar/demos/taro/demo6.tsx
@@ -30,7 +30,7 @@ const Demo6 = () => {
               }}
             >
               更多
-              <ArrowDown size={12} style={{ marginLeft: '5px' }} />
+              <ArrowDown size={16} />
             </View>
           </Popover>
         }
diff --git a/src/packages/searchbar/searchbar.scss b/src/packages/searchbar/searchbar.scss
@@ -49,6 +49,7 @@
 
     & > div,
     & > span,
+    & > i,
     & > svg {
       margin-right: $searchbar-gap;
 
@@ -63,6 +64,7 @@
 
     & > div,
     & > span,
+    & > i,
     & > svg {
       margin-left: $searchbar-gap;
 
diff --git a/src/packages/searchbar/searchbar.taro.tsx b/src/packages/searchbar/searchbar.taro.tsx
@@ -99,12 +99,12 @@ export const SearchBar: FunctionComponent<
     eventValue === '' && forceFocus()
   }
   const focus = (event: any) => {
-    onFocus && onFocus?.(event?.detail?.value, event)
+    onFocus && onFocus(event?.detail?.value, event)
   }
   const blur = (event: any) => {
     const searchSelf: HTMLInputElement | null = searchRef.current
     searchSelf && searchSelf.blur()
-    onBlur && onBlur?.(event?.detail?.value, event)
+    onBlur && onBlur(event?.detail?.value, event)
   }
   useEffect(() => {
     setValue(outerValue || '')

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ const Demo6 = () => {`
`30`	`30`	`}}`
`31`	`31`	`>`
`32`	`32`	`更多`
`33`		`- <ArrowDown size={12} style={{ marginLeft: '5px' }} />`
	`33`	`+ <ArrowDown size={16} />`
`34`	`34`	`</View>`
`35`	`35`	`</Popover>`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,12 +99,12 @@ export const SearchBar: FunctionComponent<`
`99`	`99`	`eventValue === '' && forceFocus()`
`100`	`100`	`}`
`101`	`101`	`const focus = (event: any) => {`
`102`		`- onFocus && onFocus?.(event?.detail?.value, event)`
	`102`	`+ onFocus && onFocus(event?.detail?.value, event)`
`103`	`103`	`}`
`104`	`104`	`const blur = (event: any) => {`
`105`	`105`	`const searchSelf: HTMLInputElement \| null = searchRef.current`
`106`	`106`	`searchSelf && searchSelf.blur()`
`107`		`- onBlur && onBlur?.(event?.detail?.value, event)`
	`107`	`+ onBlur && onBlur(event?.detail?.value, event)`
`108`	`108`	`}`
`109`	`109`	`useEffect(() => {`
`110`	`110`	`setValue(outerValue \|\| '')`