Fix: Close Terraform AWS Provider binary#116
Merged
Merged
Conversation
jckuester
force-pushed
the
fix/close-terraform-provider-binary
branch
from
a22996f to
01da67d
Compare
The binary process kept running in the background after the awsweeper process terminated. Other features/fixes in this commit are included by bumping up the version of terradozer to v0.1.2: 1. Ignore non-existing resources (of type cty.Nil): This means, AWS instances that are in state TERMINATED, NAT gateways that are not available anymore, etc. are filtered out and not shown 2. Fix panic of nil pointer dereference when trying to destroy a resource that doesn't exist anymore (however, nil pointer shouldn't happen anymore because of 1.) 3. Offline mode: don't re-download Terraform provider binary if binary exists already in ~/.awsweeper/terraform-provider-aws_v2.68.0_x4
jckuester
force-pushed
the
fix/close-terraform-provider-binary
branch
from
baf574d to
185172b
Compare
This was referenced Sep 4, 2020
Only using v2 now
jckuester
force-pushed
the
fix/close-terraform-provider-binary
branch
from
b3e54e4 to
54998fb
Compare
Repository owner
deleted a comment from
codecov-commenter
Sep 6, 2020
jckuester
force-pushed
the
fix/close-terraform-provider-binary
branch
from
54998fb to
8e20523
Compare
Repository owner
deleted a comment from
codecov-commenter
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary process of the Terraform AWS Provider kept running in the background after the awsweeper process terminated. This PR closes the provider process before awsweeper exits.
Other features/fixes in this PR are included by bumping up the
version of terradozer to v0.1.2:
Ignore non-existing resources (of type cty.Nil): This means, AWS instances
that are in state TERMINATED, NAT gateways that are not available anymore,
etc. are filtered out and not shown
Fix panic of nil pointer dereference when trying to
destroy a resource that doesn't exist anymore (however,
nil pointer shouldn't happen anymore because of 1.)
Offline mode: don't re-download Terraform provider binary
if binary exists already in ~/.awsweeper/terraform-provider-aws_v2.68.0_x4