fix: #425 ensure accept/reject port type is a set#426
Merged
jchanvfx merged 1 commit intojchanvfx:mainfrom Jul 16, 2024
jack-mil:reject_port_fix#425
Merged
fix: #425 ensure accept/reject port type is a set#426jchanvfx merged 1 commit intojchanvfx:mainfrom jack-mil:reject_port_fix#425
jchanvfx merged 1 commit intojchanvfx:mainfrom
jack-mil:reject_port_fix#425
Conversation
If a session is loaded that has an accept_port_types or reject_port_types field, when the json file is de-serialized, what should be a set internally becomes a list. This commit ensures that the data in the model is always a set, making conversion each time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a session is loaded that has an accept_port_types or reject_port_types field, when the json file is de-serialized, what should be a set internally becomes a list.
This commit ensures that the data in the model is always a set, making conversion each time.