fix: prefer NSIS installer for Windows download button#79
Conversation
The landing page asset matcher matched any .exe, which could link to the portable build instead of the installer. Narrow the match to Setup*.exe so the download button consistently serves the NSIS installer.
There was a problem hiding this comment.
Pull request overview
Updates the landing page’s GitHub release asset selection so the Windows download button consistently points to the NSIS installer instead of potentially selecting the portable .exe.
Changes:
- Narrow Windows asset matching from “any
.exe” to aSetup…exe-style matcher.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
website/index.html
Outdated
| const ASSET_MATCH = { | ||
| mac: (name) => name.endsWith('.dmg') && !name.endsWith('.blockmap'), | ||
| win: (name) => name.endsWith('.exe') && !name.endsWith('.blockmap'), | ||
| win: (name) => /Setup.*\.exe$/.test(name) && !name.endsWith('.blockmap'), |
There was a problem hiding this comment.
The PR description says the Windows matcher was narrowed to Setup*.exe, but the current regex /Setup.*\.exe$/ matches any asset name containing Setup anywhere (e.g. it would also match Foo-SetupHelper.exe if that ever gets published). Given the configured artifact name is ${productName}-Setup-${version}.exe (electron-builder.yml), consider tightening the matcher to the actual pattern (e.g., require -Setup- or VibeGrid-Setup- prefix) so the landing page can’t accidentally pick a different .exe in future releases.
Matches the actual electron-builder artifact name template
(${productName}-Setup-${version}.exe) to avoid false positives.
Summary
.exeasset, which could link to the portable build instead of the installerSetup*.exeso it consistently serves the NSIS installer, matching the behavior ofinstall.ps1Test plan
.exe