Handle unfinished checks by volodya-lombrozo · Pull Request #1629 · jcabi/jcabi-github

volodya-lombrozo · 2023-04-06T20:58:47Z

If check isn't finished GitHub returns the JSON with "conclusion":null which causes some errors like that issue.
I've added the logic that handle that situation.

…ation

volodya-lombrozo · 2023-04-06T21:01:33Z

@yegor256 Could you have a look, please?

yegor256 · 2023-04-07T02:27:37Z

@rultor merge

rultor · 2023-04-07T02:29:42Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2023-04-07T02:33:43Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

volodya-lombrozo · 2023-04-07T06:15:31Z

@yegor256 Could you release a new version, please?

yegor256 · 2023-04-07T07:56:05Z

@rultor release, tag is 1.6.4

rultor · 2023-04-07T07:57:39Z

@rultor release, tag is 1.6.4

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2023-04-07T08:05:14Z

@rultor release, tag is 1.6.4

@volodya-lombrozo @yegor256 Oops, I failed. You can see the full log here (spent 7min)

    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.sonatype.nexus.client.core.exception.NexusClientResponseException: 504 - Gateway Timeout
    at org.sonatype.nexus.client.rest.jersey.JerseyNexusClient.convert (JerseyNexusClient.java:276)
    at org.sonatype.nexus.client.rest.jersey.JerseyNexusClient.getStatus (JerseyNexusClient.java:156)
    at org.sonatype.nexus.client.internal.rest.AbstractNexusClient.initializeConnection (AbstractNexusClient.java:86)
    at org.sonatype.nexus.client.rest.jersey.JerseyNexusClient.<init> (JerseyNexusClient.java:90)
    at org.sonatype.nexus.client.rest.jersey.NexusClientFactoryImpl.createFor (NexusClientFactoryImpl.java:125)
    at org.sonatype.nexus.maven.staging.remote.RemoteNexus.createNexusClient (RemoteNexus.java:193)
    at org.sonatype.nexus.maven.staging.remote.RemoteNexus.<init> (RemoteNexus.java:102)
    at org.sonatype.nexus.maven.staging.deploy.strategy.AbstractStagingDeployStrategy.createRemoteNexus (AbstractStagingDeployStrategy.java:58)
    at org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.deployPerModule (StagingDeployStrategy.java:70)
    at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute (DeployMojo.java:192)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
\u001b[0m\u001b[0mcontainer b33ff9459c4758314945c9bfcc0b2a8a2024d55aef058a1158a9aa7e7d6e7691 is dead
Fri 07 Apr 2023 10:05:08 AM CEST

volodya-lombrozo · 2023-04-07T12:00:55Z

@yegor256 Could you repeat, please?

volodya-lombrozo · 2023-04-08T12:17:39Z

@yegor256 Reminder

volodya-lombrozo · 2023-04-13T06:45:29Z

@yegor256 Reminder

yegor256 · 2023-04-13T07:04:46Z

@rultor release, tag is 1.6.4

rultor · 2023-04-13T07:06:59Z

@rultor release, tag is 1.6.4

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2023-04-13T07:46:28Z

@rultor release, tag is 1.6.4

@yegor256 Done! FYI, the full log is here (took me 39min)

yegor256 · 2023-04-13T08:21:02Z

@volodya-lombrozo done

volodya-lombrozo added 3 commits April 6, 2023 22:19

Add tests for checks that was unfinished and don't have enough inform…

5f7a1c7

…ation

Handle unfinished checks properly

19334d4

Add test for nullable conclusion

b5db32f

rultor merged commit b5db32f into jcabi:master Apr 7, 2023

Conversation

volodya-lombrozo commented Apr 6, 2023

Uh oh!

volodya-lombrozo commented Apr 6, 2023

Uh oh!

yegor256 commented Apr 7, 2023

Uh oh!

rultor commented Apr 7, 2023

Uh oh!

rultor commented Apr 7, 2023

Uh oh!

volodya-lombrozo commented Apr 7, 2023

Uh oh!

yegor256 commented Apr 7, 2023

Uh oh!

rultor commented Apr 7, 2023

Uh oh!

rultor commented Apr 7, 2023

Uh oh!

volodya-lombrozo commented Apr 7, 2023

Uh oh!

volodya-lombrozo commented Apr 8, 2023

Uh oh!

volodya-lombrozo commented Apr 13, 2023

Uh oh!

yegor256 commented Apr 13, 2023

Uh oh!

rultor commented Apr 13, 2023

Uh oh!

rultor commented Apr 13, 2023

Uh oh!

yegor256 commented Apr 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants