Skip to content

Make RtChecks more safe#1625

Merged
yegor256 merged 3 commits intojcabi:masterfrom
volodya-lombrozo:safe_rt_checks
Mar 27, 2023
Merged

Make RtChecks more safe#1625
yegor256 merged 3 commits intojcabi:masterfrom
volodya-lombrozo:safe_rt_checks

Conversation

@volodya-lombrozo
Copy link
Copy Markdown
Contributor

In that PR:

  1. Added check for check_runs json field - if it's empty (or absent) we just return empty list of checks.
  2. Added check for 200 OK response in order to print full error massage from HTTP response in case of error.
  3. Use sha instead of named ref - more secure.

@volodya-lombrozo
Copy link
Copy Markdown
Contributor Author

@yegor256 Could you have a look, please?

@volodya-lombrozo
Copy link
Copy Markdown
Contributor Author

@yegor256 I'm not sure how to handle that PR, but probably we have to revert Rultor to the earlier version first, then merge that changes and release a new version of jcabi-github, then update Rultor and redeploy a new version.

@yegor256 yegor256 merged commit 4420464 into jcabi:master Mar 27, 2023
@yegor256
Copy link
Copy Markdown
Member

@rultor release, tag is 1.6.2

@rultor
Copy link
Copy Markdown
Contributor

rultor commented Mar 27, 2023

@rultor release, tag is 1.6.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Copy Markdown
Contributor

rultor commented Mar 27, 2023

@rultor release, tag is 1.6.2

@yegor256 Done! FYI, the full log is here (took me 38min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants