Merged
Conversation
add MkChecks and MkCheck implementation
Contributor
Author
|
@yegor256 Could you have a look, please? |
yegor256
reviewed
Mar 21, 2023
pom.xml
Outdated
| <version>31.1-jre</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.cactoos</groupId> |
Member
There was a problem hiding this comment.
@volodya-lombrozo can't you use Guava instead? It's already in the list of dependencies and provides the same functionality of turning an Iterable to a List.
Contributor
Author
There was a problem hiding this comment.
@yegor256 Done. Could you have a look, again, please?
Contributor
Author
|
@yegor256 Reminder |
Member
|
@rultor merge |
Contributor
Contributor
Contributor
Author
|
@yegor256 Could you release a new version, please? |
Member
|
@rultor release, tag is |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started implementing a feature related to
Checks, but I quickly realized that I lacked testing capabilities. Therefore, I decided to improve my implementation by adding correct implementations ofMkChecksandMkCheck. In my pull request, I added the following changes:MkChecksandMkCheck.MkChecksandMkCheck.Please, let me know if that PR too big, I'll try to split it.