Add test for nullable conclusion

volodya-lombrozo · volodya-lombrozo · commit b5db32f766a2 · 2023-04-06T23:52:16.000+03:00
diff --git a/src/main/java/com/jcabi/github/RtChecks.java b/src/main/java/com/jcabi/github/RtChecks.java
@@ -139,7 +139,7 @@ private static String getOrUndefined(
         final JsonObject check
     ) {
         final String res;
-        if (check.containsKey(key)) {
+        if (check.containsKey(key) && !check.isNull(key)) {
             res = check.getString(key);
         } else {
             res = Check.UNDEFINED_VALUE;
diff --git a/src/test/java/com/jcabi/github/RtChecksTest.java b/src/test/java/com/jcabi/github/RtChecksTest.java
@@ -41,6 +41,7 @@
 import javax.json.Json;
 import javax.json.JsonArrayBuilder;
 import javax.json.JsonObjectBuilder;
+import javax.json.JsonValue;
 import org.hamcrest.MatcherAssert;
 import org.hamcrest.Matchers;
 import org.junit.Assert;
@@ -62,6 +63,11 @@ public final class RtChecksTest {
      */
     private static final String CONCLUSION_KEY = "conclusion";
 
+    /**
+     * Status key in json check.
+     */
+    private static final String STATUS_KEY = "status";
+
     /**
      * The rule for skipping test if there's BindException.
      * @checkstyle VisibilityModifierCheck (3 lines)
@@ -183,6 +189,45 @@ public void retrievesUnfinishedChecksWithoutConclusion()
         }
     }
 
+    /**
+     * Checks that library can handle unfinished checks.
+     * @throws IOException If some I/O problem happens.
+     */
+    @Test
+    public void retrievesUnfinishedChecksWithNullableConclusion()
+        throws IOException {
+        try (final MkContainer container = new MkGrizzlyContainer()
+            .next(
+                new MkAnswer.Simple(
+                    HttpURLConnection.HTTP_OK,
+                    RtChecksTest.jsonChecks(
+                        RtChecksTest.jsonCheck()
+                            .add(
+                                RtChecksTest.CONCLUSION_KEY,
+                                JsonValue.NULL
+                            ).add(
+                                RtChecksTest.STATUS_KEY,
+                                Check.Status.QUEUED.value()
+                            )
+                    )
+                )
+            ).start(this.resource.port())
+        ) {
+            final Checks checks = new RtChecks(
+                new JdkRequest(container.home()),
+                this.repo().pulls().get(0)
+            );
+            final Collection<? extends Check> all = checks.all();
+            MatcherAssert.assertThat(all, Matchers.hasSize(1));
+            for (final Check check : all) {
+                MatcherAssert.assertThat(
+                    check.successful(),
+                    Matchers.is(false)
+                );
+            }
+        }
+    }
+
     /**
      * Checks that library can handle unfinished checks.
      * @throws IOException If some I/O problem happens.
@@ -223,7 +268,10 @@ public void retrievesUnfinishedChecksWithoutStatusAndConclusion()
     private static String jsonWithCheckRuns() {
         return RtChecksTest.jsonChecks(
             RtChecksTest.jsonCheck()
-                .add("status", Check.Status.COMPLETED.value())
+                .add(
+                    RtChecksTest.STATUS_KEY,
+                    Check.Status.COMPLETED.value()
+                )
                 .add(
                     RtChecksTest.CONCLUSION_KEY,
                     Check.Conclusion.SUCCESS.value()
