@jbevain thoughts on this one?

Yes yes yes. Just rename PublicKeyBytes to PublicKey and this is good to go. Thanks for the contribution!

Also a test would be nice.

Reviewing this, why not simply setting the PublicKey of the assembly name before writing?

@SimonCropp I don't see why this is needed and why you can't create a delay signed without having this new parameter. As far as I can tell, you can create an AssemblyDefinition with the proper flags and the proper public key, and it will be considered delay signed.

@jbevain i will defer to @ryknuth on that. since he said it was required

@jbevain and @SimonCropp Isn't that what I'm doing? I'm passing in the PublicKey to be set into the AssemblyDefinition that is used to write the assembly. There's already the StrongNameKeyPair for signing with a private key. If we want to allow delay signing, we should allow people to pass in the public key bytes.

@ryknuth yeah but you can already set the PublicKey on the assembly definition:

assembly.Name.PublicKey = publicKey;

Without having to add a new API to the WriterParameters.

I see, let me paste some code here to ensure I understand. The change would be completely in Fody.

        var parameters = new WriterParameters
            {
#if NET46
                StrongNameKeyPair = StrongNameKeyPair,
#endif
                WriteSymbols = debugWriterProvider != null,
                SymbolWriterProvider = debugWriterProvider,
            };

      ModuleDefinition.Assembly.Name.PublicKey = KeyFileBytes;
      ModuleDefinition.Write(AssemblyFilePath, parameters);

The added line is this:
ModuleDefinition.Assembly.Name.PublicKey = KeyFileBytes;

Am I understanding correctly?

I think it looks correct. You might have to turn on a flag as well on the Module:

module.Attributes |= ModuleAttributes.StrongNameSigned;

But I'm not 100% sure.

With delay signing, we shouldn't set StrongNameSigned if I recall correctly since it actually isn't signed.