Merged
Conversation
Don't install LIBRARIES on Windows to `bin`; they belong in `lib`. (This appears to have been done in a mistaken attempt to install the DLL's to `bin`, which do need to be there, but RUNTIME DESTINATION already takes care of this.)
Remove use of CMAKE_INSTALL_PREFIX when specifying install destinations. It is preferred that install destinations are specified as relative paths, not absolute paths. This is also needed to create relocatable installs, and thus should fix jbeder#526.
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 16, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina.
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 16, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina. Signed-off-by: O. Stasse <[email protected]>
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 16, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina. Signed-off-by: Olivier Stasse <[email protected]>
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 17, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina. Signed-off-by: Olivier Stasse <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows library install location (
.libs belong inlib;RUNTIME DESTINATIONalready takes care of installing.dlls tobin). Remove use ofCMAKE_INSTALL_PREFIXwhen specifying install destinations. (Note: It is preferred that install destinations are specified as relative paths, not absolute paths. This is also needed to create relocatable installs.)This should fix #526.