Remove extras from compiled files #1953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atugushev
added
enhancement
ryanhiebert
requested changes
Aug 5, 2023
Contributor
ryanhiebert
left a comment
ryanhiebert
left a comment
There was a problem hiding this comment.
It will be a breaking change to change the default. We should do it at some point, but if we're going to add --include-extras, and I think we should based on prior feedback, we should add that argument to a minor version bump to anticipate this breaking change, and to allow people to silence the warning of the breaking change of the default.
| to pass the `--allow-unsafe` now to adapt to the upcoming change. | ||
| - The legacy resolver is deprecated and will be removed in future versions. | ||
| The new default is `--resolver=backtracking`. | ||
| - `--strip-extras` is deprecated. It has no effect and will be removed in future versions. |
Contributor
There was a problem hiding this comment.
As noted on the relevant issue, --strip-extras does have an effect, even with the new default resolver.
Member
Author
|
@ryanhiebert, thanks for the review! I'll close the PR based on this #1613 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1613.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.