Add --no-config option#1896
Conversation
atugushev
added
enhancement
| dry_run_message = "Would install:" | ||
| assert dry_run_message in out.stdout | ||
|
|
||
| out = runner.invoke(cli, ["--no-config", "--config", config_file.as_posix()]) |
There was a problem hiding this comment.
This should be a separate test with its own name or at least a parametrized case..
There was a problem hiding this comment.
Generally, I agree, however in this case, I prefer the triangulation technique.
There was a problem hiding this comment.
I don't see how it's applicable in this case. You're clearly testing two separate behaviors that must appear as separate entries in the test report.
The only way of having two things reported from the same test function is to use pytest-subtest. But it still feels wrong since you're not checking two properties of the same behavior outcome.
There was a problem hiding this comment.
Also, for property-based testing, we should really integrate Hypothesis..
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
Let's try making the test names reflect what it is we're testing...
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
2 participants
Addresses #1863 (comment).
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.