Skip to content

Exclude default config value from the pip-compile header#1893

Merged
atugushev merged 4 commits intojazzband:mainfrom
atugushev:hide-default-config-from-header
Jul 1, 2023
Merged

Exclude default config value from the pip-compile header#1893
atugushev merged 4 commits intojazzband:mainfrom
atugushev:hide-default-config-from-header

Conversation

@atugushev
Copy link
Copy Markdown
Member

@atugushev atugushev commented Jun 29, 2023

Resolves #1863 (comment)

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the bug Something is not working label Jun 29, 2023
@atugushev atugushev added this to the 6.14.0 milestone Jun 29, 2023
@atugushev atugushev added skip-changelog Avoid listing in changelog and removed bug Something is not working labels Jun 29, 2023
Comment thread piptools/utils.py
Comment thread tests/test_utils.py
Comment thread piptools/utils.py Outdated
@atugushev atugushev force-pushed the hide-default-config-from-header branch from de61ace to 4008509 Compare June 29, 2023 17:39
@chrysle
Copy link
Copy Markdown
Contributor

chrysle commented Jun 29, 2023

Looks like something is wrong with QA & CI.. Let's restart the jobs tomorrow. And maybe wait until #1894 is merged for the failing PyPy tests.

@webknjaz
Copy link
Copy Markdown
Member

This will need rebasing on top of #1895.

@atugushev atugushev enabled auto-merge (squash) July 1, 2023 06:16
@atugushev atugushev merged commit e8b8ce7 into jazzband:main Jul 1, 2023
@93578237
Copy link
Copy Markdown
Contributor

93578237 commented Jul 6, 2023

@atugushev There is a bug with pip 6.14.0.
I just use pip-compile --allow-unsafe --generate-hashes --output-file=requirements/test.txt --resolver=backtracking --strip-extras requirements/test.in
but now it adds --config=pyproject.toml even there is no configuration in pyproject.toml
When running pip-compile click context has no src_files, so select_config_file returns pyproject.toml, but after compiling click context has src_files as requirements/test.in, so select_config_file returns None and so pyproject.toml != None

Making --config is_eager=False works
#1902

@atugushev
Copy link
Copy Markdown
Member Author

@q0w thanks for heads up. Referenced this in #1903

@atugushev atugushev deleted the hide-default-config-from-header branch July 6, 2023 23:09
@atugushev atugushev added the config Related to pip-tools' configuration label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Related to pip-tools' configuration skip-changelog Avoid listing in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants