Added silk_request_garbage_collect command for out-of-band garbage collection. #541
Conversation
…llection. To avoid deadlock issues as mentioned e.g. in jazzband#265 jazzband#294 jazzband#371 Based on jazzband#265 (comment)
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 84.60% 84.72% +0.11%
==========================================
Files 51 52 +1
Lines 2059 2075 +16
==========================================
+ Hits 1742 1758 +16
Misses 317 317
Continue to review full report at Codecov.
|
|
Hi @nschlemm, Thanks for mentioning me in this patch and asking for a review. |
|
@hramezani sorry, then github must definitely step up their game for suggesting reviewers ;) and I can't see an option to "release" you from this mention... @auvipy as release author of 4.2.0 would you be willing to review this? thx! |
|
Even when triggered manually through this command, it's still possible for deadlocks to happen unless the database is receiving no other writes during the period. This isn't going to guarantee fixing deadlocks. There should be a full solution made to fix deadlocks, though the ability to manually trigger cleanup perhaps during low-traffic hours is still useful. |
|
There are some rebase conflicts. @nschlemm Please rebase and this can be merged. |
3 participants
To avoid deadlock issues as mentioned e.g. in #265 #294 #371
Based on #265 (comment)