Promisification #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mahdyar merged 2 commits into javascript-tutorial:master from samanzameni:master

Apr 20, 2025

Contributor

samanzameni commented Apr 18, 2025

Promisification


          Update article.md

b93cf7f

Promisification

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

April 18, 2025 11:33

mahdyar changed the title ~~article.md~~ Promisification

mahdyar requested changes

View reviewed changes

Member

mahdyar left a comment

Hi @samanzameni & Thank you for your contribution.

Please read the instruction "For New Translators" in #1 for the next ones!

Also please resolve the conflicts so I'll be able to merge it.

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Apr 19, 2025

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

4 similar comments

javascript-translate-bot commented Apr 19, 2025

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot commented Apr 19, 2025

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot commented Apr 19, 2025

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot commented Apr 19, 2025

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻


          Merge remote-tracking branch 'upstream/master'

f17c577

Contributor Author

samanzameni commented Apr 20, 2025

/done

javascript-translate-bot added review needed and removed changes requested labels

javascript-translate-bot requested a review from a team

April 20, 2025 09:10

mahdyar approved these changes

View reviewed changes

Member

mahdyar left a comment

Thank you, @samanzameni!

javascript-translate-bot added needs +1 and removed review needed labels

mahdyar merged commit 54a4aeb into javascript-tutorial:master

1 check passed

javascript-translate-bot commented Apr 20, 2025

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

2 similar comments

javascript-translate-bot commented Apr 20, 2025

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

javascript-translate-bot commented Apr 20, 2025

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

javascript-translate-bot commented Apr 20, 2025

Error: the article already translated in the Progress Issue #1 ⁉️

1 similar comment

javascript-translate-bot commented Apr 20, 2025

Error: the article already translated in the Progress Issue #1 ⁉️

javascript-translate-bot commented Apr 20, 2025

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

javascript-translate-bot mentioned this pull request

Persian (Farsi) Translation Progress #1

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels